Skip to content

gve: Alloc before freeing when changing config

Shailend Chand netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesApplied 6/6

Patches in v1 All 6 applied

#Subject and filesSizeRepliesApplied
1/6gve: Define config structs for queue allocationdrivers/net/ethernet/google/gve/gve.h+49 -01 replyApplied
2/6gve: Refactor napi add and remove functionsdrivers/net/ethernet/google/gve/gve.h drivers/net/ethernet/google/gve/gve_dqo.h drivers/net/ethernet/google/gve/gve_main.c +2 more+26 -171 replyApplied
3/6gve: Switch to config-aware queue allocationdrivers/net/ethernet/google/gve/gve.h drivers/net/ethernet/google/gve/gve_dqo.h drivers/net/ethernet/google/gve/gve_main.c +6 more+745 -4251 replyApplied
4/6gve: Refactor gve_open and gve_closedrivers/net/ethernet/google/gve/gve_main.c+119 -400 repliesApplied
5/6gve: Alloc before freeing when adjusting queuesdrivers/net/ethernet/google/gve/gve_main.c+67 -220 repliesApplied
6/6gve: Alloc before freeing when changing featuresdrivers/net/ethernet/google/gve/gve_main.c+21 -200 repliesApplied

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchWillem de BruijnJeroen de BorstSimon Horman
1/6R-b R-b R-b
2/6R-b R-b R-b
3/6R-b R-b R-b
4/6R-b R-b
5/6R-b R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 0/6] gve: Alloc before freeing when changing config

Functions allocating resources did so directly into priv thus far. The assumption doing that was that priv was not already holding references to live resources.

When ring configuration is changed in any way from userspace, thus far we relied on calling the ndo_stop and ndo_open callbacks in succession. This meant that we teardown existing resources and rob the OS of networking before we have successfully allocated resources for the new config.

Correcting this requires us to perform allocations without editing priv. That is what the "gve: Switch to config-aware..." patch does: it modifies all the allocation paths so that they take a new configuration as input and return references to newly allocated resources without modifying priv or interfering with live resources in any way.

Having corrected the allocation paths so, the ndo open and close callbacks are refactored to make available distinct functions for allocating queue resources and starting or stopping them. This is then put to use in the set_channels and set_features hooks in the last two patches.

These changes have been tested by verifying the integrity of a stream of integers while the driver is continuously reconfigured with ethtool.

Shailend Chand (6):
gve: Define config structs for queue allocation
gve: Refactor napi add and remove functions
gve: Switch to config-aware queue allocation
gve: Refactor gve_open and gve_close
gve: Alloc before freeing when adjusting queues
gve: Alloc before freeing when changing features

 drivers/net/ethernet/google/gve/gve.h        | 144 +++-
 drivers/net/ethernet/google/gve/gve_dqo.h    |  18 +-
 drivers/net/ethernet/google/gve/gve_main.c   | 854 ++++++++++++-------
 drivers/net/ethernet/google/gve/gve_rx.c     | 116 ++-
 drivers/net/ethernet/google/gve/gve_rx_dqo.c |  91 +-
 drivers/net/ethernet/google/gve/gve_tx.c     | 128 ++-
 drivers/net/ethernet/google/gve/gve_tx_dqo.c | 108 ++-
 drivers/net/ethernet/google/gve/gve_utils.c  |  31 +
 drivers/net/ethernet/google/gve/gve_utils.h  |   5 +
 9 files changed, 999 insertions(+), 496 deletions(-)
Signature · 1 line
2.43.0.429.g432eaa2c6b-goog