Skip to content

util/uri: Simplify the code, remove unused functions

Thomas Huth qemu-devel qemu-trivial 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v15 patches 12 repliesSuperseded

Changes in v2 from the cover letter

- Replace uri_string_unescape() with g_uri_unescape_segment(), so we can remove uri_string_unescape() completely now

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4util/uri: Remove uri_string_unescape()include/qemu/uri.h util/uri.c+11 -871 reply
2/4util/uri: Remove unused functions uri_resolve() and uri_resolve_relative()include/qemu/uri.h util/uri.c+0 -6910 replies
3/4util/uri: Remove the uri_string_escape() functioninclude/qemu/uri.h util/uri.c+0 -710 replies
4/4util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()util/uri.c+0 -130 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan WeilPhilippe Mathieu-DaudéDaniel P. BerrangéRichard Henderson
SeriesR-b
1/4R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] util/uri: Simplify the code, remove unused functions

The URI function uri_string_unescape() is pretty much the same as the function g_uri_unescape_segment() from the glib, so we can simplify our code here quite a bit.
While at it, I also noticed that there are many other unused functions in here which we likely can drop, too.

v2:
- Replace uri_string_unescape() with g_uri_unescape_segment(), so we can remove uri_string_unescape() completely now

Thomas Huth (4):
util/uri: Remove uri_string_unescape()
util/uri: Remove unused functions uri_resolve() and
uri_resolve_relative()
util/uri: Remove the uri_string_escape() function util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()

 include/qemu/uri.h |   4 -
 util/uri.c         | 869 +--------------------------------------------
 2 files changed, 11 insertions(+), 862 deletions(-)
Signature · 1 line
2.43.0