net/gve: RSS Support for GVE Driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest5 patches 1 replyIn review
- v47 patches 3 repliesSuperseded
- v3 posting 2/27 patches 1 replySuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 posting 1/2 | 7 patches | 0 replies | Superseded | |
| v2 | 7 patches | 0 replies | Superseded | |
| v1 | 7 patches | 0 replies | Superseded |
Changes in v5 from the cover letter
Update commit messages to comply with check-git-log.
Fold feature matrix and documentation updates into relevant commits.
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | net/gve: expose RSS offload support in dev infodrivers/ drivers/ | +11 | 0 replies | |
| 2/5 | net/gve: add RSS adminq commanddrivers/ drivers/ drivers/ +1 more | +107 | 0 replies | |
| 3/5 | net/gve: add gve RSS librarydrivers/ drivers/ drivers/ +3 more | +319 | 0 replies | |
| 4/5 | net/gve: add RSS configuration update supportdoc/ doc/ drivers/ +1 more | +148 | 0 replies | |
| 5/5 | net/gve: add RSS redirection table update supportdoc/ doc/ drivers/ | +104 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Rushil Gupta | Jeroen de Borst |
|---|---|---|
| 1/5 | R-b | R-b |
| 2/5 | R-b | R-b |
| 3/5 | R-b | R-b |
| 4/5 | R-b | R-b |
| 5/5 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/5] net/gve: RSS Support for GVE Driver
This patch series introduces RSS support for the GVE poll-mode driver. This series includes implementations of the following eth_dev_ops:
1) rss_hash_update
2) rss_hash_conf_get
3) reta_query
4) reta_update
In rss_hash_update, the GVE driver supports the following RSS hash types:
* RTE_ETH_RSS_IPV4
* RTE_ETH_RSS_NONFRAG_IPV4_TCP
* RTE_ETH_RSS_NONFRAG_IPV4_UDP
* RTE_ETH_RSS_IPV6
* RTE_ETH_RSS_IPV6_EX
* RTE_ETH_RSS_NONFRAG_IPV6_TCP
* RTE_ETH_RSS_NONFRAG_IPV6_UDP
* RTE_ETH_RSS_IPV6_TCP_EX
* RTE_ETH_RSS_IPV6_UDP_EX
The hash key is 40B, and the lookup table has 128 entries. These values are not configurable in this implementation.
In general, the DPDK driver expects the RSS hash configuration to be set with a key before the redriection table is set up. When the RSS hash is configured, a default redirection table is generated based on the number of queues. When the device is re-configured, the redirection table is reset to the default value based on the queue count.
An important note is that the gVNIC device expects 32 bit integers for RSS redirection table entries, while the RTE API uses 16 bit integers. However, this is unlikely to be an issue, as these values represent receive queues, and the gVNIC device does not support anywhere near 64K queues.
This series also updates the corresponding feature matrix ertries and documentation as it pertains to RSS support in the GVE driver.
v2:
Add commmit messages for patches with it missing, and other checkpatches fixes.
Note: There is a warning about complex macros being parenthesized that does not seem to be well-founded.
v3:
Fix build warnings that come up on certain distros.
v4:
Fix formatting in gve_adminq.c
v5:
Update commit messages to comply with check-git-log.
Fold feature matrix and documentation updates into relevant commits.
Joshua Washington (5):
net/gve: expose RSS offload support in dev info net/gve: add RSS adminq command
net/gve: add gve RSS library
net/gve: add RSS configuration update support net/gve: add RSS redirection table update support
doc/guides/nics/features/gve.ini | 2 + doc/guides/nics/gve.rst | 28 +++- drivers/net/gve/base/gve.h | 15 ++ drivers/net/gve/base/gve_adminq.c | 58 ++++++++ drivers/net/gve/base/gve_adminq.h | 21 +++ drivers/net/gve/gve_ethdev.c | 231 +++++++++++++++++++++++++++++- drivers/net/gve/gve_ethdev.h | 17 +++ drivers/net/gve/gve_rss.c | 206 ++++++++++++++++++++++++++ drivers/net/gve/gve_rss.h | 107 ++++++++++++++ drivers/net/gve/meson.build | 1 + 10 files changed, 677 insertions(+), 9 deletions(-) create mode 100644 drivers/net/gve/gve_rss.c create mode 100644 drivers/net/gve/gve_rss.h
Signature · 1 line
2.43.0.429.g432eaa2c6b-goog