Skip to content

remove incorrect code for loading 16B descriptors

Bruce Richardson dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6net/i40e: remove incorrect 16B descriptor read blockdrivers/net/i40e/i40e_rxtx_vec_avx2.c+0 -130 replies
2/6net/i40e: reduce code indentationdrivers/net/i40e/i40e_rxtx_vec_avx2.c+24 -270 replies
3/6net/iavf: remove incorrect 16B descriptor read blockdrivers/net/iavf/iavf_rxtx_vec_avx2.c+0 -130 replies
4/6net/iavf: reduce code indentdrivers/net/iavf/iavf_rxtx_vec_avx2.c+24 -430 replies
5/6net/ice: remove incorrect 16B descriptor read blockdrivers/net/ice/ice_rxtx_vec_avx2.c+0 -130 replies
6/6net/ice: reduce code indentdrivers/net/ice/ice_rxtx_vec_avx2.c+24 -430 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchAnatoly Burakov
SeriesSeries-Acked-by
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] remove incorrect code for loading 16B descriptors

Inside the AVX2 code paths, there was special case code for loading two 16-byte descriptors simultaneously, if that build-time feature was enabled. As well as not being enabled by default, these code blocks also were incorrect as there is no guarantee of the two descriptors being loaded either atomically or in a defined order. If they were loaded in an unexpected order the driver logic would break. Therefore we remove these blocks, and do come cleanup of the following code to remove indentation.

NOTE: I've split out the removal and subsequent cleanup into separate patches for ease of review. These can be merged into a single patch on merge, if so desired.

Bruce Richardson (6):
net/i40e: remove incorrect 16B descriptor read block net/i40e: reduce code indentation
net/iavf: remove incorrect 16B descriptor read block net/ice: remove incorrect 16B descriptor read block net/ice: reduce code indent
net/iavf: reduce code indent

 drivers/net/i40e/i40e_rxtx_vec_avx2.c | 64 ++++++++-------------
 drivers/net/iavf/iavf_rxtx_vec_avx2.c | 80 ++++++++-------------------
 drivers/net/ice/ice_rxtx_vec_avx2.c   | 80 ++++++++-------------------
 3 files changed, 72 insertions(+), 152 deletions(-)

--
2.40.1