transition sockmap testing to test_progs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 10 repliesIn review
- v14 patches 3 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | bpf: sockmap, add test for sk_msg prog pop msg helpertools/ tools/ tools/ | +272 | 2 replies | |
| 2/4 | bpf: sockmap, add a sendmsg test so we can check that pathtools/ tools/ | +61 | 3 replies | |
| 3/4 | bpf: sockmap, add a cork to force buffering of the scatterlisttools/ tools/ | +84 | 2 replies | |
| 4/4 | bpf: sockmap test cork and pop combinedtools/ tools/ | +27 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH bpf-next v2 0/4] transition sockmap testing to test_progs
Its much easier to write and read tests than it was when sockmap was originally created. At that time we created a test_sockmap prog that did sockmap tests. But, its showing its age now. For example it reads user vars out of maps, is hard to run targetted tests, has a different format from the familiar test_progs and so on.
I recently thought there was an issue with pop helpers so I created some tests to try and track it down. It turns out it was a bug in the BPF program we had not the kernel. But, I think it makes sense to start deprecating test_sockmap and converting these to the nicer test_progs.
So this is a first round of test_prog tests for sockmap cork and pop helpers. I'll add push and pull tests shortly. I think its fine, maybe preferred to review smaller patchsets, to send these incrementally as I get them created.
Thanks!
v2: fix unint vars in some branches from make RELEASE=1
John Fastabend (4):
bpf: sockmap, add test for sk_msg prog pop msg helper
bpf: sockmap, add a sendmsg test so we can check that path
bpf: sockmap, add a cork to force buffering of the scatterlist
bpf: sockmap test cork and pop combined
.../bpf/prog_tests/sockmap_helpers.h | 18 + .../bpf/prog_tests/sockmap_msg_helpers.c | 353 ++++++++++++++++++ .../bpf/progs/test_sockmap_msg_helpers.c | 67 ++++ 3 files changed, 438 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/sockmap_msg_helpers.c create mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_msg_helpers.c
Signature · 1 line
2.33.0