Skip to content

firmware: ti_sci: zero the secure_hdr in do_xfer

Dhruva Gole u-boot 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 2 repliesIn review
  2. v42 patches 2 repliesSuperseded
  3. v31 patch 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v21 patch0 repliesSuperseded
v11 patch9 repliesSuperseded

Changes in v5 from the cover letter

Pick Nishanth's review and also s/sizeof(var)/sizeof(*var) in 1/2

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2firmware: ti_sci: fix the secure_hdr in do_xferdrivers/firmware/ti_sci.c+6 -61 reply
2/2firmware: ti_sci: Add comment explaining the is_secure codedrivers/firmware/ti_sci.c+6 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNishanth Menon
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH V5 0/2] firmware: ti_sci: zero the secure_hdr in do_xfer

This series adds a fix to make the initial 4 bytes of the secure_hdr to be 0 as per the protocol requirement as of now. Also, inorder to provide a little more context to people add a comment to explain why secure calls are made from uboot

For context, please refer to the discussion from the first patch here:
https://lore.kernel.org/all/[email protected]/

Boot tested for sanity on AM62x SK and J721S2:
https://gist.github.com/DhruvaG2000/9ca35d1261e8b30f1c2d4a514b9cd941

Changelog:

v4 --> v5
Pick Nishanth's review and also s/sizeof(var)/sizeof(*var) in 1/2

v3 --> v4
Improve commit message in 1/2 and add comment in 2/2

v2 --> v3
Address Kamlesh's comment on v2: use sizeof(struct ti_sci_secure_msg_hdr)

v1 --> v2
Rebased on top of latest master branch

Cc Nishanth Menon <[email protected]>
Cc Tom Rini <[email protected]>
Cc Neha Francis <[email protected]>
Cc Manorit Chawdhry <[email protected]>
Cc Vignesh Raghavendra <[email protected]>
Cc Kamlesh Gurudasani <[email protected]>
Cc Andrew Davis <[email protected]>

Dhruva Gole (2):
firmware: ti_sci: fix the secure_hdr in do_xfer
firmware: ti_sci: Add comment explaining the is_secure code

 drivers/firmware/ti_sci.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

base-commit: d5c0c990c3128401810514c66b41b386096d206e
prerequisite-patch-id: 2ed0c527b6ebf850744d9ff0eca0300a125f7796

Signature · 1 line
2.34.1