Skip to content

timers/nohz cleanups and hotplug reorganization

Frederic Weisbecker lkml 3 versions – Applied

Status from this message: The following commit has been merged into the timers/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 2 repliesApplied
  2. v215 patches 3 repliesSuperseded
  3. v115 patches 20 repliesSuperseded

Changes since v3 from the cover letter

* Rebase against latest tip:timers/core (after tmigr introduction)
* New patch "timers: Assert no next dyntick timer look-up while CPU"

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/16tick/nohz: Remove duplicate between tick_nohz_switch_to_nohz() and tick_setup_sched_timer()kernel/time/hrtimer.c kernel/time/tick-sched.c kernel/time/tick-sched.h+20 -231 reply
2/16tick/nohz: Remove duplicate between lowres and highres handlerskernel/time/tick-sched.c+36 -601 reply
3/16tick: Remove useless oneshot ifdefferykernel/time/tick-sched.c+1 -50 replies
4/16tick: Use IS_ENABLED() whenever possiblekernel/time/tick-common.c kernel/time/tick-sched.c+6 -120 replies
5/16tick: s/tick_nohz_stop_sched_tick/tick_nohz_full_stop_tickkernel/time/tick-sched.c+2 -20 replies
6/16tick: No need to clear ts->next_tick againkernel/time/tick-sched.c+0 -50 replies
7/16tick: Start centralizing tick related CPU hotplug operationsinclude/linux/cpuhotplug.h include/linux/tick.h kernel/cpu.c +1 more+23 -110 replies
8/16tick: Move tick cancellation up to CPUHP_AP_TICK_DYINGkernel/time/hrtimer.c kernel/time/tick-common.c+2 -20 replies
9/16tick: Move broadcast cancellation up to CPUHP_AP_TICK_DYINGinclude/linux/tick.h kernel/cpu.c kernel/time/tick-common.c +1 more+5 -80 replies
10/16tick: Assume the tick can't be stopped in NOHZ_MODE_INACTIVE modekernel/time/tick-sched.c+1 -10 replies
11/16tick: Move got_idle_tick away from common flagskernel/time/tick-sched.h+1 -10 replies
12/16tick: Move individual bit features to debuggable mask accesseskernel/time/tick-sched.c kernel/time/tick-sched.h kernel/time/timer_list.c+73 -430 replies
13/16tick: Split nohz and highres features from nohz_modekernel/time/hrtimer.c kernel/time/tick-sched.c kernel/time/tick-sched.h +1 more+26 -260 replies
14/16tick: Shut down low-res tick from dying CPUkernel/time/tick-common.c kernel/time/tick-sched.c kernel/time/tick-sched.h+29 -100 replies
15/16tick: Assume timekeeping is correctly handed over upon last offline idle callinclude/linux/tick.h kernel/cpu.c kernel/sched/idle.c +2 more+8 -130 replies
16/16timers: Assert no next dyntick timer look-up while CPU is offlinekernel/time/timer.c+3 -30 replies

Reviews trailers per patch

15 of 16 patches have a Reviewed-by or Acked-by.

PatchThomas Gleixner
1/16R-b
2/16R-b
3/16R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16R-b
14/16R-b
15/16R-b
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH 00/16 v3] timers/nohz cleanups and hotplug reorganization

Hi,

Here are some cleanups here and there and also some more rational tick related CPU hotplug code reorganization.

Changes since v3:

* Rebase against latest tip:timers/core (after tmigr introduction)
* New patch "timers: Assert no next dyntick timer look-up while CPU"

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
timers/hotplug-v3

HEAD: a0d432ebab0b7f75e03049d5d2baabff7f39ee1d

Frederic Weisbecker (14):
tick: Remove useless oneshot ifdeffery
tick: Use IS_ENABLED() whenever possible
tick: s/tick_nohz_stop_sched_tick/tick_nohz_full_stop_tick
tick: No need to clear ts->next_tick again
tick: Start centralizing tick related CPU hotplug operations
tick: Move tick cancellation up to CPUHP_AP_TICK_DYING
tick: Move broadcast cancellation up to CPUHP_AP_TICK_DYING
tick: Assume the tick can't be stopped in NOHZ_MODE_INACTIVE mode
tick: Move got_idle_tick away from common flags
tick: Move individual bit features to debuggable mask accesses
tick: Split nohz and highres features from nohz_mode
tick: Shut down low-res tick from dying CPU
tick: Assume timekeeping is correctly handed over upon last offline
idle call
timers: Assert no next dyntick timer look-up while CPU is offline

Peng Liu (2):
tick/nohz: Remove duplicate between tick_nohz_switch_to_nohz() and
tick_setup_sched_timer()
tick/nohz: Remove duplicate between lowres and highres handlers

 include/linux/cpuhotplug.h  |   1 +
 include/linux/tick.h        |  16 +-
 kernel/cpu.c                |  11 +-
 kernel/sched/idle.c         |   1 -
 kernel/time/hrtimer.c       |   4 +-
 kernel/time/tick-common.c   |  31 ++--
 kernel/time/tick-internal.h |   2 +
 kernel/time/tick-sched.c    | 297 +++++++++++++++++-------------------
 kernel/time/tick-sched.h    |  40 ++---
 kernel/time/timer.c         |   6 +-
 kernel/time/timer_list.c    |  10 +-
 11 files changed, 215 insertions(+), 204 deletions(-)
Signature · 1 line
2.43.0