Skip to content

nvme: enable retries for authentication commands

[email protected] linux-nvme 4 versions – Applied

Status from this message: Thanks, applied to nvme-6.8.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 6 repliesApplied
  2. v33 patches 8 repliesApplied
  3. v21 patch 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch6 repliesSuperseded

Changes to v3 from the cover letter

- Modify patch description as suggested by Christoph

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3nvme-auth: open-code single-use macrosdrivers/nvme/host/auth.c+7 -71 reply
2/3nvme: simplify __nvme_submit_sync_cmd() calling conventionsdrivers/nvme/host/auth.c drivers/nvme/host/core.c drivers/nvme/host/fabrics.c +1 more+41 -201 reply
2/3nvme: change __nvme_submit_sync_cmd() calling conventionsdrivers/nvme/host/auth.c drivers/nvme/host/core.c drivers/nvme/host/fabrics.c +1 more+41 -201 reply
3/3nvme: enable retries for authentication commandsdrivers/nvme/host/auth.c drivers/nvme/host/core.c drivers/nvme/host/nvme.h+5 -12 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigSagi Grimberg
1/3R-b R-b
2/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCHv4 0/3] nvme: enable retries for authentication commands

From: Hannes Reinecke <[email protected]>

Hi all,

authentitication commands are normal NVMe commands, and should be retried if returned with a status where the DNR bit is not set. But instead of having the caller retry the commaand this patchset enables the function __nvme_submit_sync_cmd() to not set the FASTFAIL flag in the request, thereby making the functionality generally available.

As usual, comments and reviews are welcome.

Changes to v3:
- Modify patch description as suggested by Christoph

Hannes Reinecke (3):
nvme-auth: open-code single-use macros
nvme: change __nvme_submit_sync_cmd() calling conventions
nvme: enable retries for authentication commands

 drivers/nvme/host/auth.c    | 17 ++++++++---------
 drivers/nvme/host/core.c    | 21 ++++++++++++++-------
 drivers/nvme/host/fabrics.c | 18 +++++++++++-------
 drivers/nvme/host/nvme.h    | 19 +++++++++++++++++--
 4 files changed, 50 insertions(+), 25 deletions(-)
Signature · 1 line
2.35.3