replay: minor fixes and tests
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest4 patches 4 repliesIn review
Changes in v2 from the cover letter
- Rebase onto script that now has initial v12 support.
- avocado tests now also cover replay_kernel.py because replay_linux.py is very heavyweight and flaky. replay_kernel is feasible to run in CI and general hacking.
- Rearrange replay-dump.py decoders.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | replay: allow runstate shutdown->running when replaying traceinclude/ replay/ system/ | +22 | 1 reply | |
| 2/4 | scripts/replay-dump.py: Update to current rr record formatscripts/ | +98 | 2 replies | |
| 3/4 | scripts/replay-dump.py: rejig decoders in event number orderscripts/ | +28 | 0 replies | |
| 4/4 | tests/avocado: excercise scripts/replay-dump.py in replay testsscripts/ tests/ tests/ | +36 | 1 reply |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Pavel Dovgalyuk |
|---|---|
| 1/4 | R-b |
| 2/4 | |
| 3/4 | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/4] replay: minor fixes and tests
replay-dump.py script still chokes quite easily on a trace of Linux boot, so I revived some patches from last year that fix the script and add some test cases for it.
The runstate patch doesn't have a test case (yet), but you can hit the problem by replaying to the machine shutdown and then reverse-stepping.
Thanks,
Nick
Since v1:
- Rebase onto script that now has initial v12 support.
- avocado tests now also cover replay_kernel.py because replay_linux.py is very heavyweight and flaky. replay_kernel is feasible to run in CI and general hacking.
- Rearrange replay-dump.py decoders.
Nicholas Piggin (4):
replay: allow runstate shutdown->running when replaying trace scripts/replay-dump.py: Update to current rr record format scripts/replay-dump.py: rejig decoders in event number order tests/avocado: excercise scripts/replay-dump.py in replay tests
include/sysemu/runstate.h | 1 + replay/replay.c | 2 + system/runstate.c | 19 ++++ scripts/replay-dump.py | 172 +++++++++++++++++++++++---------- tests/avocado/replay_kernel.py | 16 +++ tests/avocado/replay_linux.py | 16 +++ 6 files changed, 173 insertions(+), 53 deletions(-)
Signature · 1 line
2.42.0