Skip to content

migration/multifd: Prerequisite cleanups for ongoing work

Fabiano Rosas qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5migration/multifd: Separate compression ops from non-compressionmigration/multifd-zlib.c migration/multifd-zstd.c migration/multifd.c +1 more+34 -827 replies
2/5migration/multifd: Move multifd_socket_ops to socket.cmigration/multifd.c migration/multifd.h migration/socket.c+62 -600 replies
3/5migration/multifd: Add multifd_ops->sendmigration/multifd-zlib.c migration/multifd-zstd.c migration/multifd.c +2 more+45 -160 replies
4/5migration/multifd: Simplify zero copy sendmigration/multifd-zlib.c migration/multifd-zstd.c migration/multifd.c +1 more+16 -200 replies
5/5migration/multifd: Move zero copy flag into multifd_socket_setupmigration/multifd.c migration/socket.c+5 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] migration/multifd: Prerequisite cleanups for ongoing work

Hi,

Here are two cleanups that are prerequiste for the fixed-ram work, but also affect the other series on the list at the moment, so I want to make sure it works for everyone:

1) Separate multifd_ops from compression. The multifd_ops are currently coupled with the multifd_compression parameter.

We're adding new multifd_ops in the fixed-ram work and adding new compression ops in the compression work.

2) Add a new send hook. The multifd_send_thread code currently does some twists to support zero copy, which is a socket-only feature.

This might affect the zero page and DSA work which add code to multifd_send_thread.

CI run: https://gitlab.com/farosas/qemu/-/pipelines/1154332360

(I also tested zero copy locally. We cannot add a test for it because it needs root due to memory locking limits)

Fabiano Rosas (5):
migration/multifd: Separate compression ops from non-compression migration/multifd: Move multifd_socket_ops to socket.c migration/multifd: Add multifd_ops->send migration/multifd: Simplify zero copy send migration/multifd: Move zero copy flag into multifd_socket_setup

 migration/multifd-zlib.c |   9 ++-
 migration/multifd-zstd.c |   9 ++-
 migration/multifd.c      | 164 +++++----------------------------------
 migration/multifd.h      |   6 +-
 migration/socket.c       |  90 ++++++++++++++++++++-
 5 files changed, 128 insertions(+), 150 deletions(-)
Signature · 1 line
2.35.3