Skip to content

lockdep cmp fn conversions

Kent Overstreet linux-block linux-fsdevel lkml netdev oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fs/pipe: Convert to lockdep_cmp_fnfs/pipe.c+36 -456 replies
2/4pktcdvd: kill mutex_lock_nested() usagedrivers/block/pktcdvd.c fs/pipe.c include/linux/lockdep.h +1 more+14 -130 replies
3/4net: Convert sk->sk_peer_lock to lock_set_cmp_fn_ptr_order()net/core/sock.c net/unix/af_unix.c+3 -21 reply
4/4af_unix: convert to lock_cmp_fninclude/net/af_unix.h net/unix/af_unix.c net/unix/diag.c+9 -164 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchJan Kara
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] lockdep cmp fn conversions

rationale:
*_lock_nested() is fundamentally broken - in order for lockdep to work we need to be able to check that we're following some defined ordering, and it's not possible to define a total ordering of an arbitrary number of objects with only a small fixed size enum.

so it needs to go. awhile back I added the ability to set a comparison function for a lock class, and this is the start of hopefully a slow steady trickle of patches as time allows to convert code to use it.

Kent Overstreet (4):
fs/pipe: Convert to lockdep_cmp_fn
pktcdvd: kill mutex_lock_nested() usage
net: Convert sk->sk_peer_lock to lock_set_cmp_fn_ptr_order()
af_unix: convert to lock_cmp_fn

 drivers/block/pktcdvd.c  |  8 ++---
 fs/pipe.c                | 77 ++++++++++++++++------------------------
 include/linux/lockdep.h  |  3 ++
 include/net/af_unix.h    |  3 --
 kernel/locking/lockdep.c |  6 ++++
 net/core/sock.c          |  1 +
 net/unix/af_unix.c       | 24 ++++++-------
 net/unix/diag.c          |  2 +-
 8 files changed, 55 insertions(+), 69 deletions(-)
Signature · 1 line
2.43.0