Skip to content

MIPS: fix the "CPU type" choice structure

Masahiro Yamada linux-kbuild linux-mips lkml 1 version Applied

Status from this message: applied to mips-next.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/1MIPS: move unselectable entries out of the "CPU type" choicearch/mips/Kconfig+38 -382 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchJiaxun Yang
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/1] MIPS: fix the "CPU type" choice structure

The bool type "choice" is meant to list exclusively selected config options.

Unless you are familiar with the Kconfig internals, you will not understand how CONFIG_B can be enabled in the following code:

choice
prompt "Choose one of them, but how to choose B?"

config A
bool "A"

config B
bool "B"
depends on A

config C
bool "C"

endchoice

B is not a choice value because it becomes a child of A, as a side-effect of re-paranting in menu_finalize().
It is unreadable, and I even consider it as a bug.
My plan is to forbid such a silly choice structure.

Just write as follows:

choice
prompt "Choose one of them"

config A
bool "A"

config C
bool "C"

endchoice

config B
bool "B"
depends on A

Fortunately, arch/mips/Kconfig seems to be the only file I need to fix.

Masahiro Yamada (1):
MIPS: move unselectable entries out of the "CPU type" choice

 arch/mips/Kconfig | 76 +++++++++++++++++++++++------------------------
 1 file changed, 38 insertions(+), 38 deletions(-)
Signature · 1 line
2.40.1