Skip to content

Always build aspm.c

David E. Box linux-pci lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5PCI: Always build aspm.cdrivers/pci/pci.c drivers/pci/pci.h drivers/pci/pcie/Makefile +2 more+83 -810 replies
2/5PCI: Create function to save L1SS offsetdrivers/pci/pci.h drivers/pci/pcie/aspm.c drivers/pci/probe.c +1 more+10 -50 replies
3/5PCI/ASPM: Add back L1 PM Substate save and restoredrivers/pci/pci.c drivers/pci/pci.h drivers/pci/pcie/aspm.c+144 -130 replies
4/5PCI: Move pci_save/restore_ltr_state() to aspm.cdrivers/pci/pci.c drivers/pci/pci.h drivers/pci/pcie/aspm.c+42 -400 replies
5/5PCI: Save and restore LTR state from pci_save/restore_pcie_state()drivers/pci/pci.c+7 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Always build aspm.c

Here is the series to always build aspm.c, add back L1SS save/restore, and consolidate all ASPM related code in aspm.c.

Patch 1 - Moves all PCI core functions running under CONFIG_PCIEASPM into aspm.c and changes they Makefile to always build it. No functional changes.

Patch 2 - Creates a separate function to save the L1SS offset and places it outside of CONFIG_PCIEASPM in aspm.c so that the offset is available for later use by the L1SS save/restore code which needs to run when CONFIG_PCIEASPM=n.

Patch 3 - Updated L1 Substate save/restore patch from previous V5 [1].

Patch 4 - Moves the LTR save/restore state functions into aspm.c outside of CONFIG_PCIEASPM.

Patch 5 - Moves the LTR save/restore state calls into pci_save/restore_pcie_state().

The series does not continue any of the ASPM robustness changes proposed by Ilpo [2]. But if we think it's worth combining with this series I can add it and help continue the work.

[1] https://lore.kernel.org/linux-pci/[email protected]/
[2] https://lore.kernel.org/linux-pci/[email protected]/

David E. Box (5):
PCI: Always build aspm.c
PCI: Create function to save L1SS offset PCI/ASPM: Add back L1 PM Substate save and restore
PCI: Move pci_save/restore_ltr_state() to aspm.c
PCI: Call LTR save/restore state from PCIe save/restore

 drivers/pci/pci.c         |  91 ++++----------
 drivers/pci/pci.h         |  10 +-
 drivers/pci/pcie/Makefile |   2 +-
 drivers/pci/pcie/aspm.c   | 257 ++++++++++++++++++++++++++++++++++++--
 drivers/pci/probe.c       |  62 +--------
 include/linux/pci.h       |   4 +-
 6 files changed, 283 insertions(+), 143 deletions(-)

base-commit: 0dd3ee31125508cd67f7e7172247f05b7fd1753a

Signature · 1 line
2.34.1