hw/pci: SR-IOV related fixes and improvements
Get series with b4
b4 am [email protected] change-id 20240129-reuse-faae22b11934Versions newest first
- v20 Latest11 patches 3 repliesIn review
- v1914 patches 4 repliesSuperseded
- v1814 patches 3 repliesSuperseded
Earlier versions · 17
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v17 | 14 patches | 3 replies | Superseded | |
| v16 | 13 patches | 14 replies | Superseded | |
| v15 | 11 patches | 18 replies | Superseded | |
| v14 | 11 patches | 1 reply | Superseded | |
| v13 | 12 patches | 0 replies | Superseded | |
| v12 | 11 patches | 3 replies | Superseded | |
| v11 | 11 patches | 8 replies | Superseded | |
| v10 | 12 patches | 10 replies | Superseded | |
| v9 | 11 patches | 1 reply | Superseded | |
| v8 | 15 patches | 9 replies | Applied | |
| v7 | 16 patches | 3 replies | Superseded | |
| v6 | 15 patches | 13 replies | Superseded | |
| v5 | 11 patches | 4 replies | Superseded | |
| v4 | 9 patches | 24 replies | Superseded | |
| v3 | 7 patches | 9 replies | Superseded | |
| v2 | 6 patches | 5 replies | Superseded | |
| v1 | 6 patches | 0 replies | Superseded |
Changes in v20 from the cover letter
- Use qdev_is_realized().
- Link to v19: https://lore.kernel.org/r/[email protected]
Patches in v20 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | hw/ppc/spapr_pci: Do not create DT for disabled PCI devicehw/ | +14 | 0 replies | |
| 2/11 | hw/ppc/spapr_pci: Do not reject VFs created after a PFhw/ | +3 | 0 replies | |
| 3/11 | s390x/pci: Avoid creating zpci for VFshw/ | +19 | 0 replies | |
| 4/11 | s390x/pci: Allow plugging SR-IOV deviceshw/ | +8 | 0 replies | |
| 5/11 | s390x/pci: Check for multifunction after device realizationhw/ | +13 | 0 replies | |
| 6/11 | pcie_sriov: Do not manually unrealizehw/ | +0 | 1 reply | |
| 7/11 | pcie_sriov: Ensure VF addr does not overflowdocs/ hw/ hw/ +2 more | +41 | 0 replies | |
| 8/11 | pcie_sriov: Reuse SR-IOV VF device instanceshw/ hw/ include/ | +51 | 0 replies | |
| 9/11 | pcie_sriov: Release VFs failed to realizehw/ | +2 | 0 replies | |
| 10/11 | pcie_sriov: Remove num_vfs from PCIESriovPFhw/ hw/ include/ | +28 | 0 replies | |
| 11/11 | pcie_sriov: Register VFs after migrationhw/ hw/ include/ | +16 | 0 replies |
Reviews trailers per patch
3 of 11 patches have a Reviewed-by or Acked-by.
| Patch | Shivaprasad G Bhat | Philippe Mathieu-Daudé |
|---|---|---|
| 1/11 | R-b T-b | |
| 2/11 | R-b T-b | |
| 3/11 | ||
| 4/11 | ||
| 5/11 | ||
| 6/11 | R-b | |
| 7/11 | ||
| 8/11 | ||
| 9/11 | ||
| 10/11 | ||
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v20 00/11] hw/pci: SR-IOV related fixes and improvements
Supersedes: <[email protected]> ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto")
I submitted a RFC series[1] to add support for SR-IOV emulation to virtio-net-pci. During the development of the series, I fixed some trivial bugs and made improvements that I think are independently useful. This series extracts those fixes and improvements from the RFC series.
[1]: https://patchew.org/QEMU/[email protected]/
---
Changes in v20:
- Use qdev_is_realized().
- Link to v19: https://lore.kernel.org/r/[email protected]
Changes in v19:
- Avoided inling pci_set_power().
- Link to v18: https://lore.kernel.org/r/[email protected]
Changes in v18:
- Rebased.
- Link to v17: https://lore.kernel.org/r/[email protected]
Changes in v17:
- Added patch "pcie_sriov: Ensure VF addr does not overflow".
- Changed not to link VF with sPAPR DRC.
- Asserted pci_is_vf() when zpci is not found. (Cédric Le Goater)
- Link to v16: https://lore.kernel.org/r/[email protected]
Changes in v16:
- Added patch "s390x/pci: Avoid creating zpci for VFs".
- Added patch "s390x/pci: Allow plugging SR-IOV devices".
- Link to v15: https://lore.kernel.org/r/[email protected]
Changes in v15:
- Fixed variable shadowing in patch
"pcie_sriov: Remove num_vfs from PCIESriovPF"
- Link to v14: https://lore.kernel.org/r/[email protected]
Changes in v14:
- Dropped patch "pcie_sriov: Ensure VF function number does not overflow" as I found the restriction it imposes is unnecessary.
- Link to v13: https://lore.kernel.org/r/[email protected]
Changes in v13:
- Added patch "s390x/pci: Check for multifunction after device realization". I found SR-IOV devices, which are multifunction devices, are not supposed to work at all with s390x on QEMU.
- Link to v12: https://lore.kernel.org/r/[email protected]
Changes in v12:
- Changed to ignore invalid PCI_SRIOV_NUM_VF writes as done for PCI_SRIOV_CTRL_VFE.
- Updated the message for patch "hw/pci: Use -1 as the default value for rombar". (Markus Armbruster)
- Link to v11: https://lore.kernel.org/r/[email protected]
Changes in v11:
- Rebased.
- Dropped patch "hw/pci: Convert rom_bar into OnOffAuto".
- Added patch "hw/pci: Use -1 as the default value for rombar".
- Added for-9.2 to give a testing period for possible breakage with libvirt/s390x.
- Link to v10: https://lore.kernel.org/r/[email protected]
Changes in v10:
- Added patch "hw/ppc/spapr_pci: Do not reject VFs created after a PF".
- Added patch "hw/ppc/spapr_pci: Do not create DT for disabled PCI device".
- Added patch "hw/pci: Convert rom_bar into OnOffAuto".
- Dropped patch "hw/pci: Determine if rombar is explicitly enabled".
- Dropped patch "hw/qdev: Remove opts member".
- Link to v9: https://lore.kernel.org/r/[email protected]
Changes in v9:
- Rebased.
- Restored '#include "qapi/error.h"' (Michael S. Tsirkin)
- Added patch "pcie_sriov: Ensure VF function number does not overflow" to fix abortion with wrong PF addr.
- Link to v8: https://lore.kernel.org/r/[email protected]
Changes in v8:
- Clarified that "hw/pci: Replace -1 with UINT32_MAX for romsize" is not a bug fix. (Markus Armbruster)
- Squashed patch "vfio: Avoid inspecting option QDict for rombar" into "hw/pci: Determine if rombar is explicitly enabled".
(Markus Armbruster)
- Noted the minor semantics change for patch "hw/pci: Determine if rombar is explicitly enabled". (Markus Armbruster)
- Link to v7: https://lore.kernel.org/r/[email protected]
Changes in v7:
- Replaced -1 with UINT32_MAX when expressing uint32_t.
(Markus Armbruster)
- Added patch "hw/pci: Replace -1 with UINT32_MAX for romsize".
- Link to v6: https://lore.kernel.org/r/[email protected]
Changes in v6:
- Fixed migration.
- Added patch "pcie_sriov: Do not manually unrealize".
- Restored patch "pcie_sriov: Release VFs failed to realize" that was missed in v5.
- Link to v5: https://lore.kernel.org/r/[email protected]
Changes in v5:
- Added patch "hw/pci: Always call pcie_sriov_pf_reset()".
- Added patch "pcie_sriov: Reset SR-IOV extended capability".
- Removed a reference to PCI_SRIOV_CTRL_VFE in hw/nvme.
(Michael S. Tsirkin)
- Noted the impact on the guest of patch "pcie_sriov: Do not reset NumVFs after unregistering VFs". (Michael S. Tsirkin)
- Changed to use pcie_sriov_num_vfs().
- Restored pci_set_power() and changed it to call pci_set_enabled() only for PFs with an expalanation. (Michael S. Tsirkin)
- Reordered patches.
- Link to v4: https://lore.kernel.org/r/[email protected]
Changes in v4:
- Reverted the change to pci_rom_bar_explicitly_enabled().
(Michael S. Tsirkin)
- Added patch "pcie_sriov: Do not reset NumVFs after unregistering VFs".
- Added patch "hw/nvme: Refer to dev->exp.sriov_pf.num_vfs".
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- Extracted patch "hw/pci: Use -1 as a default value for rombar" from patch "hw/pci: Determine if rombar is explicitly enabled"
(Philippe Mathieu-Daudé)
- Added an audit result of PCIDevice::rom_bar to the message of patch "hw/pci: Use -1 as a default value for rombar"
(Philippe Mathieu-Daudé)
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Reset after enabling a function so that NVMe VF state gets updated.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Akihiko Odaki (11):
hw/ppc/spapr_pci: Do not create DT for disabled PCI device hw/ppc/spapr_pci: Do not reject VFs created after a PF s390x/pci: Avoid creating zpci for VFs
s390x/pci: Allow plugging SR-IOV devices s390x/pci: Check for multifunction after device realization
pcie_sriov: Do not manually unrealize
pcie_sriov: Ensure VF addr does not overflow
pcie_sriov: Reuse SR-IOV VF device instances
pcie_sriov: Release VFs failed to realize
pcie_sriov: Remove num_vfs from PCIESriovPF
pcie_sriov: Register VFs after migration
docs/pcie_sriov.txt | 8 ++- include/hw/pci/pcie_sriov.h | 9 +-- hw/net/igb.c | 10 ++- hw/nvme/ctrl.c | 22 +++--- hw/pci/pci.c | 21 +++++- hw/pci/pcie_sriov.c | 159 ++++++++++++++++++++++++-------------------- hw/ppc/spapr_pci.c | 20 +++++- hw/s390x/s390-pci-bus.c | 42 +++++++++--- hw/pci/trace-events | 2 +- 9 files changed, 187 insertions(+), 106 deletions(-)
---
base-commit: 7433709a147706ad7d1956b15669279933d0f82b
change-id: 20240129-reuse-faae22b11934
Best regards,
Signature · 1 line
Akihiko Odaki <[email protected]>