Skip to content

hw/pci: SR-IOV related fixes and improvements

Akihiko Odaki qemu-devel 20 versions – In review

Get series with b4
b4 am [email protected] change-id 20240129-reuse-faae22b11934

Versions newest first

  1. v20 Latest11 patches 3 repliesIn review
  2. v1914 patches 4 repliesSuperseded
  3. v1814 patches 3 repliesSuperseded
Earlier versions · 17
VersionPostedPatchesRepliesStatus
v1714 patches3 repliesSuperseded
v1613 patches14 repliesSuperseded
v1511 patches18 repliesSuperseded
v1411 patches1 replySuperseded
v1312 patches0 repliesSuperseded
v1211 patches3 repliesSuperseded
v1111 patches8 repliesSuperseded
v1012 patches10 repliesSuperseded
v911 patches1 replySuperseded
v815 patches9 repliesApplied
v716 patches3 repliesSuperseded
v615 patches13 repliesSuperseded
v511 patches4 repliesSuperseded
v49 patches24 repliesSuperseded
v37 patches9 repliesSuperseded
v26 patches5 repliesSuperseded
v16 patches0 repliesSuperseded

Changes in v20 from the cover letter

- Use qdev_is_realized().
- Link to v19: https://lore.kernel.org/r/[email protected]

Patches in v20 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11hw/ppc/spapr_pci: Do not create DT for disabled PCI devicehw/ppc/spapr_pci.c+14 -20 replies
2/11hw/ppc/spapr_pci: Do not reject VFs created after a PFhw/ppc/spapr_pci.c+3 -10 replies
3/11s390x/pci: Avoid creating zpci for VFshw/s390x/s390-pci-bus.c+19 -20 replies
4/11s390x/pci: Allow plugging SR-IOV deviceshw/s390x/s390-pci-bus.c+8 -10 replies
5/11s390x/pci: Check for multifunction after device realizationhw/s390x/s390-pci-bus.c+13 -150 replies
6/11pcie_sriov: Do not manually unrealizehw/pci/pcie_sriov.c+0 -41 reply
7/11pcie_sriov: Ensure VF addr does not overflowdocs/pcie_sriov.txt hw/net/igb.c hw/nvme/ctrl.c +2 more+41 -180 replies
8/11pcie_sriov: Reuse SR-IOV VF device instanceshw/pci/pci.c hw/pci/pcie_sriov.c include/hw/pci/pcie_sriov.h+51 -580 replies
9/11pcie_sriov: Release VFs failed to realizehw/pci/pcie_sriov.c+2 -00 replies
10/11pcie_sriov: Remove num_vfs from PCIESriovPFhw/pci/pcie_sriov.c hw/pci/trace-events include/hw/pci/pcie_sriov.h+28 -130 replies
11/11pcie_sriov: Register VFs after migrationhw/pci/pci.c hw/pci/pcie_sriov.c include/hw/pci/pcie_sriov.h+16 -00 replies

Reviews trailers per patch

3 of 11 patches have a Reviewed-by or Acked-by.

PatchShivaprasad G BhatPhilippe Mathieu-Daudé
1/11R-b T-b
2/11R-b T-b
3/11
4/11
5/11
6/11R-b
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v20 thread

Cover letter [PATCH v20 00/11] hw/pci: SR-IOV related fixes and improvements

Supersedes: <[email protected]> ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto")

I submitted a RFC series[1] to add support for SR-IOV emulation to virtio-net-pci. During the development of the series, I fixed some trivial bugs and made improvements that I think are independently useful. This series extracts those fixes and improvements from the RFC series.

[1]: https://patchew.org/QEMU/[email protected]/

---
Changes in v20:
- Use qdev_is_realized().
- Link to v19: https://lore.kernel.org/r/[email protected]

Changes in v19:
- Avoided inling pci_set_power().
- Link to v18: https://lore.kernel.org/r/[email protected]

Changes in v18:
- Rebased.
- Link to v17: https://lore.kernel.org/r/[email protected]

Changes in v17:
- Added patch "pcie_sriov: Ensure VF addr does not overflow".
- Changed not to link VF with sPAPR DRC.
- Asserted pci_is_vf() when zpci is not found. (Cédric Le Goater)
- Link to v16: https://lore.kernel.org/r/[email protected]

Changes in v16:
- Added patch "s390x/pci: Avoid creating zpci for VFs".
- Added patch "s390x/pci: Allow plugging SR-IOV devices".
- Link to v15: https://lore.kernel.org/r/[email protected]

Changes in v15:
- Fixed variable shadowing in patch
"pcie_sriov: Remove num_vfs from PCIESriovPF"
- Link to v14: https://lore.kernel.org/r/[email protected]

Changes in v14:
- Dropped patch "pcie_sriov: Ensure VF function number does not overflow" as I found the restriction it imposes is unnecessary.
- Link to v13: https://lore.kernel.org/r/[email protected]

Changes in v13:
- Added patch "s390x/pci: Check for multifunction after device realization". I found SR-IOV devices, which are multifunction devices, are not supposed to work at all with s390x on QEMU.
- Link to v12: https://lore.kernel.org/r/[email protected]

Changes in v12:
- Changed to ignore invalid PCI_SRIOV_NUM_VF writes as done for PCI_SRIOV_CTRL_VFE.
- Updated the message for patch "hw/pci: Use -1 as the default value for rombar". (Markus Armbruster)
- Link to v11: https://lore.kernel.org/r/[email protected]

Changes in v11:
- Rebased.
- Dropped patch "hw/pci: Convert rom_bar into OnOffAuto".
- Added patch "hw/pci: Use -1 as the default value for rombar".
- Added for-9.2 to give a testing period for possible breakage with libvirt/s390x.
- Link to v10: https://lore.kernel.org/r/[email protected]

Changes in v10:
- Added patch "hw/ppc/spapr_pci: Do not reject VFs created after a PF".
- Added patch "hw/ppc/spapr_pci: Do not create DT for disabled PCI device".
- Added patch "hw/pci: Convert rom_bar into OnOffAuto".
- Dropped patch "hw/pci: Determine if rombar is explicitly enabled".
- Dropped patch "hw/qdev: Remove opts member".
- Link to v9: https://lore.kernel.org/r/[email protected]

Changes in v9:
- Rebased.
- Restored '#include "qapi/error.h"' (Michael S. Tsirkin)
- Added patch "pcie_sriov: Ensure VF function number does not overflow" to fix abortion with wrong PF addr.
- Link to v8: https://lore.kernel.org/r/[email protected]

Changes in v8:
- Clarified that "hw/pci: Replace -1 with UINT32_MAX for romsize" is not a bug fix. (Markus Armbruster)
- Squashed patch "vfio: Avoid inspecting option QDict for rombar" into "hw/pci: Determine if rombar is explicitly enabled".
(Markus Armbruster)
- Noted the minor semantics change for patch "hw/pci: Determine if rombar is explicitly enabled". (Markus Armbruster)
- Link to v7: https://lore.kernel.org/r/[email protected]

Changes in v7:
- Replaced -1 with UINT32_MAX when expressing uint32_t.
(Markus Armbruster)
- Added patch "hw/pci: Replace -1 with UINT32_MAX for romsize".
- Link to v6: https://lore.kernel.org/r/[email protected]

Changes in v6:
- Fixed migration.
- Added patch "pcie_sriov: Do not manually unrealize".
- Restored patch "pcie_sriov: Release VFs failed to realize" that was missed in v5.
- Link to v5: https://lore.kernel.org/r/[email protected]

Changes in v5:
- Added patch "hw/pci: Always call pcie_sriov_pf_reset()".
- Added patch "pcie_sriov: Reset SR-IOV extended capability".
- Removed a reference to PCI_SRIOV_CTRL_VFE in hw/nvme.
(Michael S. Tsirkin)
- Noted the impact on the guest of patch "pcie_sriov: Do not reset NumVFs after unregistering VFs". (Michael S. Tsirkin)
- Changed to use pcie_sriov_num_vfs().
- Restored pci_set_power() and changed it to call pci_set_enabled() only for PFs with an expalanation. (Michael S. Tsirkin)
- Reordered patches.
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Reverted the change to pci_rom_bar_explicitly_enabled().
(Michael S. Tsirkin)
- Added patch "pcie_sriov: Do not reset NumVFs after unregistering VFs".
- Added patch "hw/nvme: Refer to dev->exp.sriov_pf.num_vfs".
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Extracted patch "hw/pci: Use -1 as a default value for rombar" from patch "hw/pci: Determine if rombar is explicitly enabled"
(Philippe Mathieu-Daudé)
- Added an audit result of PCIDevice::rom_bar to the message of patch "hw/pci: Use -1 as a default value for rombar"
(Philippe Mathieu-Daudé)
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Reset after enabling a function so that NVMe VF state gets updated.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Akihiko Odaki (11):
hw/ppc/spapr_pci: Do not create DT for disabled PCI device hw/ppc/spapr_pci: Do not reject VFs created after a PF s390x/pci: Avoid creating zpci for VFs
s390x/pci: Allow plugging SR-IOV devices s390x/pci: Check for multifunction after device realization
pcie_sriov: Do not manually unrealize
pcie_sriov: Ensure VF addr does not overflow
pcie_sriov: Reuse SR-IOV VF device instances
pcie_sriov: Release VFs failed to realize
pcie_sriov: Remove num_vfs from PCIESriovPF
pcie_sriov: Register VFs after migration

 docs/pcie_sriov.txt         |   8 ++-
 include/hw/pci/pcie_sriov.h |   9 +--
 hw/net/igb.c                |  10 ++-
 hw/nvme/ctrl.c              |  22 +++---
 hw/pci/pci.c                |  21 +++++-
 hw/pci/pcie_sriov.c         | 159 ++++++++++++++++++++++++--------------------
 hw/ppc/spapr_pci.c          |  20 +++++-
 hw/s390x/s390-pci-bus.c     |  42 +++++++++---
 hw/pci/trace-events         |   2 +-
 9 files changed, 187 insertions(+), 106 deletions(-)

---
base-commit: 7433709a147706ad7d1956b15669279933d0f82b
change-id: 20240129-reuse-faae22b11934

Best regards,

Signature · 1 line
Akihiko Odaki <[email protected]>