pds_core: Various fixes
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 6 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | pds_core: Prevent health thread from running during reset/removedrivers/ | +17 | 0 replies | Applied |
| 2/6 | pds_core: Cancel AQ work on teardowndrivers/ | +2 | 0 replies | Applied |
| 3/6 | pds_core: Use struct pdsc for the pdsc_adminq_isr private datadrivers/ drivers/ | +4 | 0 replies | Applied |
| 4/6 | pds_core: Prevent race issues involving the adminqdrivers/ drivers/ drivers/ | +47 | 0 replies | Applied |
| 5/6 | pds_core: Clear BARs on resetdrivers/ drivers/ drivers/ +3 more | +45 | 0 replies | Applied |
| 6/6 | pds_core: Rework teardown/setup flow to be more commondrivers/ drivers/ drivers/ +2 more | +9 | 0 replies | Applied |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Shannon Nelson | Przemek Kitszel |
|---|---|---|
| 1/6 | R-b | R-b |
| 2/6 | R-b | R-b |
| 3/6 | R-b | R-b |
| 4/6 | R-b | R-b |
| 5/6 | R-b | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net 0/6] pds_core: Various fixes
This series includes the following changes:
There can be many users of the pds_core's adminq. This includes pds_core's uses and any clients that depend on it. When the pds_core device goes through a reset for any reason the adminq is freed and reconfigured. There are some gaps in the current implementation that will cause crashes during reset if any of the previously mentioned users of the adminq attempt to use it after it's been freed.
Issues around how resets are handled, specifically regarding the driver's error handlers.
Originally these patches were aimed at net-next, but it was requested to push the fixes patches to net. The original patches can be found here:
https://lore.kernel.org/netdev/[email protected]/
Also, the Reviewed-by tags were left in place from net-next reviews as the patches didn't change.
Brett Creeley (6):
pds_core: Prevent health thread from running during reset/remove
pds_core: Cancel AQ work on teardown
pds_core: Use struct pdsc for the pdsc_adminq_isr private data
pds_core: Prevent race issues involving the adminq
pds_core: Clear BARs on reset
pds_core: Rework teardown/setup flow to be more common
drivers/net/ethernet/amd/pds_core/adminq.c | 64 +++++++++++++++------ drivers/net/ethernet/amd/pds_core/core.c | 46 +++++++++++---- drivers/net/ethernet/amd/pds_core/core.h | 2 +- drivers/net/ethernet/amd/pds_core/debugfs.c | 4 ++ drivers/net/ethernet/amd/pds_core/dev.c | 16 +++--- drivers/net/ethernet/amd/pds_core/devlink.c | 3 +- drivers/net/ethernet/amd/pds_core/fw.c | 3 + drivers/net/ethernet/amd/pds_core/main.c | 26 +++++++-- 8 files changed, 124 insertions(+), 40 deletions(-)
Signature · 1 line
2.17.1