Skip to content

RFC drm/format-helper: Introduce drm_pixmap, font support and filling

Thomas Zimmermann dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest23 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23drm/format-helper: Add struct drm_pixmapdrivers/gpu/drm/drm_format_helper.c include/drm/drm_format_helper.h+81 -40 replies
2/23drm/format-helper: Use struct drm_pixmap for drm_fb_memcpy()drivers/gpu/drm/ast/ast_mode.c drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/drm_mipi_dbi.c +5 more+42 -230 replies
3/23drm/format-helper: Streamline drm_fb_xfrm() implementationsdrivers/gpu/drm/drm_format_helper.c+33 -330 replies
4/23drm/format-helper: Use struct drm_pixmap internallydrivers/gpu/drm/drm_format_helper.c+57 -190 replies
5/23drm/format-helper: Use struct drm_pixmap for drm_fb_swab()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/drm_mipi_dbi.c drivers/gpu/drm/gud/gud_pipe.c +2 more+23 -220 replies
6/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_rgb332()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/gud/gud_pipe.c drivers/gpu/drm/solomon/ssd130x.c +2 more+13 -150 replies
7/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_rgb565()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/drm_mipi_dbi.c drivers/gpu/drm/gud/gud_pipe.c +2 more+15 -210 replies
8/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_xrgb1555()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/tests/drm_format_helper_test.c include/drm/drm_format_helper.h+12 -150 replies
9/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_argb1555()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/tests/drm_format_helper_test.c include/drm/drm_format_helper.h+13 -150 replies
10/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_rgba5551()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/tests/drm_format_helper_test.c include/drm/drm_format_helper.h+10 -120 replies
11/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_rgb888()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/gud/gud_pipe.c drivers/gpu/drm/tests/drm_format_helper_test.c +1 more+13 -150 replies
12/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_argb8888()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/tests/drm_format_helper_test.c include/drm/drm_format_helper.h+13 -150 replies
13/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_abgr8888()drivers/gpu/drm/drm_format_helper.c+2 -70 replies
14/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_xbgr8888()drivers/gpu/drm/drm_format_helper.c+2 -70 replies
15/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_xrgb2101010()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/tests/drm_format_helper_test.c include/drm/drm_format_helper.h+10 -140 replies
16/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_argb2101010()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/tests/drm_format_helper_test.c include/drm/drm_format_helper.h+11 -150 replies
17/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_gray8()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/gud/gud_pipe.c drivers/gpu/drm/solomon/ssd130x.c +3 more+21 -170 replies
18/23drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_mono()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/solomon/ssd130x.c drivers/gpu/drm/tests/drm_format_helper_test.c +2 more+28 -200 replies
19/23drm/format-helper: Use struct drm_pixmap for drm_fb_blit()drivers/gpu/drm/drm_format_helper.c drivers/gpu/drm/tests/drm_format_helper_test.c drivers/gpu/drm/tiny/cirrus.c +3 more+47 -400 replies
20/23drm/format-helper: Add font-support for DRM pixmapdrivers/gpu/drm/drm_format_helper.c include/drm/drm_format_helper.h+31 -00 replies
21/23drm/format-helper: Add color palettedrivers/gpu/drm/drm_format_helper.c include/drm/drm_format_helper.h+48 -250 replies
22/23drm/format-helper: Support blitting from C1 to XRGB8888drivers/gpu/drm/drm_format_helper.c include/drm/drm_format_helper.h+41 -00 replies
23/23drm/format-helper: Add drm_fb_fill() to fill screen with colordrivers/gpu/drm/drm_format_helper.c include/drm/drm_format_helper.h+161 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/23] [RFC] drm/format-helper: Introduce drm_pixmap, font support and filling

This RFC patchset implements various features required for DRM panic handling [1] and should (for now) be seen in that context.

Most of all, the patchset replaces struct drm_framebuffer with struct drm_pixmap in the format-conversion helpers. DRM pixmap represents a source of pixel data for the blitting operations. Patches 1 to 19 update the interface, implementation and all of the callers. These patches could be useful even without DRM panic handling.

With struct drm_pixmap in place, patches 20 to 22 implement rudimentary support for blitting font data. The pixmap refers to a character's glyph, which the blit routines write to the destination memory. An example on blitting strings is given in patch 20's commit description.

Patch 23 adds rudimentary support for fill operations. The design is based on blitting, but blits the same color into each pixel.

[1] https://patchwork.freedesktop.org/series/122244/

Thomas Zimmermann (23):
drm/format-helper: Add struct drm_pixmap drm/format-helper: Use struct drm_pixmap for drm_fb_memcpy() drm/format-helper: Streamline drm_fb_xfrm() implementations drm/format-helper: Use struct drm_pixmap internally drm/format-helper: Use struct drm_pixmap for drm_fb_swab() drm/format-helper: Use struct drm_pixmap for

    drm_fb_xrgb8888_to_rgb332()
  drm/format-helper: Use struct drm_pixmap for
    drm_fb_xrgb8888_to_rgb565()
  drm/format-helper: Use struct drm_pixmap for
    drm_fb_xrgb8888_to_xrgb1555()
  drm/format-helper: Use struct drm_pixmap for
    drm_fb_xrgb8888_to_argb1555()
  drm/format-helper: Use struct drm_pixmap for
    drm_fb_xrgb8888_to_rgba5551()
  drm/format-helper: Use struct drm_pixmap for
    drm_fb_xrgb8888_to_rgb888()
  drm/format-helper: Use struct drm_pixmap for
    drm_fb_xrgb8888_to_argb8888()
  drm/format-helper: Use struct drm_pixmap for
    drm_fb_xrgb8888_to_abgr8888()
  drm/format-helper: Use struct drm_pixmap for
    drm_fb_xrgb8888_to_xbgr8888()
  drm/format-helper: Use struct drm_pixmap for
    drm_fb_xrgb8888_to_xrgb2101010()
  drm/format-helper: Use struct drm_pixmap for
    drm_fb_xrgb8888_to_argb2101010()
  drm/format-helper: Use struct drm_pixmap for
    drm_fb_xrgb8888_to_gray8()

drm/format-helper: Use struct drm_pixmap for drm_fb_xrgb8888_to_mono() drm/format-helper: Use struct drm_pixmap for drm_fb_blit() [DO NOT MERGE] drm/format-helper: Add font-support for DRM pixmap [DO NOT MERGE] drm/format-helper: Add color palette
[DO NOT MERGE] drm/format-helper: Support blitting from C1 to XRGB8888 [DO NOT MERGE] drm/format-helper: Add drm_fb_fill() to fill screen
with color

 drivers/gpu/drm/ast/ast_mode.c                |   4 +-
 drivers/gpu/drm/drm_format_helper.c           | 678 ++++++++++++------
 drivers/gpu/drm/drm_mipi_dbi.c                |   9 +-
 drivers/gpu/drm/gud/gud_pipe.c                |  24 +-
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c   |   4 +-
 drivers/gpu/drm/mgag200/mgag200_mode.c        |   4 +-
 drivers/gpu/drm/solomon/ssd130x.c             |  12 +-
 .../gpu/drm/tests/drm_format_helper_test.c    | 106 ++-
 drivers/gpu/drm/tiny/cirrus.c                 |   6 +-
 drivers/gpu/drm/tiny/ofdrm.c                  |   6 +-
 drivers/gpu/drm/tiny/repaper.c                |   4 +-
 drivers/gpu/drm/tiny/simpledrm.c              |   6 +-
 drivers/gpu/drm/tiny/st7586.c                 |   4 +-
 include/drm/drm_format_helper.h               | 116 ++-
 14 files changed, 678 insertions(+), 305 deletions(-)
Signature · 1 line
2.43.0