Skip to content

test_xarray: advanced API multi-index tests

Luis Chamberlain linux-fsdevel linux-mm lkml 1 version Applied

Status from this message: [merged mm-stable] xarray-add-cmpxchg-order-test.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 0 repliesApplied 2/2

Changes in v2 from the cover letter

- Fixed RCU stall, the issue was the misssing RCU locks when fetching an entry, so we now add test_get_entry() which mimics filemap_get_entry()
- Provide a bit more comments
- Check for alignment on the index to the order on check_xa_multi_store_adv_add()
- Use a helper check_xa_multi_store_adv_del_entry() to mimic what we do in page_cache_delete()

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2test_xarray: add tests for advanced multi-index uselib/test_xarray.c+164 -00 repliesApplied
2/2XArray: add cmpxchg order testlib/test_xarray.c+54 -00 repliesApplied

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchDaniel Gomez
1/2T-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] test_xarray: advanced API multi-index tests

This is a respin of the test_xarray multi-index tests [0] which use and demonstrate the advanced API which is used by the page cache. This should let folks more easily follow how we use multi-index to support for example a min order later in the page cache. It also lets us grow the selftests to mimic more of what we do in the page cache.

Changes since v1:

- Fixed RCU stall, the issue was the misssing RCU locks when fetching an entry, so we now add test_get_entry() which mimics filemap_get_entry()
- Provide a bit more comments
- Check for alignment on the index to the order on check_xa_multi_store_adv_add()
- Use a helper check_xa_multi_store_adv_del_entry() to mimic what we do in page_cache_delete()

Changes since RFC:

- Moved out from tmpfs large folio patches [1] so to keep these patches separate
- Update cmpxchg test to include another entry at 1 << order that 'keeps' the node around and order information.
- Update cmpxchg test to verify the entries and order in all tied indexes.
- Drop previous Luis Chamberlain's review as changes are significant from the RFC.

[0] https://lkml.kernel.org/r/[email protected]
[1] https://lore.kernel.org/all/[email protected]/

Daniel Gomez (1):
XArray: add cmpxchg order test

Luis Chamberlain (1):
test_xarray: add tests for advanced multi-index use

 lib/test_xarray.c | 218 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 218 insertions(+)
Signature · 1 line
2.43.0