Skip to content

tty: vt: cleanup ESC sequences handling

Jiri Slaby (SUSE) linux-serial lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22tty: vt: make rgb_from_256() slighly more comprehensibledrivers/tty/vt/vt.c+7 -40 replies
2/22tty: vt: define enums for CSI+h/l codesdrivers/tty/vt/vt.c+30 -120 replies
3/22tty: vt: rename set_mode() to csi_hl()drivers/tty/vt/vt.c+3 -30 replies
4/22tty: vt: split DEC CSI+h/l handling into csi_DEC_hl()drivers/tty/vt/vt.c+77 -670 replies
5/22tty: vt: remove unneeded assignment of EPecma to vc_privdrivers/tty/vt/vt.c+2 -30 replies
6/22tty: vt: move CSI+n handling along to other ECMA CSIsdrivers/tty/vt/vt.c+6 -80 replies
7/22tty: vt: define an enum for CSI+] codesdrivers/tty/vt/vt.c+25 -110 replies
8/22tty: vt: rename setterm_command() to csi_RSB()drivers/tty/vt/vt.c+10 -40 replies
9/22tty: vt: put cases on separate linesdrivers/tty/vt/vt.c+8 -40 replies
10/22tty: vt: accept u8 in do_con_trol() and vc_setGx()drivers/tty/vt/vt.c+3 -30 replies
11/22tty: vt: extract ascii handling to handle_ascii()drivers/tty/vt/vt.c+37 -210 replies
12/22tty: vt: separate ESesc state handling into handle_esc()drivers/tty/vt/vt.c+72 -620 replies
13/22tty: vt: move CSI DEC handling to a separate functiondrivers/tty/vt/vt.c+44 -310 replies
14/22tty: vt: move CSI ECMA handling to a separate functiondrivers/tty/vt/vt.c+139 -1300 replies
15/22tty: vt: name, reflow and document enum vc_ctl_statedrivers/tty/vt/vt.c+55 -170 replies
16/22tty: vt: simplify ansi_control_string()drivers/tty/vt/vt.c+6 -50 replies
17/22tty: vt: handle CSI+[ inside preexisting switch-casedrivers/tty/vt/vt.c+3 -40 replies
18/22tty: vt: add new helper for reseting vc parametersdrivers/tty/vt/vt.c+9 -60 replies
19/22tty: vt: use switch+case in the ESnonstd casedrivers/tty/vt/vt.c+8 -60 replies
20/22tty: vt: use switch+case in the ESgetpars casedrivers/tty/vt/vt.c+8 -40 replies
21/22tty: vt: use ASCII enum constants in vt_console_print()drivers/tty/vt/vt.c+5 -40 replies
22/22tty: vt: decrypt magic constants in vc_is_control()drivers/tty/vt/vt.c+7 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/22] tty: vt: cleanup ESC sequences handling

This is a promised followup of "tty: vt: cleanup and documentation" [1].

The escape sequences parser is cleaned up, so that it is easier to follow.

Most of the patches are easier to review with '-w -b' passed to git diff (as the code is moved to separate functions with a different level of indentation only).

[1] https://lore.kernel.org/all/[email protected]/T/

Jiri Slaby (SUSE) (22):
tty: vt: make rgb_from_256() slighly more comprehensible
tty: vt: define enums for CSI+h/l codes
tty: vt: rename set_mode() to csi_hl()
tty: vt: split DEC CSI+h/l handling into csi_DEC_hl()
tty: vt: remove unneeded assignment of EPecma to vc_priv
tty: vt: move CSI+n handling along to other ECMA CSIs
tty: vt: define an enum for CSI+] codes
tty: vt: rename setterm_command() to csi_RSB()
tty: vt: put cases on separate lines
tty: vt: accept u8 in do_con_trol() and vc_setGx()
tty: vt: extract ascii handling to handle_ascii()
tty: vt: separate ESesc state handling into handle_esc()
tty: vt: move CSI DEC handling to a separate function
tty: vt: move CSI ECMA handling to a separate function
tty: vt: name, reflow and document enum vc_ctl_state
tty: vt: simplify ansi_control_string()
tty: vt: handle CSI+[ inside preexisting switch-case
tty: vt: add new helper for reseting vc parameters
tty: vt: use switch+case in the ESnonstd case
tty: vt: use switch+case in the ESgetpars case
tty: vt: use ASCII enum constants in vt_console_print()
tty: vt: decrypt magic constants in vc_is_control()

 drivers/tty/vt/vt.c | 876 ++++++++++++++++++++++++++------------------
 1 file changed, 514 insertions(+), 362 deletions(-)
Signature · 1 line
2.43.0