Skip to content

drm/i915: Unpin cursor fb only after vblank.

Maarten Lankhorst intel-gfx 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm: Add drm_vblank_work_flush_all().drivers/gpu/drm/drm_vblank_work.c include/drm/drm_vblank_work.h+24 -00 replies
2/3drm/i915: Use vblank worker to unpin old legacy cursor fb safelydrivers/gpu/drm/i915/display/intel_cursor.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_types.h+30 -20 replies
3/3drm/i915: Use the same vblank worker for atomic unpindrivers/gpu/drm/i915/display/intel_atomic_plane.c drivers/gpu/drm/i915/display/intel_atomic_plane.h drivers/gpu/drm/i915/display/intel_crtc.c +2 more+49 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] drm/i915: Unpin cursor fb only after vblank.

Fix legacy cursor updates on xe by enforcing wait between updating registers and unpin.

In comparison with previous version, there was a small bug in the atomic unpin path. In intel_plane_cleanup_fb we tried to deference plane_state after calling vblank schedule. Remove plane from atomic state immediately after scheduling to prevent this issue. It's unsafe to deference plane_state as soon as schedule occured.

Maarten Lankhorst (2):
drm: Add drm_vblank_work_flush_all(). drm/i915: Use the same vblank worker for atomic unpin

Ville Syrjälä (1):
drm/i915: Use vblank worker to unpin old legacy cursor fb safely

 drivers/gpu/drm/drm_vblank_work.c             | 22 +++++++++++++
 .../gpu/drm/i915/display/intel_atomic_plane.c | 13 +++++++-
 .../gpu/drm/i915/display/intel_atomic_plane.h |  2 ++
 drivers/gpu/drm/i915/display/intel_crtc.c     | 31 +++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_cursor.c   | 26 ++++++++++++++--
 drivers/gpu/drm/i915/display/intel_cursor.h   |  3 ++
 drivers/gpu/drm/i915/display/intel_display.c  |  3 ++
 .../drm/i915/display/intel_display_types.h    |  3 ++
 include/drm/drm_vblank_work.h                 |  2 ++
 9 files changed, 102 insertions(+), 3 deletions(-)
Signature · 1 line
2.43.0