Skip to content

PCI: Consolidate TLP Log reading and printing

Ilpo Järvinen linux-pci linuxppc-dev lkml 9 versions – Applied

Status from this message: Applied to pci/err for v6.14, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest8 patches 2 repliesApplied
  2. v87 patches 11 repliesSuperseded
  3. v78 patches 3 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v68 patches14 repliesSuperseded
v57 patches4 repliesSuperseded
v47 patches1 replySuperseded
v32 patches2 repliesSuperseded
v22 patches2 repliesSuperseded
v14 patches6 repliesApplied

Changes in v9 from the cover letter

- Added patch to define header logging register sizes.

Patches in v9 Applied

#Subject and filesSizeRepliesApplied
1/8PCI: Don't expose pcie_read_tlp_log() outside of PCI subsystemdrivers/pci/pci.c drivers/pci/pci.h include/linux/aer.h+4 -30 replies
2/8PCI: Move TLP Log handling to own filedrivers/pci/pci.c drivers/pci/pci.h drivers/pci/pcie/Makefile +1 more+41 -290 replies
3/8PCI: Add defines for TLP Header/Prefix log sizesdrivers/pci/pcie/dpc.c drivers/pci/pcie/tlp.c drivers/pci/quirks.c +1 more+19 -81 reply
4/8PCI: Make pcie_read_tlp_log() signature samedrivers/pci/pcie/tlp.c+5 -60 replies
5/8PCI: Use unsigned int i in pcie_read_tlp_log()drivers/pci/pcie/tlp.c+2 -10 replies
6/8PCI: Store # of supported End-End TLP Prefixesdrivers/pci/ats.c drivers/pci/probe.c include/linux/pci.h +1 more+12 -70 replies
7/8PCI: Add TLP Prefix reading into pcie_read_tlp_log()drivers/pci/pci.h drivers/pci/pcie/aer.c drivers/pci/pcie/dpc.c +3 more+68 -180 replies
8/8PCI: Create helper to print TLP Header and Prefix Logdrivers/pci/pci.h drivers/pci/pcie/aer.c drivers/pci/pcie/dpc.c +1 more+39 -120 replies

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchJonathan CameronYazen Ghannam
1/8R-b R-b
2/8R-b R-b
3/8
4/8R-b R-b
5/8R-b
6/8R-b R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 0/8] PCI: Consolidate TLP Log reading and printing

This series has the remaining patches of the AER & DPC TLP Log handling consolidation and now includes a few minor improvements to the earlier accepted TLP Logging code.

v9:
- Added patch to define header logging register sizes.

v8:
- Added missing parameter to kerneldoc.
- Dropped last patch due to conflict with the pci_printk() cleanup series (will move the patch into that series).

v7:
- Explain in commit message reasoning why eetlp_prefix_max stores Max End-End TLP Prefixes value instead of limiting it by the bridge/RP imposed limits
- Take account TLP Prefix Log Present flag.
- Align PCI_ERR_CAP_* flags in pci_regs.h
- Add EE_PREFIX_STR define to be able to take its sizeof() for output char[] sizing.

v6:
- Preserve "AER:"/"DPC:" prefix on the printed TLP line
- New patch to add "AER:" also on other lines of the AER error dump

v5:
- Fix build with AER=y and DPC=n
- Match kerneldoc and function parameter name

v4:
- Added patches:
- Remove EXPORT of pcie_read_tlp_log()
- Moved code to pcie/tlp.c and build only with AER enabled
- Match variables in prototype and function
- int -> unsigned int conversion
- eetlp_prefix_max into own patch
- struct pcie_tlp_log param consistently called "log" within tlp.c
- Moved function prototypes into drivers/pci/pci.h
- Describe AER/DPC differences more clearly in one commit message

v3:
- Small rewording in a commit message

v2:
- Don't add EXPORT()s
- Don't include igxbe changes
- Don't use pr_cont() as it's incompatible with pci_err() and according to Andy Shevchenko should not be used in the first place

Ilpo Järvinen (8):
PCI: Don't expose pcie_read_tlp_log() outside of PCI subsystem
PCI: Move TLP Log handling to own file
PCI: Add defines for TLP Header/Prefix log sizes
PCI: Make pcie_read_tlp_log() signature same
PCI: Use unsigned int i in pcie_read_tlp_log()
PCI: Store # of supported End-End TLP Prefixes
PCI: Add TLP Prefix reading into pcie_read_tlp_log()
PCI: Create helper to print TLP Header and Prefix Log

 drivers/pci/ats.c             |   2 +-
 drivers/pci/pci.c             |  28 ---------
 drivers/pci/pci.h             |   9 +++
 drivers/pci/pcie/Makefile     |   2 +-
 drivers/pci/pcie/aer.c        |  15 ++---
 drivers/pci/pcie/dpc.c        |  22 +++----
 drivers/pci/pcie/tlp.c        | 115 ++++++++++++++++++++++++++++++++++
 drivers/pci/probe.c           |  14 +++--
 drivers/pci/quirks.c          |   6 +-
 include/linux/aer.h           |  12 +++-
 include/linux/pci.h           |   2 +-
 include/uapi/linux/pci_regs.h |  11 ++--
 12 files changed, 172 insertions(+), 66 deletions(-)
 create mode 100644 drivers/pci/pcie/tlp.c

base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37

Signature · 1 line
2.39.5