Skip to content

Misc cleanups / optimizations

Jens Axboe io-uring 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 3 repliesIn review
  2. v16 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Drop nr_tw union with comp_list, that breaks iopoll with DEFER_TASKRUN usage.
- Rearrange io_kiocb again in patch 1, now just moving nr_tw up to fill the new hole, and shifting rsrc_node down to keep io_comp_list in the 2nd cacheline.
- Add cleanup patch for io_req_complete_post()

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6io_uring: expand main struct io_kiocb flags to 64-bitsinclude/linux/io_uring_types.h include/trace/events/io_uring.h io_uring/filetable.h +1 more+55 -473 replies
2/6io_uring/cancel: don't default to setting req->work.cancel_seqinclude/linux/io_uring_types.h io_uring/cancel.c io_uring/cancel.h +2 more+15 -80 replies
3/6io_uring: add io_file_can_poll() helperinclude/linux/io_uring_types.h io_uring/io_uring.c io_uring/io_uring.h +3 more+21 -60 replies
4/6io_uring: mark the need to lock/unlock the ring as unlikelyio_uring/io_uring.h+2 -20 replies
5/6io_uring: cleanup io_req_complete_post()io_uring/io_uring.c+4 -40 replies
6/6io_uring/rw: remove dead file == NULL checkio_uring/rw.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHSET v2 0/6] Misc cleanups / optimizations

Hi,

Nothing major in here:

- Expand io_kiocb flags to 64-bits, so we can use two more bits for caching cancelation sequence and pollable state.
- Misc cleanups

Changes since v1:
- Drop nr_tw union with comp_list, that breaks iopoll with DEFER_TASKRUN usage.
- Rearrange io_kiocb again in patch 1, now just moving nr_tw up to fill the new hole, and shifting rsrc_node down to keep io_comp_list in the 2nd cacheline.
- Add cleanup patch for io_req_complete_post()

Signature · 1 line
Jens Axboe