KTD2026 indicator LED for X86 Xiaomi Pad2
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest6 patches 7 repliesIn review
- v65 patches 12 repliesSuperseded
- v5 posting 2/26 patches 15 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 posting 1/2 | 6 patches | 4 replies | Superseded | |
| v4 | 2 patches | 10 replies | Superseded | |
| v3 | 2 patches | 2 replies | Superseded | |
| v2 | 3 patches | 7 replies | Superseded | |
| v1 | 2 patches | 2 replies | Superseded |
Changes in v7 from the cover letter
1. Platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED was included in Hans' branch.
2. Included the tags from the previous version in the commit message.
3. Fixed the comma issue for the structure initialiser.
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPIdrivers/ drivers/ | +34 | 1 reply | |
| 2/6 | leds: rgb: leds-ktd202x: I2C ID tables for KTD2026 and 2027drivers/ | +8 | 2 replies | |
| 3/6 | leds: core: Add led_mc_set_brightness() functiondrivers/ drivers/ include/ | +52 | 0 replies | |
| 4/6 | leds: trigger: Add led_mc_trigger_event() functiondrivers/ include/ | +26 | 0 replies | |
| 5/6 | power: supply: power-supply-leds: Add charging_orange_full_green trigger for RGB LEDdrivers/ include/ | +28 | 2 replies | |
| 6/6 | platform: x86-android-tablets: others: Set the LED trigger to charging_orange_full_green for Xiaomi pad2drivers/ | +1 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | André Apitzsch | Jacek Anaszewski | Sebastian Reichel | Hans de Goede |
|---|---|---|---|---|
| 1/6 | T-b | R-b | ||
| 2/6 | R-b | |||
| 3/6 | R-b | |||
| 4/6 | R-b | |||
| 5/6 | A-b | R-b | ||
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v7 0/6] KTD2026 indicator LED for X86 Xiaomi Pad2
This patch added the support for Xiaomi Pad2 indicator LED. This work included:
1. Added the KTD2026 swnode description to describe the LED controller.
2. Migrated the original driver to fwnode to support x86 platform.
3. Support for multi-color LED trigger event.
4. The LED shows orange when charging and the LED shows green when the battery is full.
Moreover, the LED trigger is set to the new trigger, called "bq27520-0-charging-orange-full-green" for Xiaomi Pad2 so the LED shows orange when charging and the LED shows green when the battery is full.
--
Changes in v7:
1. Platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED was included in Hans' branch.
2. Included the tags from the previous version in the commit message.
3. Fixed the comma issue for the structure initialiser.
Changes in v6:
1. The I2C ID table was moved to a separate patch.
2. The LED shows orange when charging.
3. The trigger name was renamed to charging-orange-full-green.
4. The default trigger of Xiaomi Pad2 is "bq27520-0-charging-orange-full-green".
Changes in v5:
1. Fix swnode LED color settings.
2. Improve the driver based on the comments.
3. Introduce a LED new API- led_mc_trigger_event() to make the LED color can be changed according to the trigger.
4. Introduced a new trigger "charging-red-full-green". The LED will be red when charging and the the LED will be green when the battery is full.
5. Set the default trigger to "bq27520-0-charging-red-full-green" for Xiaomi Pad2.
Changes in v4:
1. Fix double casting.
2. Since force casting a pointer value to int will trigger a compiler warning, the type of num_leds was changed to unsigned long.
Changes in v3:
1. Drop the patch "leds-ktd202x: Skip regulator settings for Xiaomi pad2"
Changes in v2:
1. Typo and style fixes.
2. The patch 0003 skips all the regulator setup for Xiaomi pad2 since KTD2026 on Xiaomi pad2 is already powered by BP25890RTWR. So, the sleep can be removed when removing the module.
Hans de Goede (2):
leds: core: Add led_mc_set_brightness() function
leds: trigger: Add led_mc_trigger_event() function
Kate Hsuan (4):
leds: rgb: leds-ktd202x: Get device properties through fwnode to
support ACPI
leds: rgb: leds-ktd202x: I2C ID tables for KTD2026 and 2027
power: supply: power-supply-leds: Add charging_orange_full_green
trigger for RGB LED
platform: x86-android-tablets: others: Set the LED trigger to
charging_orange_full_green for Xiaomi pad2
drivers/leds/led-class-multicolor.c | 1 + drivers/leds/led-core.c | 31 ++++++++ drivers/leds/led-triggers.c | 20 ++++++ drivers/leds/rgb/Kconfig | 1 - drivers/leds/rgb/leds-ktd202x.c | 72 +++++++++++-------- .../platform/x86/x86-android-tablets/other.c | 2 +- drivers/power/supply/power_supply_leds.c | 26 +++++++ include/linux/leds.h | 26 +++++++ include/linux/power_supply.h | 2 + 9 files changed, 149 insertions(+), 32 deletions(-)
Signature · 1 line
2.44.0