Skip to content

kbuild: Fix install errors when INSTALL_PATH does not exist

Zhang Bingwu linux-arm-kernel linux-kbuild linux-m68k linux-parisc linux-riscv linux-s390 lkml sparclinux 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/22 patches 3 repliesIn review
  2. v1 posting 1/22 patches 7 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2kbuild: Abort make on install failuresarch/arm/boot/install.sh arch/arm64/boot/install.sh arch/m68k/install.sh +6 more+18 -01 reply
2/2kbuild: Create INSTALL_PATH directory if it does not existscripts/install.sh+4 -02 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchNicolas Schier
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RESEND PATCH 0/2] kbuild: Fix install errors when INSTALL_PATH does not exist

From: Zhang Bingwu <[email protected]>

When running 'make zinstall INSTALL_PATH=somepath'
where 'somepath' does not exist, the install scripts (install.sh) print error messages
but also return a success status code.
This will make 'make' regard 'install' (and 'zinstall', etc)
succeeded.
When there are also other targets at the same time,
for example, 'make zinstall dtbs_install modules_install', make will keep going on and other outputs will fill stdout, and make the error message hard to find.

dtbs_install and modules_install creates the target directory
if it does not exist. install, zinstall and others should have the same behaviour.

If INSTALL_PATH is not a valid directory, we should create it. If the installation process still fails with errors, for example,
insufficient space on disk or permission denied, make should regard the install target failed, stop as soon as possible,
and exit with error.

Zhang Bingwu (2):
kbuild: Abort make on install failures
kbuild: Create INSTALL_PATH directory if it does not exist

 arch/arm/boot/install.sh   | 2 ++
 arch/arm64/boot/install.sh | 2 ++
 arch/m68k/install.sh       | 2 ++
 arch/nios2/boot/install.sh | 2 ++
 arch/parisc/install.sh     | 2 ++
 arch/riscv/boot/install.sh | 2 ++
 arch/s390/boot/install.sh  | 2 ++
 arch/sparc/boot/install.sh | 2 ++
 arch/x86/boot/install.sh   | 2 ++
 scripts/install.sh         | 4 ++++
 10 files changed, 22 insertions(+)

base-commit: d0f86d080e3d7d5e1e75a56d88daf8e5f56a4146

Signature · 1 line
2.43.0