Skip to content

RFC Using l_notice for low level IWD state information

James Prestwood iwd 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest5 patches 0 repliesNew
  2. v1 RFC5 patches 6 repliesSuperseded

Changes in v2 from the cover letter

* Removed use of station_debug_event for notice logs
* Added iwd_notice to wrap l_notice:
1. To aid in enforcement of the formatting
2. To make it easier to enforce proper notice use during patch review, so people aren't calling l_notice directly.
If we want a separate header for this thats fine, I just put it in iwd.h for now.
* Made notice events constant defines. Using enums would be nice but in order to specify and event + formatting string constant strings were the only simple way to do that without reading in each argument via va_args. If anyone has better ideas I'm open to them.
* Please don't merge this, I still want to get more events added and make sure its as easy as possible to write tooling before we upstream. With this RFC I merely wanted to get feedback on how we should do this, not necissarily specifics on what events we should/shouldn't be logging.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5main: add runtime flag for setting the loggersrc/main.c+12 -20 replies
2/5iwd: add iwd_notice for special event/state type of loggingsrc/iwd.h+13 -00 replies
3/5doc: document use of l_log APIsdoc/coding-style.txt+15 -00 replies
4/5station: use iwd_notice for state/event informationsrc/station.c+25 -70 replies
5/5netdev: add notice events for connection timeoutssrc/netdev.c+4 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFCv2 0/5] Using l_notice for low level IWD state information

v2:
* Removed use of station_debug_event for notice logs
* Added iwd_notice to wrap l_notice:
1. To aid in enforcement of the formatting
2. To make it easier to enforce proper notice use during patch review, so people aren't calling l_notice directly.
If we want a separate header for this thats fine, I just put it in iwd.h for now.
* Made notice events constant defines. Using enums would be nice but in order to specify and event + formatting string constant strings were the only simple way to do that without reading in each argument via va_args. If anyone has better ideas I'm open to them.
* Please don't merge this, I still want to get more events added and make sure its as easy as possible to write tooling before we upstream. With this RFC I merely wanted to get feedback on how we should do this, not necissarily specifics on what events we should/shouldn't be logging.

James Prestwood (5):
main: add runtime flag for setting the logger
iwd: add iwd_notice for special event/state type of logging
doc: document use of l_log APIs
station: use iwd_notice for state/event information
netdev: add notice events for connection timeouts

 doc/coding-style.txt | 15 +++++++++++++++
 src/iwd.h            | 13 +++++++++++++
 src/main.c           | 14 ++++++++++++--
 src/netdev.c         |  7 ++++---
 src/station.c        | 32 +++++++++++++++++++++++++-------
 5 files changed, 69 insertions(+), 12 deletions(-)
Signature · 1 line
2.34.1