Skip to content

MIPS: Fix missing proto and passing arg warnings

Serge Semin linux-mips lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 8 repliesIn review
  2. v14 patches 9 repliesApplied

Changes in v2 from the cover letter

- Drop aleady applied pateches:
[PATCH 3/4] mips: zboot: Fix "no previous prototype" build warning [PATCH 4/4] tty: mips_ejtag_fdc: Fix passing incompatible pointer type warning
- Drop Linux serial mailing list and the respective maintainers from the Cc-list.
- Covert the underscored versions of the CM2/L2-sync base address getters to being the body of the weakly defined original methods.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mips: cm: Convert __mips_cm_l2sync_phys_base() to weak functionarch/mips/include/asm/mips-cm.h arch/mips/kernel/mips-cm.c+14 -47 replies
2/2mips: cm: Convert __mips_cm_phys_base() to weak functionarch/mips/include/asm/mips-cm.h arch/mips/kernel/mips-cm.c+4 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] MIPS: Fix missing proto and passing arg warnings

After getting my local tree rebased onto the kernel 6.8-rc3 the MIPS32 kernel build procedure produced a couple of warnings which I suggest to fix in the framework of this series.

A first warning is of the "no previous prototype for <func>" type. In particular my arch-specific code has the mips_cm_l2sync_phys_base() method re-defined, but even though the function is global it' prototype isn't declared anywhere. Fix that by moving the __mips_cm_l2sync_phys_base() body to a weak implementation of mips_cm_l2sync_phys_base() and adding the method prototype declaration to the mips/include/asm/mips-cm.h header file. For the sake of unification a similar solution was provided for the mips_cm_phys_base()/__mips_cm_phys_base() couple.

The following text describes the patches which have already merged in at v1 stage of the patchset (see changelog v2).

One more case of the denoted earlier warning I spotted in the self-extracting kernel (so called zboot) with the debug printouts enabled. In particular there are several putc() method re-definitions available in:
arch/mips/boot/compressed/uart-prom.c arch/mips/boot/compressed/uart-16550.c arch/mips/boot/compressed/uart-alchemy.c
All of these files lacked the prototype declaration what caused having the "no previous prototype for ‘putc’" printed on my build with the next configs enabled:
CONFIG_SYS_SUPPORTS_ZBOOT=y CONFIG_SYS_SUPPORTS_ZBOOT_UART_PROM=y CONFIG_ZBOOT_LOAD_ADDRESS=0x85100000
CONFIG_DEBUG_ZBOOT=y

The second warning is of the "passing argument <x> of ‘<func>’ from incompatible pointer type" type which I discovered in the drivers/tty/mips_ejtag_fdc.c driver. The problem most likely happened due to the commit ce7cbd9a6c81 ("tty: mips_ejtag_fdc: use u8 for character pointers").

That's it for today.) Thanks for review in advance. Any tests are very welcome.

Changelog v2:
- Drop aleady applied pateches:
[PATCH 3/4] mips: zboot: Fix "no previous prototype" build warning [PATCH 4/4] tty: mips_ejtag_fdc: Fix passing incompatible pointer type warning
- Drop Linux serial mailing list and the respective maintainers from the Cc-list.
- Covert the underscored versions of the CM2/L2-sync base address getters to being the body of the weakly defined original methods.

Serge Semin (2):
mips: cm: Convert __mips_cm_l2sync_phys_base() to weak function
mips: cm: Convert __mips_cm_phys_base() to weak function

 arch/mips/include/asm/mips-cm.h | 20 ++++++++++++++++----
 arch/mips/kernel/mips-cm.c      | 10 ++--------
 2 files changed, 18 insertions(+), 12 deletions(-)
Signature · 1 line
2.43.0