Skip to content

fsi: Add interrupt support

Eddie James linux-aspeed linux-i2c linux-spi lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest40 patches 2 repliesIn review
  2. v340 patches 1 replySuperseded
  3. v231 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v133 patches10 repliesApplied

Changes in v4 from the cover letter

- Fix compile warnings due to non-static local function and incorrect use of handle_irq_desc

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/40fsi: hub: Set master index to link number plus onedrivers/fsi/fsi-master-hub.c+2 -00 replies
2/40fsi: Move slave definitions to fsi-slave.hdrivers/fsi/fsi-core.c drivers/fsi/fsi-slave.h+84 -350 replies
3/40fsi: Fix slave addressing after break commanddrivers/fsi/fsi-core.c drivers/fsi/fsi-master-hub.c drivers/fsi/fsi-master.h +1 more+13 -100 replies
4/40fsi: Use a defined value for default echo delaydrivers/fsi/fsi-core.c drivers/fsi/fsi-slave.h+5 -30 replies
5/40fsi: Calculate local bus clock frequencydrivers/fsi/fsi-core.c drivers/fsi/fsi-master.h drivers/fsi/fsi-slave.h +1 more+23 -30 replies
6/40fsi: core: Improve master read/write/error tracesdrivers/fsi/fsi-core.c include/trace/events/fsi.h+51 -870 replies
7/40fsi: core: Add slave error tracedrivers/fsi/fsi-core.c include/trace/events/fsi.h+20 -00 replies
8/40fsi: core: Reset errors instead of clearing interruptsdrivers/fsi/fsi-core.c drivers/fsi/fsi-slave.h+11 -40 replies
9/40fsi: aspeed: Add AST2700 supportdrivers/fsi/fsi-master-aspeed.c+30 -30 replies
10/40fsi: core: Add slave spinlockdrivers/fsi/fsi-core.c drivers/fsi/fsi-slave.h+9 -00 replies
11/40fsi: core: Allow cfam device type aliasesdrivers/fsi/fsi-core.c+29 -300 replies
12/40fsi: core: Add common regmap master functionsdrivers/fsi/Kconfig drivers/fsi/fsi-core.c drivers/fsi/fsi-master.h +1 more+195 -20 replies
13/40fsi: core: Disable relative addressing during scandrivers/fsi/fsi-core.c+18 -00 replies
14/40fsi: hub: Use common initialization and link enabledrivers/fsi/fsi-master-hub.c+23 -1190 replies
15/40fsi: aspeed: Use common initialization and link enabledrivers/fsi/fsi-master-aspeed.c+68 -1050 replies
16/40fsi: aspeed: Remove cfam reset sysfs file in error path and removedrivers/fsi/fsi-master-aspeed.c+7 -00 replies
17/40fsi: aspeed: Refactor trace functionsdrivers/fsi/fsi-master-aspeed.c include/trace/events/fsi_master_aspeed.h+34 -750 replies
18/40fsi: aspeed: Don't clear all IRQs during OPB transfersdrivers/fsi/fsi-master-aspeed.c+9 -40 replies
19/40fsi: aspeed: Only read result register for successful readdrivers/fsi/fsi-master-aspeed.c+13 -160 replies
20/40fsi: aspeed: Switch to spinlockdrivers/fsi/fsi-master-aspeed.c+14 -110 replies
21/40fsi: aspeed: Disable relative addressing and IPOLL for cfam resetdrivers/fsi/fsi-master-aspeed.c+7 -00 replies
22/40fsi: aspeed: Use common master error handlerdrivers/fsi/fsi-master-aspeed.c+4 -230 replies
23/40fsi: core: Add interrupt supportdrivers/fsi/fsi-core.c drivers/fsi/fsi-master.h drivers/fsi/fsi-slave.h +2 more+211 -10 replies
24/40fsi: aspeed: Add interrupt supportdrivers/fsi/fsi-master-aspeed.c include/trace/events/fsi_master_aspeed.h+115 -30 replies
25/40fsi: hub: Add interrupt supportdrivers/fsi/fsi-master-hub.c+116 -30 replies
26/40i2c: fsi: Calculate clock divider from local bus frequencydrivers/i2c/busses/i2c-fsi.c+18 -20 replies
27/40i2c: fsi: Improve formattingdrivers/i2c/busses/i2c-fsi.c+60 -650 replies
28/40i2c: fsi: Change fsi_i2c_write_reg to accept data instead of a pointerdrivers/i2c/busses/i2c-fsi.c+20 -270 replies
29/40i2c: fsi: Remove list structure of portsdrivers/i2c/busses/i2c-fsi.c+11 -330 replies
30/40i2c: fsi: Define a function to check status error bitsdrivers/i2c/busses/i2c-fsi.c+21 -170 replies
31/40i2c: fsi: Add boolean for skip stop command on abortdrivers/i2c/busses/i2c-fsi.c+11 -70 replies
32/40i2c: fsi: Add interrupt supportdrivers/i2c/busses/i2c-fsi.c include/trace/events/i2c_fsi.h+245 -150 replies
33/40fsi: hub master: Reset hub master after errorsdrivers/fsi/fsi-master-hub.c+12 -20 replies
34/40fsi: core: Add master register read-only sysfsdrivers/fsi/fsi-core.c drivers/fsi/fsi-master.h+150 -00 replies
35/40fsi: core: Add slave register read-only sysfsdrivers/fsi/fsi-core.c drivers/fsi/fsi-slave.h+155 -100 replies
36/40fsi: i2cr: Adjust virtual CFAM ID to match Odyssey chipdrivers/fsi/fsi-master-i2cr.c+1 -10 replies
37/40fsi: core: Add different types of CFAMdrivers/fsi/fsi-core.c+83 -10 replies
38/40spi: fsi: Calculate clock divider from local bus frequencydrivers/spi/spi-fsi.c+30 -30 replies
39/40ARM: dts: aspeed: P10 and tacoma: Set FSI clock frequencyarch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi+2 -00 replies
40/40ARM: dts: aspeed: P10: Bump SPI max frequenciesarch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts arch/arm/boot/dts/aspeed/ibm-power10-dual.dtsi arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi+32 -320 replies

Reviews trailers per patch

1 of 40 patches has a Reviewed-by or Acked-by.

PatchMark Brown
1/40
2/40
3/40
4/40
5/40
6/40
7/40
8/40
9/40
10/40
11/40
12/40
13/40
14/40
15/40
16/40
17/40
18/40
19/40
20/40
21/40
22/40
23/40
24/40
25/40
26/40
27/40
28/40
29/40
30/40
31/40
32/40
33/40
34/40
35/40
36/40
37/40
38/40A-b
39/40
40/40

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/40] fsi: Add interrupt support

This series primarily adds interrupt support to the FSI driver subsystem. There are a number of related changes and fixes. Firstly, the FSI clocking model is improved to allow FSI engine drivers to obtain real clock rates and calculate appropriate clock dividers. Secondly, much master code is made common through the use of a regmap to access master registers. This will prove more useful as additional FSI master drivers are added. Lastly, interrupt support is added to the FSI I2C driver.

Changes since v3:
- Fix compile warnings due to non-static local function and incorrect use of handle_irq_desc

Changes since v2:
- Add several patches to fix additional issues found during testing
- For local bus frequenccy, use cfam clock-frequency property instead of hardcoded master local bus divider
- Change default local bus clock divider from 8 to 2
- Zero the regmap_config structure in the common FSI initialization function
- Add AST2700 direct AHB access of master registers
- Remove slave interrupt handler since it's not used yet
- For I2C driver, change minimum clock div to 3, use DIV_ROUND_UP instead of re-implementing it, and use better logic for checking for clock-frequency property
- Add detail to I2C driver formatting change

Eddie James (40):
fsi: hub: Set master index to link number plus one
fsi: Move slave definitions to fsi-slave.h
fsi: Fix slave addressing after break command
fsi: Use a defined value for default echo delay
fsi: Calculate local bus clock frequency
fsi: core: Improve master read/write/error traces
fsi: core: Add slave error trace
fsi: core: Reset errors instead of clearing interrupts
fsi: aspeed: Add AST2700 support
fsi: core: Add slave spinlock
fsi: core: Allow cfam device type aliases
fsi: core: Add common regmap master functions
fsi: core: Disable relative addressing during scan
fsi: hub: Use common initialization and link enable
fsi: aspeed: Use common initialization and link enable
fsi: aspeed: Remove cfam reset sysfs file in error path and remove
fsi: aspeed: Refactor trace functions
fsi: aspeed: Don't clear all IRQs during OPB transfers
fsi: aspeed: Only read result register for successful read
fsi: aspeed: Switch to spinlock
fsi: aspeed: Disable relative addressing and IPOLL for cfam reset
fsi: aspeed: Use common master error handler
fsi: core: Add interrupt support
fsi: aspeed: Add interrupt support
fsi: hub: Add interrupt support
i2c: fsi: Calculate clock divider from local bus frequency
i2c: fsi: Improve formatting
i2c: fsi: Change fsi_i2c_write_reg to accept data instead of a pointer
i2c: fsi: Remove list structure of ports
i2c: fsi: Define a function to check status error bits
i2c: fsi: Add boolean for skip stop command on abort
i2c: fsi: Add interrupt support
fsi: hub master: Reset hub master after errors
fsi: core: Add master register read-only sysfs
fsi: core: Add slave register read-only sysfs
fsi: i2cr: Adjust virtual CFAM ID to match Odyssey chip
fsi: core: Add different types of CFAM
spi: fsi: Calculate clock divider from local bus frequency
ARM: dts: aspeed: P10 and tacoma: Set FSI clock frequency
ARM: dts: aspeed: P10: Bump SPI max frequencies

 .../dts/aspeed/aspeed-bmc-ibm-everest.dts     |  32 +-
 .../boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts |   1 +
 .../arm/boot/dts/aspeed/ibm-power10-dual.dtsi |  17 +-
 .../arm/boot/dts/aspeed/ibm-power10-quad.dtsi |  16 +-
 drivers/fsi/Kconfig                           |   2 +
 drivers/fsi/fsi-core.c                        | 888 +++++++++++++++---
 drivers/fsi/fsi-master-aspeed.c               | 431 +++++----
 drivers/fsi/fsi-master-hub.c                  | 244 ++---
 drivers/fsi/fsi-master-i2cr.c                 |   2 +-
 drivers/fsi/fsi-master.h                      |  33 +
 drivers/fsi/fsi-slave.h                       | 117 +++
 drivers/i2c/busses/i2c-fsi.c                  | 463 ++++++---
 drivers/spi/spi-fsi.c                         |  33 +-
 include/linux/fsi.h                           |   3 +
 include/trace/events/fsi.h                    | 171 ++--
 include/trace/events/fsi_master_aspeed.h      |  86 +-
 include/trace/events/i2c_fsi.h                |  45 +
 17 files changed, 1897 insertions(+), 687 deletions(-)
 create mode 100644 include/trace/events/i2c_fsi.h
Signature · 1 line
2.39.3