Skip to content

Cover a guard gap corner case

Rick Edgecombe bpf io-uring linux-alpha linux-arm-kernel linux-csky linux-cxl linux-fsdevel linux-mips linux-mm linux-parisc linux-s390 linux-sgx linux-sh linux-snps-arc linuxppc-dev lkml loongarch nvdimm sparclinux 4 versions – Applied

Status from this message: [merged mm-stable] selftests-x86-add-placement-guard-gap-test-for-shstk.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest14 patches 7 repliesApplied 14/14
  2. v312 patches 23 repliesSuperseded
  3. v29 patches 14 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC8 patches15 repliesSuperseded

v3 from the cover letter

Patches in v4 All 14 applied

#Subject and filesSizeRepliesApplied
1/14proc: Refactor pde_get_unmapped_area as prepfs/proc/inode.c+3 -60 repliesApplied
2/14mm: Switch mm->get_unmapped_area() to a flagarch/s390/mm/hugetlbpage.c arch/s390/mm/mmap.c arch/sparc/kernel/sys_sparc_64.c +20 more+66 -577 repliesApplied
3/14mm: Introduce arch_get_unmapped_area_vmflags()include/linux/sched/mm.h mm/mmap.c+45 -00 repliesApplied
4/14mm: Remove export for get_unmapped_area()mm/mmap.c+0 -20 repliesApplied
5/14mm: Use get_unmapped_area_vmflags()include/linux/mm.h mm/mmap.c+26 -170 repliesApplied
6/14thp: Add thp_get_unmapped_area_vmflags()include/linux/huge_mm.h mm/huge_memory.c mm/mmap.c+34 -120 repliesApplied
7/14csky: Use initializer for struct vm_unmapped_area_infoarch/csky/abiv1/mmap.c+6 -60 repliesApplied
8/14parisc: Use initializer for struct vm_unmapped_area_infoarch/parisc/kernel/sys_parisc.c+3 -30 repliesApplied
9/14powerpc: Use initializer for struct vm_unmapped_area_infoarch/powerpc/mm/book3s64/slice.c+9 -110 repliesApplied
10/14treewide: Use initializer for struct vm_unmapped_area_infoarch/alpha/kernel/osf_sys.c arch/arc/mm/mmap.c arch/arm/mm/mmap.c +12 more+25 -570 repliesApplied
11/14mm: Take placement mappings gap into accountinclude/linux/mm.h mm/mmap.c+10 -30 repliesApplied
12/14x86/mm: Implement HAVE_ARCH_UNMAPPED_AREA_VMFLAGSarch/x86/include/asm/pgtable_64.h arch/x86/kernel/sys_x86_64.c+21 -50 repliesApplied
13/14x86/mm: Care about shadow stack guard gap during placementarch/x86/kernel/sys_x86_64.c+10 -00 repliesApplied
14/14selftests/x86: Add placement guard gap test for shstktools/testing/selftests/x86/test_shadow_stack.c+63 -40 repliesApplied

Reviews trailers per patch

8 of 14 patches have a Reviewed-by or Acked-by.

PatchDave HansenLiam R. HowlettKirill A. ShutemovKees CookChristophe LeroyGuo RenMichael EllermanHelge DellerAlexei Starovoitov
1/14
2/14A-b A-b R-b A-b
3/14
4/14
5/14R-b
6/14R-b
7/14R-b R-b
8/14R-b A-b
9/14A-b
10/14R-b
11/14R-b
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/14] Cover a guard gap corner case

Hi,

For v4, is just some small non-functional changes from Christophe Leroy, including splitting two patches.

Also, rebase to v6.9-rc1. This included converting two new mm->get_unmapped_area() callsites that popped up.

v3:
https://lore.kernel.org/lkml/[email protected]/

v2:
https://lore.kernel.org/lkml/[email protected]/

v1:
https://lore.kernel.org/lkml/[email protected]/

=======

In working on x86’s shadow stack feature, I came across some limitations around the kernel’s handling of guard gaps. AFAICT these limitations are not too important for the traditional stack usage of guard gaps, but have bigger impact on shadow stack’s usage. And now in addition to x86, we have two other architectures implementing shadow stack like features that plan to use guard gaps. I wanted to see about addressing them, but I have not worked on mmap() placement related code before, so would greatly appreciate if people could take a look and point me in the right direction.

The nature of the limitations of concern is as follows. In order to ensure guard gaps between mappings, mmap() would need to consider two things:
1. That the new mapping isn’t placed in an any existing mapping’s guard gap.
2. That the new mapping isn’t placed such that any existing mappings are not in *its* guard gaps
Currently mmap never considers (2), and (1) is not considered in some situations.

When not passing an address hint, or passing one without MAP_FIXED_NOREPLACE, (1) is enforced. With MAP_FIXED_NOREPLACE, (1) is not enforced. With MAP_FIXED, (1) is not considered, but this seems to be expected since MAP_FIXED can already clobber existing mappings. For MAP_FIXED_NOREPLACE I would have guessed it should respect the guard gaps of existing mappings, but it is probably a little ambiguous.

In this series I just tried to add enforcement of (2) for the normal (no address hint) case and only for the newer shadow stack memory (not stacks). The reason is that with the no-address-hint situation, landing next to a guard gap could come up naturally and so be more influencable by attackers such that two shadow stacks could be adjacent without a guard gap. Where as the address-hint scenarios would require more control - being able to call mmap() with specific arguments. As for why not just fix the other corner cases anyway, I thought it might have some greater possibility of affecting existing apps.

Thanks,

Rick

Rick Edgecombe (14):
proc: Refactor pde_get_unmapped_area as prep
mm: Switch mm->get_unmapped_area() to a flag
mm: Introduce arch_get_unmapped_area_vmflags()
mm: Remove export for get_unmapped_area()
mm: Use get_unmapped_area_vmflags()
thp: Add thp_get_unmapped_area_vmflags()
csky: Use initializer for struct vm_unmapped_area_info
parisc: Use initializer for struct vm_unmapped_area_info
powerpc: Use initializer for struct vm_unmapped_area_info
treewide: Use initializer for struct vm_unmapped_area_info
mm: Take placement mappings gap into account x86/mm: Implement HAVE_ARCH_UNMAPPED_AREA_VMFLAGS x86/mm: Care about shadow stack guard gap during placement selftests/x86: Add placement guard gap test for shstk

 arch/alpha/kernel/osf_sys.c                   |   5 +-
 arch/arc/mm/mmap.c                            |   4 +-
 arch/arm/mm/mmap.c                            |   5 +-
 arch/csky/abiv1/mmap.c                        |  12 +-
 arch/loongarch/mm/mmap.c                      |   3 +-
 arch/mips/mm/mmap.c                           |   3 +-
 arch/parisc/kernel/sys_parisc.c               |   6 +-
 arch/powerpc/mm/book3s64/slice.c              |  20 ++--
 arch/s390/mm/hugetlbpage.c                    |   9 +-
 arch/s390/mm/mmap.c                           |   9 +-
 arch/sh/mm/mmap.c                             |   5 +-
 arch/sparc/kernel/sys_sparc_32.c              |   3 +-
 arch/sparc/kernel/sys_sparc_64.c              |  20 ++--
 arch/sparc/mm/hugetlbpage.c                   |   9 +-
 arch/x86/include/asm/pgtable_64.h             |   1 +
 arch/x86/kernel/cpu/sgx/driver.c              |   2 +-
 arch/x86/kernel/sys_x86_64.c                  |  42 +++++--
 arch/x86/mm/hugetlbpage.c                     |   9 +-
 arch/x86/mm/mmap.c                            |   4 +-
 drivers/char/mem.c                            |   2 +-
 drivers/dax/device.c                          |   6 +-
 fs/hugetlbfs/inode.c                          |  11 +-
 fs/proc/inode.c                               |  10 +-
 fs/ramfs/file-mmu.c                           |   2 +-
 include/linux/huge_mm.h                       |  11 ++
 include/linux/mm.h                            |  12 +-
 include/linux/mm_types.h                      |   6 +-
 include/linux/sched/coredump.h                |   5 +-
 include/linux/sched/mm.h                      |  22 ++++
 io_uring/io_uring.c                           |   2 +-
 kernel/bpf/arena.c                            |   2 +-
 kernel/bpf/syscall.c                          |   2 +-
 mm/debug.c                                    |   6 -
 mm/huge_memory.c                              |  26 +++--
 mm/mmap.c                                     | 106 +++++++++++++-----
 mm/shmem.c                                    |  11 +-
 mm/util.c                                     |   6 +-
 .../testing/selftests/x86/test_shadow_stack.c |  67 ++++++++++-
 38 files changed, 312 insertions(+), 174 deletions(-)
Signature · 1 line
2.34.1