media: ov2680: Add all controls required by libcamera
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 0 repliesNew
- v1 posting 2/25 patches 4 repliesSuperseded
- v1 posting 1/25 patches 10 repliesSuperseded
Changes in v2 from the cover letter
- Add error checking to __v4l2_ctrl_modify_range() and __v4l2_ctrl_s_ctrl() calls
- Set hblank read-only flag after checking hdl->error (avoids the need for an if (ctrls->hblank) check)
- Use hdl->error to error check v4l2_ctrl_new_fwnode_properties()
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | media: ov2680: Stop sending more data then requesteddrivers/ | +2 | 0 replies | |
| 2/5 | media: ov2680: Drop hts, vts ov2680_mode struct membersdrivers/ | +2 | 0 replies | |
| 3/5 | media: ov2680: Add vblank controldrivers/ | +49 | 0 replies | |
| 4/5 | media: ov2680: Add hblank controldrivers/ | +12 | 0 replies | |
| 5/5 | media: ov2680: Add camera orientation and sensor rotation controlsdrivers/ | +7 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Kieran Bingham |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/5] media: ov2680: Add all controls required by libcamera
Hi All,
Here is a resend of my patch-series to add all controls required by libcamera to the ov2680 driver.
Changes in v2:
- Add error checking to __v4l2_ctrl_modify_range() and __v4l2_ctrl_s_ctrl() calls
- Set hblank read-only flag after checking hdl->error (avoids the need for an if (ctrls->hblank) check)
- Use hdl->error to error check v4l2_ctrl_new_fwnode_properties()
This has been tested together with the atomisp using the simple pipelinehandler. This should also work in IPU3 based devices with an ov2680.
Note the vblank control new default value after a mode-set call has been chosen so as to preserve the old behavior of always running at 30 fps, so as to not change behavior for any existing use-cases.
Regards,
Hans
Hans de Goede (5):
media: ov2680: Stop sending more data then requested
media: ov2680: Drop hts, vts ov2680_mode struct members
media: ov2680: Add vblank control
media: ov2680: Add hblank control
media: ov2680: Add camera orientation and sensor rotation controls
drivers/media/i2c/ov2680.c | 90 ++++++++++++++++++++++++++++++-------- 1 file changed, 71 insertions(+), 19 deletions(-)
Signature · 1 line
2.44.0