nvme-fc: fix blktests nvme/041
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 17 repliesIn review
- v16 patches 2 repliesSuperseded
Changes in v2 from the cover letter
- renamed flag to connect_async, default false
- add info to commit message why nvme-fc is different
- merged connect_async with 'nvme-fc: wait for initial connect attempt to finish'
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | nvme-fc: rename free_ctrl callback to match name patterndrivers/ | +2 | 2 replies | |
| 2/5 | nvme-fc: do not retry when auth fails or connection is refuseddrivers/ | +2 | 8 replies | |
| 3/5 | nvme-fabrics: introduce ref counting for nvmf_ctrl_optionsdrivers/ drivers/ drivers/ +3 more | +73 | 4 replies | |
| 4/5 | nvme-fc: reorder ctrl ref counting and cleanup code pathdrivers/ | +32 | 0 replies | |
| 5/5 | nvme-fc: wait for initial connect attempt to finishdrivers/ drivers/ drivers/ | +44 | 1 reply |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig | Hannes Reinecke | Sagi Grimberg |
|---|---|---|---|
| 1/5 | R-b | R-b | R-b |
| 2/5 | R-b | ||
| 3/5 | R-b | ||
| 4/5 | |||
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/5] nvme-fc: fix blktests nvme/041
As suggested by Keith I've merged the new flag for nvme-fabrics with the last patch. I also added some information why nvme-fc is handling the initial connect attempt differently as requested by Christoph.
The new flag is called connect_async and the default is false/0. I've tested with a patched nvme-cli/libnvme version and all looks good. When this series is accepted I'll update nvme-cli/libnvme accordingly. Note, that even with an older nvme-cli the blktests (especially nvme/041) will pass with a newer kernel.
(nvme/048 is still fails but this is a different problem. On my TODO list)
changes:
v2:
- renamed flag to connect_async, default false
- add info to commit message why nvme-fc is different
- merged connect_async with 'nvme-fc: wait for initial connect attempt to finish'
v1:
- renamed 'nvme-fc: redesign locking and refcounting'
to 'nvme-fc: reorder ctrl ref counting and cleanup code path'
- testing with scsi/nvme dev_loss_tmo on real hw
- removed rport ref counting part
- collected RB tags
- https://lore.kernel.org/linux-nvme/[email protected]/
v0:
- initial version
- https://lore.kernel.org/linux-nvme/[email protected]/
Daniel Wagner (5):
nvme-fc: rename free_ctrl callback to match name pattern
nvme-fc: do not retry when auth fails or connection is refused
nvme-fabrics: introduce ref counting for nvmf_ctrl_options
nvme-fc: reorder ctrl ref counting and cleanup code path
nvme-fc: wait for initial connect attempt to finish
drivers/nvme/host/fabrics.c | 39 +++++++++- drivers/nvme/host/fabrics.h | 9 ++- drivers/nvme/host/fc.c | 145 +++++++++++++++++------------------- drivers/nvme/host/rdma.c | 18 +++-- drivers/nvme/host/tcp.c | 21 ++++-- drivers/nvme/target/loop.c | 19 +++-- 6 files changed, 152 insertions(+), 99 deletions(-)
Signature · 1 line
2.43.1