Skip to content

media: cadence,ti: CSI2RX Multistream Support

Jai Luthra linux-devicetree linux-media 2 versions – In review

Get series with b4
b4 am [email protected] change-id 20240221-multistream-fbba6ffe47a3

Versions newest first

  1. v2 Latest13 patches 33 repliesIn review
  2. v1 RFC21 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- Change the multi-camera capture architecture to be similar to that of Tomi's RPi5 FE series, where the driver will wait for userspace to start streaming on all "actively routed" video nodes before starting streaming on the source. This simplifies things a lot from the HW perspective, which might run into deadlocks due to a shared FIFO between multiple DMA channels.

- Drop a few fixes that were posted separately and are already merged
- Fix dtschema warnings reported by Rob on [02/13]
- Fix warnings for uninitialized used_vc variable in cdns-csi2rx.c
- Return -EBUSY if someone updates routes for j721e-csi2rx subdev while streaming
- Only allow single-streams to be routed to the source pads (linked to video nodes) of the j721e-csi2rx device
- Squash the patches marked "SQUASH" in the v1 RFC series

- Link to RFC (v1):
https://lore.kernel.org/r/[email protected]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13media: cadence: csi2rx: Support runtime PMdrivers/media/platform/cadence/cdns-csi2rx.c+42 -15 replies
2/13dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chansDocumentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml+36 -34 replies
3/13media: ti: j721e-csi2rx: separate out device and contextdrivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c+242 -1812 replies
4/13media: ti: j721e-csi2rx: prepare SHIM code for multiple contextsdrivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c+6 -61 reply
5/13media: ti: j721e-csi2rx: allocate DMA channel based on context indexdrivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c+3 -11 reply
6/13media: ti: j721e-csi2rx: add a subdev for the core devicedrivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c+212 -253 replies
7/13media: ti: j721e-csi2rx: get number of contexts from device treedrivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c+32 -122 replies
8/13media: cadence: csi2rx: add get_frame_desc wrapperdrivers/media/platform/cadence/cdns-csi2rx.c+24 -02 replies
9/13media: ti: j721e-csi2rx: add support for processing virtual channelsdrivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c+39 -03 replies
10/13media: cadence: csi2rx: Use new enable stream APIsdrivers/media/platform/cadence/cdns-csi2rx.c+16 -20 replies
11/13media: cadence: csi2rx: Enable multi-stream supportdrivers/media/platform/cadence/cdns-csi2rx.c+313 -944 replies
12/13media: ti: j721e-csi2rx: add multistream supportdrivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c+185 -461 reply
13/13media: ti: j721e-csi2rx: Submit all available buffersdrivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c+24 -191 reply

Reviews trailers per patch

5 of 13 patches have a Reviewed-by or Acked-by.

PatchTomi ValkeinenJacopo Mondi
1/13
2/13R-b
3/13
4/13R-b
5/13R-b
6/13
7/13
8/13R-b
9/13
10/13
11/13
12/13
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/13] media: cadence,ti: CSI2RX Multistream Support

This series adds multi-stream support for Cadence CSI2RX and TI CSI2RX Shim drivers.

PATCH 1: Runtime Power Management for Cadence CSI2RX
PATCH 2-7: Support multiple DMA contexts/video nodes in TI CSI2RX
PATCH 8-9: Use get_frame_desc to propagate virtual channel information
across Cadence and TI CSI-RX subdevs
PATCH 10-12: Use new multi-stream APIs across the drivers to support
multiplexed cameras from sources like UB960 (FPDLink)
PATCH 13: Optimize stream on by submitting all queued buffers to DMA

This applies on top of today's linux-next (next-20240626) (also tested rebase with media_stage.git master)

---
Changes in v2:

- Change the multi-camera capture architecture to be similar to that of Tomi's RPi5 FE series, where the driver will wait for userspace to start streaming on all "actively routed" video nodes before starting streaming on the source. This simplifies things a lot from the HW perspective, which might run into deadlocks due to a shared FIFO between multiple DMA channels.

- Drop a few fixes that were posted separately and are already merged
- Fix dtschema warnings reported by Rob on [02/13]
- Fix warnings for uninitialized used_vc variable in cdns-csi2rx.c
- Return -EBUSY if someone updates routes for j721e-csi2rx subdev while streaming
- Only allow single-streams to be routed to the source pads (linked to video nodes) of the j721e-csi2rx device
- Squash the patches marked "SQUASH" in the v1 RFC series

- Link to RFC (v1):
https://lore.kernel.org/r/[email protected]

---
Jai Luthra (8):
dt-bindings: media: ti,j721e-csi2rx-shim: Support 32 dma chans
media: ti: j721e-csi2rx: separate out device and context
media: ti: j721e-csi2rx: add a subdev for the core device
media: ti: j721e-csi2rx: add support for processing virtual channels
media: cadence: csi2rx: Use new enable stream APIs
media: cadence: csi2rx: Enable multi-stream support
media: ti: j721e-csi2rx: add multistream support
media: ti: j721e-csi2rx: Submit all available buffers

Jayshri Pawar (1):
media: cadence: csi2rx: Support runtime PM

Pratyush Yadav (4):
media: ti: j721e-csi2rx: prepare SHIM code for multiple contexts
media: ti: j721e-csi2rx: allocate DMA channel based on context index
media: ti: j721e-csi2rx: get number of contexts from device tree
media: cadence: csi2rx: add get_frame_desc wrapper

 .../bindings/media/ti,j721e-csi2rx-shim.yaml       |  39 +-
 drivers/media/platform/cadence/cdns-csi2rx.c       | 440 +++++++++--
 .../media/platform/ti/j721e-csi2rx/j721e-csi2rx.c  | 879 ++++++++++++++++-----
 3 files changed, 1071 insertions(+), 287 deletions(-)

---
base-commit: df9574a57d02b265322e77fb8628d4d33641dda9
change-id: 20240221-multistream-fbba6ffe47a3

Best regards,

Signature · 1 line
Jai Luthra <[email protected]>