Skip to content

arm64: EFI improvements

Andrew Jones kvm kvmarm 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest18 patches 7 repliesIn review
  2. v218 patches 22 repliesSuperseded
  3. v114 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Dropped fdt_valid
- Factored out qemu_args+=(-machine acpi=off) [Nikos]
- Ensure etext is page aligned
- Picked up Nikos's r-b's

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18runtime: Update MAX_SMP proberun_tests.sh scripts/runtime.bash+14 -101 reply
2/18runtime: Add yet another 'no kernel' error messagescripts/runtime.bash+1 -11 reply
3/18arm64: efi: Don't create dummy testarm/efi/run+8 -11 reply
4/18arm64: efi: Make running tests on EFI can be parallelarm/efi/run+9 -70 replies
5/18arm64: efi: Remove redundant dtb generationarm/efi/run+5 -90 replies
6/18arm64: efi: Move run code into a functionarm/efi/run arm/run+21 -160 replies
7/18arm64: efi: Remove EFI_USE_DTBarm/efi/run+1 -30 replies
8/18arm64: efi: Improve device tree discoverylib/efi.c lib/linux/efi.h+14 -73 replies
9/18lib/efi: Add support for loading the initrdlib/efi.c lib/linux/efi.h+92 -00 replies
10/18arm64: efi: Allow running tests directlyarm/efi/run arm/run configure+35 -40 replies
11/18arm/arm64: Factor out some initial setuplib/arm/setup.c+48 -340 replies
12/18arm/arm64: Factor out allocator init from mem_initlib/arm/setup.c+22 -240 replies
13/18arm64: Simplify efi_mem_initarm/efi/elf_aarch64_efi.lds lib/arm/setup.c+21 -250 replies
14/18arm64: Add memregions_efi_initlib/arm/setup.c lib/memregions.c lib/memregions.h+69 -640 replies
15/18arm64: efi: Don't map reserved regionslib/arm/mmu.c lib/arm/setup.c lib/memregions.c+11 -70 replies
16/18arm64: efi: Fix _start returns from failed _relocatearm/efi/crt0-efi-aarch64.S+13 -120 replies
17/18arm64: efi: Switch to our own stackarm/efi/crt0-efi-aarch64.S lib/arm/setup.c lib/memregions.c+17 -150 replies
18/18arm64: efi: Add gitlab CI.gitlab-ci.yml+30 -20 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchNikos NikolerisAndrew JonesShaoqin Huang
1/18R-b R-b
2/18R-b R-b
3/18R-b R-b
4/18R-b R-b
5/18R-b
6/18R-b
7/18R-b
8/18R-b
9/18R-b
10/18R-b
11/18R-b
12/18R-b
13/18R-b
14/18R-b
15/18R-b
16/18R-b
17/18R-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [kvm-unit-tests PATCH v3 00/18] arm64: EFI improvements

This series collects one fix ("Update MAX_SMP probe") with a bunch of improvements to the EFI setup code and run script. With the series applied one can add --enable-efi-direct when configuring and then run the EFI tests on QEMU much, much faster by using direct kernel boot for them (and environment variables will work too). The non- direct (original) way of running the EFI tests has also been sped up a bit by not running the dummy test and not generating the dtb twice. The cleanups in the setup code allow duplicated code to be removed (by sharing with the non-EFI setup code) and eventually for riscv to share some code too with the introduction of memregions_efi_init().

v3:
- Dropped fdt_valid
- Factored out qemu_args+=(-machine acpi=off) [Nikos]
- Ensure etext is page aligned
- Picked up Nikos's r-b's

v2:
- Add another improvement (patches 15-17), which is to stop mapping EFI regions which we consider reserved (including EFI_BOOT_SERVICES_DATA regions which requires moving the primary stack)
- Add EFI gitlab CI tests
- Fix one typo in configure help text

Andrew Jones (17):
runtime: Update MAX_SMP probe
runtime: Add yet another 'no kernel' error message
arm64: efi: Don't create dummy test
arm64: efi: Remove redundant dtb generation
arm64: efi: Move run code into a function
arm64: efi: Remove EFI_USE_DTB
arm64: efi: Improve device tree discovery lib/efi: Add support for loading the initrd
arm64: efi: Allow running tests directly arm/arm64: Factor out some initial setup arm/arm64: Factor out allocator init from mem_init
arm64: Simplify efi_mem_init
arm64: Add memregions_efi_init
arm64: efi: Don't map reserved regions
arm64: efi: Fix _start returns from failed _relocate
arm64: efi: Switch to our own stack
arm64: efi: Add gitlab CI

Shaoqin Huang (1):
arm64: efi: Make running tests on EFI can be parallel

 .gitlab-ci.yml              |  32 ++++-
 arm/efi/crt0-efi-aarch64.S  |  37 ++++--
 arm/efi/elf_aarch64_efi.lds |   1 +
 arm/efi/run                 |  64 ++++++----
 arm/run                     |   6 +-
 configure                   |  17 +++
 lib/arm/mmu.c               |   6 +-
 lib/arm/setup.c             | 227 ++++++++++++++----------------------
 lib/efi.c                   |  84 +++++++++++--
 lib/linux/efi.h             |  29 +++++
 lib/memregions.c            |  53 +++++++++
 lib/memregions.h            |   6 +
 run_tests.sh                |   5 +-
 scripts/runtime.bash        |  21 ++--
 14 files changed, 389 insertions(+), 199 deletions(-)
Signature · 1 line
2.44.0