Skip to content

replay: fixes and new test cases

Nicholas Piggin qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest10 patches 1 replyIn review
  2. v524 patches 12 repliesSuperseded
  3. v424 patches 18 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v39 patches6 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10scripts/replay-dump.py: Update to current rr record formatscripts/replay-dump.py+93 -340 replies
2/10scripts/replay-dump.py: rejig decoders in event number orderscripts/replay-dump.py+28 -280 replies
3/10tests/avocado: excercise scripts/replay-dump.py in replay testsscripts/replay-dump.py tests/avocado/replay_kernel.py tests/avocado/replay_linux.py+26 -30 replies
4/10replay: allow runstate shutdown->running when replaying traceinclude/sysemu/runstate.h replay/replay.c system/runstate.c+31 -30 replies
5/10Revert "replay: stop us hanging in rr_wait_io_event"accel/tcg/tcg-accel-ops-rr.c include/sysemu/replay.h replay/replay.c+1 -270 replies
6/10tests/avocado: replay_kernel.py add x86-64 q35 machine testtests/avocado/replay_kernel.py+17 -10 replies
7/10chardev: set record/replay on the base device of a muxed devicechardev/char.c+50 -210 replies
8/10virtio-net: Use replay_schedule_bh_event for bhs that affect machine statehw/net/virtio-net.c+6 -50 replies
9/10virtio-net: Use virtual time for RSC timershw/net/virtio-net.c+3 -30 replies
10/10savevm: Fix load_snapshot error path crashmigration/savevm.c+1 -00 replies

Reviews trailers per patch

9 of 10 patches have a Reviewed-by or Acked-by.

PatchAlex BennéePavel Dovgalyuk
1/10R-b
2/10R-b
3/10R-b R-b
4/10R-b R-b
5/10A-b
6/10R-b T-b
7/10R-b
8/10R-b R-b
9/10
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/10] replay: fixes and new test cases

Since v5, I cut down the series significantly to just the better reviewed parts, without adding new CI testing, since there are still be a few hiccups. aarch64 had some hangs Alex noticed, and x86_64 doesn't seem to be working anymore for me (with the big replay_linux.py test). But with this series, things are much closer, ppc64 does get through replay_linux.py (but requires some ppc specific fixes and the new test to be added, so I leave that out for now).

Hopefully we can get this minimal series in and in the next release I'll try to get something stable enough for CI so it doesn't keep breaking.

Thanks,
Nick

Nicholas Piggin (10):
scripts/replay-dump.py: Update to current rr record format scripts/replay-dump.py: rejig decoders in event number order tests/avocado: excercise scripts/replay-dump.py in replay tests
replay: allow runstate shutdown->running when replaying trace Revert "replay: stop us hanging in rr_wait_io_event" tests/avocado: replay_kernel.py add x86-64 q35 machine test
chardev: set record/replay on the base device of a muxed device
virtio-net: Use replay_schedule_bh_event for bhs that affect machine
state
virtio-net: Use virtual time for RSC timers
savevm: Fix load_snapshot error path crash

 include/sysemu/replay.h        |   5 -
 include/sysemu/runstate.h      |   1 +
 accel/tcg/tcg-accel-ops-rr.c   |   2 +-
 chardev/char.c                 |  71 +++++++++-----
 hw/net/virtio-net.c            |  17 ++--
 migration/savevm.c             |   1 +
 replay/replay.c                |  23 +----
 system/runstate.c              |  31 +++++-
 scripts/replay-dump.py         | 167 ++++++++++++++++++++++-----------
 tests/avocado/replay_kernel.py |  31 +++++-
 tests/avocado/replay_linux.py  |  10 ++
 11 files changed, 245 insertions(+), 114 deletions(-)
Signature · 1 line
2.45.2