Skip to content

Fix defines in rf69.h

Shahar Avidar linux-staging lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 1 replyIn review
  2. v15 patches 0 repliesSuperseded

v2->v1 from the cover letter

- Fix grammer in commit messages.
- Use units.h macro to define frequency.
- Reorder patches to ensure no conflicts.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5staging: pi433: Remove a duplicated FIFO_SIZE definedrivers/staging/pi433/rf69.c+0 -10 replies
2/5staging: pi433: Remove a duplicated F_OSC definedrivers/staging/pi433/rf69.h+0 -10 replies
3/5staging: pi433: Redefine F_OSC using units.h macrodrivers/staging/pi433/rf69.c+2 -10 replies
4/5staging: pi433: Remove the unused FREQUENCY definedrivers/staging/pi433/rf69.h+0 -20 replies
5/5staging: pi433: Move FIFO_THRESHOLD define to source filedrivers/staging/pi433/pi433_if.c drivers/staging/pi433/rf69.h+1 -10 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy Shevchenko
SeriesR-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] Fix defines in rf69.h

This patchset fixes several misuses of the define statement in rf69.h. Duplicted defines.
Define in header instead of source file.
Unused define.
Using units.h macro to define frequency.

v2->v1:
- Fix grammer in commit messages.
- Use units.h macro to define frequency.
- Reorder patches to ensure no conflicts.

Shahar Avidar (5):
staging: pi433: Remove a duplicated FIFO_SIZE define
staging: pi433: Remove a duplicated F_OSC define
staging: pi433: Redefine F_OSC using units.h macro
staging: pi433: Remove the unused FREQUENCY define
staging: pi433: Move FIFO_THRESHOLD define to source file

 drivers/staging/pi433/pi433_if.c | 1 +
 drivers/staging/pi433/rf69.c     | 4 ++--
 drivers/staging/pi433/rf69.h     | 4 ----
 3 files changed, 3 insertions(+), 6 deletions(-)

base-commit: 455c5e12a3b7d08c2ab47b7dd54944901c69cdcd

Signature · 1 line
2.34.1