Skip to content

KVM: arm64: Transition to a per-ITS translation cache

Oliver Upton kvm kvmarm 3 versions – Applied

Status from this message: Applied to next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest19 patches 8 repliesApplied
  2. v219 patches 10 repliesSuperseded
  3. v120 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Add lockdep assertion to kvm_vfio_create() (Sean)
- Address intermediate compilation issue in vgic_its_invalidate_cache() (Marc)
- Use a more compact cache index based on the DID/EID range of the ITS (Marc)
- Comment improvements (Marc)
- Avoid explicit acquisition of the translation cache's xa_lock() (Marc)
- Eliminate the need to disable IRQs to acquire the translation cache's xa_lock()
- Collapse internal helper into vgic_its_check_cache()

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/19KVM: Treat the device list as an rculistvirt/kvm/kvm_main.c virt/kvm/vfio.c+13 -31 reply
2/19KVM: arm64: vgic-its: Walk LPI xarray in its_sync_lpi_pending_table()arch/arm64/kvm/vgic/vgic-its.c+10 -170 replies
3/19KVM: arm64: vgic-its: Walk LPI xarray in vgic_its_invall()arch/arm64/kvm/vgic/vgic-its.c+6 -100 replies
4/19KVM: arm64: vgic-its: Walk LPI xarray in vgic_its_cmd_handle_movall()arch/arm64/kvm/vgic/vgic-its.c+4 -90 replies
5/19KVM: arm64: vgic-debug: Use an xarray mark for debug iteratorarch/arm64/kvm/vgic/vgic-debug.c arch/arm64/kvm/vgic/vgic-its.c arch/arm64/kvm/vgic/vgic.h +1 more+64 -256 replies
6/19KVM: arm64: vgic-its: Get rid of vgic_copy_lpi_list()arch/arm64/kvm/vgic/vgic-its.c arch/arm64/kvm/vgic/vgic.c arch/arm64/kvm/vgic/vgic.h +1 more+0 -510 replies
7/19KVM: arm64: vgic-its: Scope translation cache invalidations to an ITSarch/arm64/kvm/vgic/vgic-its.c arch/arm64/kvm/vgic/vgic-mmio-v3.c arch/arm64/kvm/vgic/vgic.h+36 -140 replies
8/19KVM: arm64: vgic-its: Maintain a translation cache per ITSarch/arm64/kvm/vgic/vgic-its.c include/kvm/arm_vgic.h+42 -10 replies
9/19KVM: arm64: vgic-its: Spin off helper for finding ITS by doorbell addrarch/arm64/kvm/vgic/vgic-its.c+21 -140 replies
10/19KVM: arm64: vgic-its: Use the per-ITS translation cache for injectionarch/arm64/kvm/vgic/vgic-its.c+17 -460 replies
11/19KVM: arm64: vgic-its: Rip out the global translation cachearch/arm64/kvm/vgic/vgic-init.c arch/arm64/kvm/vgic/vgic-its.c arch/arm64/kvm/vgic/vgic.h +1 more+4 -1290 replies
12/19KVM: arm64: vgic-its: Get rid of the lpi_list_lockarch/arm64/kvm/vgic/vgic-init.c arch/arm64/kvm/vgic/vgic-its.c arch/arm64/kvm/vgic/vgic.c +1 more+5 -100 replies
13/19KVM: selftests: Align with kernel's GIC definitionstools/testing/selftests/kvm/aarch64/vgic_irq.c tools/testing/selftests/kvm/include/aarch64/gic_v3.h tools/testing/selftests/kvm/lib/aarch64/gic_v3.c+568 -350 replies
14/19KVM: selftests: Standardise layout of GIC framestools/testing/selftests/kvm/aarch64/arch_timer.c tools/testing/selftests/kvm/aarch64/vgic_irq.c tools/testing/selftests/kvm/aarch64/vpmu_counter_access.c +7 more+62 -850 replies
15/19KVM: selftests: Add quadword MMIO accessorstools/testing/selftests/kvm/include/aarch64/processor.h+17 -00 replies
16/19KVM: selftests: Add a minimal library for interacting with an ITStools/testing/selftests/kvm/Makefile tools/testing/selftests/kvm/include/aarch64/gic.h tools/testing/selftests/kvm/include/aarch64/gic_v3_its.h +3 more+295 -10 replies
17/19KVM: selftests: Add helper for enabling LPIs on a redistributortools/testing/selftests/kvm/include/aarch64/gic.h tools/testing/selftests/kvm/lib/aarch64/gic_v3.c tools/testing/selftests/kvm/lib/aarch64/vgic.c+29 -00 replies
18/19KVM: selftests: Use MPIDR_HWID_BITMASK from cputype.htools/testing/selftests/kvm/aarch64/psci_test.c tools/testing/selftests/kvm/include/aarch64/processor.h+2 -20 replies
19/19KVM: selftests: Add stress test for LPI injectiontools/testing/selftests/kvm/Makefile tools/testing/selftests/kvm/aarch64/vgic_lpi_stress.c+411 -00 replies

Reviews trailers per patch

1 of 19 patches has a Reviewed-by or Acked-by.

PatchSean Christopherson
1/19R-b
2/19
3/19
4/19
5/19
6/19
7/19
8/19
9/19
10/19
11/19
12/19
13/19
14/19
15/19
16/19
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/19] KVM: arm64: Transition to a per-ITS translation cache

v2: https://lore.kernel.org/kvmarm/[email protected]/

v2 -> v3:
- Add lockdep assertion to kvm_vfio_create() (Sean)
- Address intermediate compilation issue in vgic_its_invalidate_cache() (Marc)
- Use a more compact cache index based on the DID/EID range of the ITS (Marc)
- Comment improvements (Marc)
- Avoid explicit acquisition of the translation cache's xa_lock() (Marc)
- Eliminate the need to disable IRQs to acquire the translation cache's xa_lock()
- Collapse internal helper into vgic_its_check_cache()

Oliver Upton (19):
KVM: Treat the device list as an rculist
KVM: arm64: vgic-its: Walk LPI xarray in its_sync_lpi_pending_table()
KVM: arm64: vgic-its: Walk LPI xarray in vgic_its_invall()
KVM: arm64: vgic-its: Walk LPI xarray in vgic_its_cmd_handle_movall()
KVM: arm64: vgic-debug: Use an xarray mark for debug iterator
KVM: arm64: vgic-its: Get rid of vgic_copy_lpi_list()
KVM: arm64: vgic-its: Scope translation cache invalidations to an ITS
KVM: arm64: vgic-its: Maintain a translation cache per ITS
KVM: arm64: vgic-its: Spin off helper for finding ITS by doorbell addr
KVM: arm64: vgic-its: Use the per-ITS translation cache for injection
KVM: arm64: vgic-its: Rip out the global translation cache
KVM: arm64: vgic-its: Get rid of the lpi_list_lock
KVM: selftests: Align with kernel's GIC definitions
KVM: selftests: Standardise layout of GIC frames
KVM: selftests: Add quadword MMIO accessors
KVM: selftests: Add a minimal library for interacting with an ITS
KVM: selftests: Add helper for enabling LPIs on a redistributor
KVM: selftests: Use MPIDR_HWID_BITMASK from cputype.h
KVM: selftests: Add stress test for LPI injection

 arch/arm64/kvm/vgic/vgic-debug.c              |  82 ++-
 arch/arm64/kvm/vgic/vgic-init.c               |   8 -
 arch/arm64/kvm/vgic/vgic-its.c                | 352 ++++-------
 arch/arm64/kvm/vgic/vgic-mmio-v3.c            |   2 +-
 arch/arm64/kvm/vgic/vgic.c                    |   6 +-
 arch/arm64/kvm/vgic/vgic.h                    |   6 +-
 include/kvm/arm_vgic.h                        |  13 +-
 tools/testing/selftests/kvm/Makefile          |   2 +
 .../selftests/kvm/aarch64/arch_timer.c        |   8 +-
 .../testing/selftests/kvm/aarch64/psci_test.c |   2 +
 .../testing/selftests/kvm/aarch64/vgic_irq.c  |  15 +-
 .../selftests/kvm/aarch64/vgic_lpi_stress.c   | 410 ++++++++++++
 .../kvm/aarch64/vpmu_counter_access.c         |   6 +-
 .../selftests/kvm/dirty_log_perf_test.c       |   5 +-
 .../selftests/kvm/include/aarch64/gic.h       |  21 +-
 .../selftests/kvm/include/aarch64/gic_v3.h    | 586 +++++++++++++++++-
 .../kvm/include/aarch64/gic_v3_its.h          |  19 +
 .../selftests/kvm/include/aarch64/processor.h |  19 +-
 .../selftests/kvm/include/aarch64/vgic.h      |   5 +-
 tools/testing/selftests/kvm/lib/aarch64/gic.c |  18 +-
 .../selftests/kvm/lib/aarch64/gic_private.h   |   4 +-
 .../selftests/kvm/lib/aarch64/gic_v3.c        |  99 +--
 .../selftests/kvm/lib/aarch64/gic_v3_its.c    | 248 ++++++++
 .../testing/selftests/kvm/lib/aarch64/vgic.c  |  38 +-
 virt/kvm/kvm_main.c                           |  14 +-
 virt/kvm/vfio.c                               |   2 +
 26 files changed, 1572 insertions(+), 418 deletions(-)
 create mode 100644 tools/testing/selftests/kvm/aarch64/vgic_lpi_stress.c
 create mode 100644 tools/testing/selftests/kvm/include/aarch64/gic_v3_its.h
 create mode 100644 tools/testing/selftests/kvm/lib/aarch64/gic_v3_its.c

base-commit: fec50db7033ea478773b159e0e2efb135270e3b7

Signature · 1 line
2.44.0.769.g3c40516874-goog