Skip to content

gpiolib: Align prototypes of *gpio_count() APIs

Andy Shevchenko linux-acpi linux-gpio lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2gpiolib-of: Make of_gpio_get_count() take firmware node as a parameterdrivers/gpio/gpiolib-of.c drivers/gpio/gpiolib-of.h drivers/gpio/gpiolib.c+10 -101 reply
2/2gpiolib-acpi: Make acpi_gpio_count() take firmware node as a parameterdrivers/gpio/gpiolib-acpi.c drivers/gpio/gpiolib-acpi.h drivers/gpio/gpiolib.c+9 -100 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLinus WalleijMika Westerberg
SeriesR-b
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] gpiolib: Align prototypes of *gpio_count() APIs

Two out of three GPIO count APIs take device pointer. OF case clearly does not need it as it immediately switches to device node inside, and ACPI abstracts that to struct acpi_device pointer. Unify all these by making them to take struct fwnode_handle pointer. This, in particular, will allow to create fwnode_gpio_count() API if needed. The need of that was discussed here [1].

Note, no functional changes intended.

In v2:
- fixed typo (Chris)
- added tag (Linus)

Andy Shevchenko (2):
gpiolib-of: Make of_gpio_get_count() take firmware node as a parameter
gpiolib-acpi: Make acpi_gpio_count() take firmware node as a parameter

 drivers/gpio/gpiolib-acpi.c | 13 ++++++-------
 drivers/gpio/gpiolib-acpi.h |  4 ++--
 drivers/gpio/gpiolib-of.c   | 13 ++++++-------
 drivers/gpio/gpiolib-of.h   |  5 +++--
 drivers/gpio/gpiolib.c      |  4 ++--
 5 files changed, 19 insertions(+), 20 deletions(-)
Signature · 1 line
2.43.0.rc1.1.gbec44491f096