Skip to content

Python generated Arm64 metrics

Ian Rogers linux-perf-users lkml 12 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 0 repliesNew
  2. v6 posting 2/23 patches 0 repliesSuperseded
  3. v6 posting 1/222 patches 4 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v5 posting 2/23 patches0 repliesSuperseded
v5 posting 1/222 patches0 repliesSuperseded
v4 posting 2/22 patches2 repliesSuperseded
v4 posting 1/222 patches19 repliesSuperseded
v3 posting 2/220 patches0 repliesSuperseded
v3 posting 1/22 patches0 repliesSuperseded
v2 posting 2/220 patches0 repliesSuperseded
v2 posting 1/22 patches0 repliesSuperseded
v120 patches18 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3perf jevents: Add collection of topdown like metrics for arm64tools/perf/pmu-events/arm64_metrics.py+144 -40 replies
2/3perf jevents: Add cycles breakdown metric for arm64/AMD/Inteltools/perf/pmu-events/Build tools/perf/pmu-events/amd_metrics.py tools/perf/pmu-events/arm64_metrics.py +2 more+26 -10 replies
3/3perf jevents: Validate that all names given an Eventtools/perf/pmu-events/metric.py+36 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [PATCH v7 0/3] Python generated Arm64 metrics

Generate two sets of additional metrics for Arm64, where the topdown set decomposes yet further. The metrcs primarily use json events, where the json contains architecture standard events. Not all events are in the json, such as for a53 where the events are in sysfs. Workaround this by adding the sysfs events to the metrics but longer-term such events should be added to the json.

The patches should be applied on top of:
https://lore.kernel.org/lkml/[email protected]/

v7. Switch a use of cycles to cpu-cycles due to ARM having too many
cycles events.

v6. Fix issue with '\-' escape not being '\\-' (reported-by Sandipan
Das <[email protected]>) which didn't alter the generated json.
https://lore.kernel.org/lkml/[email protected]/

v5. Rebase. Address review comments from Leo Yan
<[email protected]>. Prefix all metric names with lpm_ (short for Linux Perf Metric) so that python generated metrics are clearly namespaced. Use cpu-cycles rather than cycles legacy event for cycles metrics to avoid confusion with ARM PMUs. Add patch that checks events to ensure all possible event names are present in at least one json file.
https://lore.kernel.org/lkml/[email protected]/

v4. Tweak to build dependencies and rebase.

    https://lore.kernel.org/lkml/[email protected]/

v3. Some minor code cleanup changes.

    https://lore.kernel.org/lkml/[email protected]/

v2. The cycles metrics are now made common and shared with AMD and
Intel, suggested by Kan Liang <[email protected]>. This assumes these patches come after the AMD and Intel sets.
https://lore.kernel.org/lkml/[email protected]/

v1. https://lore.kernel.org/lkml/[email protected]/

Ian Rogers (3):
perf jevents: Add collection of topdown like metrics for arm64 perf jevents: Add cycles breakdown metric for arm64/AMD/Intel perf jevents: Validate that all names given an Event

 tools/perf/pmu-events/Build             |   2 +-
 tools/perf/pmu-events/amd_metrics.py    |   3 +
 tools/perf/pmu-events/arm64_metrics.py  | 150 +++++++++++++++++++++++-
 tools/perf/pmu-events/common_metrics.py |  18 +++
 tools/perf/pmu-events/intel_metrics.py  |   2 +
 tools/perf/pmu-events/metric.py         |  36 ++++++
 6 files changed, 206 insertions(+), 5 deletions(-)
 create mode 100644 tools/perf/pmu-events/common_metrics.py
Signature · 1 line
2.51.0.355.g5224444f11-goog