soc: qcom: add in-kernel pd-mapper implementation
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected] change-id 20240301-qcom-pd-mapper-e12d622d4ad0Versions newest first
- v9 Latest5 patches 3 repliesApplied
- v85 patches 8 repliesSuperseded
- v76 patches 11 repliesSuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 6 patches | 2 replies | Superseded | |
| v5 | 6 patches | 11 replies | Superseded | |
| v4 | 7 patches | 18 replies | Superseded | |
| v3 RFC | 7 patches | 3 replies | Superseded | |
| v2 RFC | 5 patches | 2 replies | Superseded inferred link | |
| v1 RFC | 5 patches | 3 replies | Superseded |
Changes in v9 from the cover letter
- Adjust locking in pdr_get_domain_list(), releasing the mutex right
after qmi_send_request() (Chris Lew)
- Link to v8: https://lore.kernel.org/r/[email protected]
Patches in v9 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | soc: qcom: pdr: protect locator_addr with the main mutexdrivers/ | +4 | 1 reply | |
| 2/5 | soc: qcom: pdr: fix parsing of domains listsdrivers/ | +1 | 0 replies | |
| 3/5 | soc: qcom: pdr: extract PDR message marshalling datadrivers/ drivers/ drivers/ +1 more | +334 | 0 replies | |
| 4/5 | soc: qcom: add pd-mapper implementationdrivers/ drivers/ drivers/ +2 more | +736 | 0 replies | |
| 5/5 | remoteproc: qcom: enable in-kernel PD mapperdrivers/ drivers/ drivers/ +3 more | +109 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Neil Armstrong | Steev Klimaszewski | Alexey Minnekhanov | Chris Lew | Bryan O'Donoghue |
|---|---|---|---|---|---|
| 1/5 | T-b | T-b | T-b | R-b | |
| 2/5 | T-b | T-b | T-b | R-b | |
| 3/5 | T-b | T-b | T-b | R-b | |
| 4/5 | T-b | T-b | T-b | R-b | |
| 5/5 | T-b | T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v9 0/5] soc: qcom: add in-kernel pd-mapper implementation
Protection domain mapper is a QMI service providing mapping between 'protection domains' and services supported / allowed in these domains. For example such mapping is required for loading of the WiFi firmware or for properly starting up the UCSI / altmode / battery manager support.
The existing userspace implementation has several issue. It doesn't play well with CONFIG_EXTRA_FIRMWARE, it doesn't reread the JSON files if the firmware location is changed (or if the firmware was not available at the time pd-mapper was started but the corresponding directory is mounted later), etc.
However this configuration is largely static and common between different platforms. Provide in-kernel service implementing static per-platform data.
---
Changes in v9:
- Adjust locking in pdr_get_domain_list(), releasing the mutex right
after qmi_send_request() (Chris Lew)
- Link to v8: https://lore.kernel.org/r/[email protected]
Changes in v8:
- Reworked pd-mapper to register as an rproc_subdev / auxdev
- Dropped Tested-by from Steev and Alexey from the last patch since the implementation was changed significantly.
- Add sensors, cdsp and mpss_root domains to 660 config (Alexey
Minnekhanov)
- Added platform entry for sm4250 (used for qrb4210 / RB2)
- Added locking to the pdr_get_domain_list() (Chris Lew)
- Remove the call to qmi_del_server() and corresponding API (Chris Lew)
- In qmi_handle_init() changed 1024 to a defined constant (Chris Lew)
- Link to v7: https://lore.kernel.org/r/[email protected]
Changes in v7:
- Fixed modular build (Steev)
- Link to v6: https://lore.kernel.org/r/[email protected]
Changes in v6:
- Reworked mutex to fix lockdep issue on deregistration
- Fixed dependencies between PD-mapper and remoteproc to fix modular
builds (Krzysztof)
- Added EXPORT_SYMBOL_GPL to fix modular builds (Krzysztof)
- Fixed kerneldocs (Krzysztof)
- Removed extra pr_debug messages (Krzysztof)
- Fixed wcss build (Krzysztof)
- Added platforms which do not require protection domain mapping to
silence the notice on those platforms
- Link to v5: https://lore.kernel.org/r/[email protected]
Changes in v5:
- pdr: drop lock in pdr_register_listener, list_lock is already held (Chris Lew)
- pd_mapper: reworked to provide static configuration per platform
(Bjorn)
- Link to v4: https://lore.kernel.org/r/[email protected]
Changes in v4:
- Fixed missing chunk, reenabled kfree in qmi_del_server (Konrad)
- Added configuration for sm6350 (Thanks to Luca)
- Removed RFC tag (Konrad)
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in RFC v3:
- Send start / stop notifications when PD-mapper domain list is changed
- Reworked the way PD-mapper treats protection domains, register all of
them in a single batch
- Added SC7180 domains configuration based on TCL Book 14 GO
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in RFC v2:
- Swapped num_domains / domains (Konrad)
- Fixed an issue with battery not working on sc8280xp
- Added missing configuration for QCS404
To: Bjorn Andersson <[email protected]>
To: Konrad Dybcio <[email protected]>
To: Sibi Sankar <[email protected]>
To: Mathieu Poirier <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Dmitry Baryshkov (5):
soc: qcom: pdr: protect locator_addr with the main mutex
soc: qcom: pdr: fix parsing of domains lists
soc: qcom: pdr: extract PDR message marshalling data
soc: qcom: add pd-mapper implementation
remoteproc: qcom: enable in-kernel PD mapper
drivers/remoteproc/qcom_common.c | 87 +++++ drivers/remoteproc/qcom_common.h | 10 + drivers/remoteproc/qcom_q6v5_adsp.c | 3 + drivers/remoteproc/qcom_q6v5_mss.c | 3 + drivers/remoteproc/qcom_q6v5_pas.c | 3 + drivers/remoteproc/qcom_q6v5_wcss.c | 3 + drivers/soc/qcom/Kconfig | 15 + drivers/soc/qcom/Makefile | 2 + drivers/soc/qcom/pdr_interface.c | 8 +- drivers/soc/qcom/pdr_internal.h | 318 ++--------------- drivers/soc/qcom/qcom_pd_mapper.c | 676 ++++++++++++++++++++++++++++++++++++ drivers/soc/qcom/qcom_pdr_msg.c | 353 +++++++++++++++++++ 12 files changed, 1183 insertions(+), 298 deletions(-)
---
base-commit: 2102cb0d050d34d50b9642a3a50861787527e922
change-id: 20240301-qcom-pd-mapper-e12d622d4ad0
Best regards,
Signature · 1 line
Dmitry Baryshkov <[email protected]>