Skip to content

nvme: fixes for authentication errors

Hannes Reinecke linux-nvme 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4nvme: authentication error are always non-retryabledrivers/nvme/host/core.c drivers/nvme/host/fabrics.c drivers/nvme/host/nvme.h+21 -165 replies
2/4nvmet: lock config semaphore when accessing DH-HMAC-CHAP keydrivers/nvme/target/auth.c drivers/nvme/target/configfs.c+19 -52 replies
3/4nvmet: return DHCHAP status codes from nvmet_setup_auth()drivers/nvme/target/auth.c drivers/nvme/target/fabrics-cmd-auth.c+13 -154 replies
4/4nvmet-loop: do not call nvme_ctrl_put() after nvme_ctrl_uninit()drivers/nvme/target/loop.c+0 -12 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaniel WagnerChristoph HellwigChaitanya KulkarniSagi Grimberg
SeriesT-b R-b R-b
1/4
2/4R-b R-b
3/4R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] nvme: fixes for authentication errors

Hi all,

here's a set of fixes we've encountered during blktest runs. Turns out that any authentication error we're generating internally a in fact non-retryable, so we should map them onto the appropriate NVMe status.
That caused some fallout on the target side, which gets fixed with the remainder of this patchset.

As usual, comments and reviews are welcome.

Hannes Reinecke (4):
nvme: authentication error are always non-retryable
nvmet: lock config semaphore when accessing DH-HMAC-CHAP key
nvmet: return DHCHAP status codes from nvmet_setup_auth()
nvmet-loop: do not call nvme_ctrl_put() after nvme_ctrl_uninit()

 drivers/nvme/host/core.c               |  6 +++---
 drivers/nvme/host/fabrics.c            | 29 +++++++++++++++-----------
 drivers/nvme/host/nvme.h               |  2 +-
 drivers/nvme/target/auth.c             | 19 ++++++++---------
 drivers/nvme/target/configfs.c         | 22 ++++++++++++++-----
 drivers/nvme/target/fabrics-cmd-auth.c | 11 +++++-----
 drivers/nvme/target/loop.c             |  1 -
 7 files changed, 53 insertions(+), 37 deletions(-)
Signature · 1 line
2.35.3