nvme: fixes for authentication errors
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | nvme: authentication error are always non-retryabledrivers/ drivers/ drivers/ | +21 | 5 replies | |
| 2/4 | nvmet: lock config semaphore when accessing DH-HMAC-CHAP keydrivers/ drivers/ | +19 | 2 replies | |
| 3/4 | nvmet: return DHCHAP status codes from nvmet_setup_auth()drivers/ drivers/ | +13 | 4 replies | |
| 4/4 | nvmet-loop: do not call nvme_ctrl_put() after nvme_ctrl_uninit()drivers/ | +0 | 2 replies |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Daniel Wagner | Christoph Hellwig | Chaitanya Kulkarni | Sagi Grimberg |
|---|---|---|---|---|
| Series | T-b R-b | R-b | ||
| 1/4 | ||||
| 2/4 | R-b | R-b | ||
| 3/4 | R-b | |||
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH 0/4] nvme: fixes for authentication errors
Hi all,
here's a set of fixes we've encountered during blktest runs. Turns out that any authentication error we're generating internally a in fact non-retryable, so we should map them onto the appropriate NVMe status.
That caused some fallout on the target side, which gets fixed with the remainder of this patchset.
As usual, comments and reviews are welcome.
Hannes Reinecke (4):
nvme: authentication error are always non-retryable
nvmet: lock config semaphore when accessing DH-HMAC-CHAP key
nvmet: return DHCHAP status codes from nvmet_setup_auth()
nvmet-loop: do not call nvme_ctrl_put() after nvme_ctrl_uninit()
drivers/nvme/host/core.c | 6 +++--- drivers/nvme/host/fabrics.c | 29 +++++++++++++++----------- drivers/nvme/host/nvme.h | 2 +- drivers/nvme/target/auth.c | 19 ++++++++--------- drivers/nvme/target/configfs.c | 22 ++++++++++++++----- drivers/nvme/target/fabrics-cmd-auth.c | 11 +++++----- drivers/nvme/target/loop.c | 1 - 7 files changed, 53 insertions(+), 37 deletions(-)
Signature · 1 line
2.35.3