nvme-fabrics: short-circuit connect retries
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest5 patches 3 repliesIn review
- v65 patches 3 repliesSuperseded
- v56 patches 27 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 5 patches | 10 replies | Superseded | |
| v3 | 2 patches | 10 replies | Superseded | |
| v2 | 2 patches | 3 replies | Superseded |
Changes in v7 from the cover letter
- updated commit message patch #3
- split last patch so that only the DNR checks are added first and then the auth reconnect failure test
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | nvmet: lock config semaphore when accessing DH-HMAC-CHAP keydrivers/ drivers/ | +19 | 0 replies | |
| 2/5 | nvmet: return DHCHAP status codes from nvmet_setup_auth()drivers/ drivers/ drivers/ +1 more | +43 | 1 reply | |
| 3/5 | nvme: return kernel error codes for admin queue connectdrivers/ drivers/ drivers/ | +17 | 0 replies | |
| 4/5 | nvme-fabrics: short-circuit reconnect retriesdrivers/ drivers/ drivers/ +2 more | +41 | 0 replies | |
| 5/5 | nvme: do not retry authentication failuresdrivers/ drivers/ | +9 | 1 reply |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Sagi Grimberg | Christoph Hellwig |
|---|---|---|
| 1/5 | R-b | R-b |
| 2/5 | R-b R-b | |
| 3/5 | R-b | R-b |
| 4/5 | ||
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 0/5] nvme-fabrics: short-circuit connect retries
I've splitted the last patch into the hopefully non controversial part 'do not retry when DNR is set' and the 'don't retry auth failures'. I hope we can get at least the first few patches in and have a lively discussion on the final patch at LSF.
changes:
v7:
- updated commit message patch #3
- split last patch so that only the DNR checks are added first and then the auth reconnect failure test
v6:
- reorder series
- extended nvmf_should_reconnect
- added auth retry logic
- https://lore.kernel.org/linux-nvme/[email protected]/
v5:
- nvme: do not mix kernel error code with nvme status
- nvmet: separate nvme status from dhchap status
- https://lore.kernel.org/linux-nvme/[email protected]/
v4:
- rebased
- added 'nvme: fixes for authentication errors' series
- https://lore.kernel.org/all/[email protected]/
v3:
- added my SOB tag
- fixed indention
- https://lore.kernel.org/linux-nvme/[email protected]/
v2:
- refresh/rebase on current head
- extended blktests (nvme/045) to cover this case
(see separate post)
- https://lore.kernel.org/linux-nvme/[email protected]/
v1:
- initial version
- https://lore.kernel.org/linux-nvme/[email protected]/
Daniel Wagner (1):
nvme: do not retry authentication failures
Hannes Reinecke (4):
nvmet: lock config semaphore when accessing DH-HMAC-CHAP key
nvmet: return DHCHAP status codes from nvmet_setup_auth()
nvme: return kernel error codes for admin queue connect
nvme-fabrics: short-circuit reconnect retries
drivers/nvme/host/auth.c | 6 +-- drivers/nvme/host/core.c | 6 +-- drivers/nvme/host/fabrics.c | 51 ++++++++++++++++---------- drivers/nvme/host/fabrics.h | 2 +- drivers/nvme/host/fc.c | 4 +- drivers/nvme/host/nvme.h | 2 +- drivers/nvme/host/rdma.c | 19 ++++++---- drivers/nvme/host/tcp.c | 22 +++++++---- drivers/nvme/target/auth.c | 22 +++++------ drivers/nvme/target/configfs.c | 22 ++++++++--- drivers/nvme/target/fabrics-cmd-auth.c | 49 +++++++++++++------------ drivers/nvme/target/fabrics-cmd.c | 11 +++--- drivers/nvme/target/nvmet.h | 8 ++-- 13 files changed, 129 insertions(+), 95 deletions(-)
Signature · 1 line
2.44.0