Skip to content

drm/xe: Reduce GGTT display pinning latency.

Maarten Lankhorst intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fix "drm/xe: Cleanup some layering in GGTT"drivers/gpu/drm/xe/xe_ggtt.c+1 -22 replies
2/4drm/xe: Do not grab forcewakes when issuing GGTT TLB invalidation via GuCdrivers/gpu/drm/xe/xe_ggtt.c drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c+2 -73 replies
3/4drm/xe: Do not perform GuC TLB invalidation for display GGTTdrivers/gpu/drm/xe/display/xe_fb_pin.c drivers/gpu/drm/xe/display/xe_plane_initial.c drivers/gpu/drm/xe/xe_bo.h +2 more+24 -122 replies
4/4drm/xe: Move xe_ggtt_invalidate out from ggtt->lockdrivers/gpu/drm/xe/display/xe_fb_pin.c drivers/gpu/drm/xe/xe_bo_evict.c drivers/gpu/drm/xe/xe_ggtt.c+9 -61 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchRodrigo ViviMatthew Brost
1/4R-b
2/4R-b
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] drm/xe: Reduce GGTT display pinning latency.

Testing page flips I noticed 3 pain points in the GGTT code:
- Unnecessary taking force wakes (Brosts fix).
- display doesn't use GuC, so GuC invalidation can (hopefully) be skipped, saving 1 ms of latency.
- GuC invalidation should not be done with GGTT lock held, as it can be done at any time before the function returns.

This patch series solve those issues.

There are 3 potential optimizations untouched, but those don't touch GGTT invalidation:
- In the case of pinning same FB, re-use xe_vma instead with refcounting, instead of allocating a new one.
- Preallocate the DPT bo when creating the framebuffer, to remove allocation latency in the pinning path.
- Attempt if write-combined GGTT PTE updates work again on newer platforms, and change writeq to writeq_relaxed, add flush at end.

Maarten Lankhorst (4):
fix "drm/xe: Cleanup some layering in GGTT"
drm/xe: Do not grab forcewakes when issuing GGTT TLB invalidation via
GuC
drm/xe: Do not perform GuC TLB invalidation for display GGTT drm/xe: Move xe_ggtt_invalidate out from ggtt->lock

 drivers/gpu/drm/xe/display/xe_fb_pin.c        | 10 ++++--
 drivers/gpu/drm/xe/display/xe_plane_initial.c |  3 +-
 drivers/gpu/drm/xe/xe_bo.h                    |  2 ++
 drivers/gpu/drm/xe/xe_bo_evict.c              |  5 +++
 drivers/gpu/drm/xe/xe_ggtt.c                  | 31 ++++++++-----------
 drivers/gpu/drm/xe/xe_ggtt.h                  |  4 +--
 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c   |  2 ++
 7 files changed, 33 insertions(+), 24 deletions(-)
Signature · 1 line
2.43.0