drm/xe: Reduce GGTT display pinning latency.
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | fix "drm/xe: Cleanup some layering in GGTT"drivers/ | +1 | 2 replies | |
| 2/4 | drm/xe: Do not grab forcewakes when issuing GGTT TLB invalidation via GuCdrivers/ drivers/ | +2 | 3 replies | |
| 3/4 | drm/xe: Do not perform GuC TLB invalidation for display GGTTdrivers/ drivers/ drivers/ +2 more | +24 | 2 replies | |
| 4/4 | drm/xe: Move xe_ggtt_invalidate out from ggtt->lockdrivers/ drivers/ drivers/ | +9 | 1 reply |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Rodrigo Vivi | Matthew Brost |
|---|---|---|
| 1/4 | R-b | |
| 2/4 | R-b | |
| 3/4 | ||
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] drm/xe: Reduce GGTT display pinning latency.
Testing page flips I noticed 3 pain points in the GGTT code:
- Unnecessary taking force wakes (Brosts fix).
- display doesn't use GuC, so GuC invalidation can (hopefully) be skipped, saving 1 ms of latency.
- GuC invalidation should not be done with GGTT lock held, as it can be done at any time before the function returns.
This patch series solve those issues.
There are 3 potential optimizations untouched, but those don't touch GGTT invalidation:
- In the case of pinning same FB, re-use xe_vma instead with refcounting, instead of allocating a new one.
- Preallocate the DPT bo when creating the framebuffer, to remove allocation latency in the pinning path.
- Attempt if write-combined GGTT PTE updates work again on newer platforms, and change writeq to writeq_relaxed, add flush at end.
Maarten Lankhorst (4):
fix "drm/xe: Cleanup some layering in GGTT"
drm/xe: Do not grab forcewakes when issuing GGTT TLB invalidation via
GuC
drm/xe: Do not perform GuC TLB invalidation for display GGTT drm/xe: Move xe_ggtt_invalidate out from ggtt->lock
drivers/gpu/drm/xe/display/xe_fb_pin.c | 10 ++++-- drivers/gpu/drm/xe/display/xe_plane_initial.c | 3 +- drivers/gpu/drm/xe/xe_bo.h | 2 ++ drivers/gpu/drm/xe/xe_bo_evict.c | 5 +++ drivers/gpu/drm/xe/xe_ggtt.c | 31 ++++++++----------- drivers/gpu/drm/xe/xe_ggtt.h | 4 +-- drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 2 ++ 7 files changed, 33 insertions(+), 24 deletions(-)
Signature · 1 line
2.43.0