Skip to content

fstests: fix io_uring testing

Zorro Lang fstests io-uring 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v13 patches 11 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fsstress: check io_uring_queue_init errno properlyltp/fsstress.c+11 -70 replies
2/3fsstress: bypass io_uring testing if io_uring_queue_init returns EPERMltp/fsstress.c+14 -20 replies
3/3common/rc: notrun if io_uring is disabled by sysctlREADME common/rc src/feature.c+28 -71 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongJeff Moyer
1/3R-b R-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] fstests: fix io_uring testing

[PATCH 1/3]
According to the manual of io_uring_queue_init, it doesn't set errno but return the -errno on failure. So we should check the return value of io_uring_queue_init, to make sure if the io_uring is supported by kernel. We've left this problem in xfstests/ltp/fsstress.c long time.

V2 replace "if()...else..." with "switch()..."

[PATCH 2/3]
And besides kernel build without CONFIG_IO_URING, a system can disable the io_uring supporting manually, by set sysctl kernel.io_uring_disabled=2. The former cause io_uring_queue_init return ENOSYS, but the latter will return EPERM. So I let fsstress to deal with both situations.

V2 follows the "switch()..." format of patch 1/3

[PATCH 3/3]
This patch is re-written totally, and no any RVB.
This v2 decides to notrun if sysctl kernel.io_uring_disabled is 2. Then change README to clarify how to make sure io_uring testing to be run.

Thanks,
Zorro