selftests/resctrl: resctrl_val() related cleanups & improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest16 patches 3 repliesIn review
- v616 patches 3 repliesSuperseded
- v516 patches 7 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 posting 2/2 | 16 patches | 27 replies | Superseded | |
| v4 posting 1/2 | 0 of 16 patches | 0 replies | Superseded | |
| v3 | 16 patches | 7 replies | Superseded | |
| v2 | 13 patches | 20 replies | Superseded | |
| v1 | 13 patches | 0 replies | Superseded |
Changes in v7 from the cover letter
- Truly use "bound to", not bounded to.
- Fix separator to use 3 dashes
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | selftests/resctrl: Fix closing IMC fds on error and open-code R+W instead of loopstools/ | +36 | 0 replies | |
| 2/16 | selftests/resctrl: Calculate resctrl FS derived mem bw over sleep(1) onlytools/ | +91 | 0 replies | |
| 3/16 | selftests/resctrl: Make "bandwidth" consistent in comments & printstools/ tools/ | +8 | 0 replies | |
| 4/16 | selftests/resctrl: Consolidate get_domain_id() into resctrl_val()tools/ | +13 | 0 replies | |
| 5/16 | selftests/resctrl: Use correct type for pidstools/ tools/ tools/ +1 more | +12 | 0 replies | |
| 6/16 | selftests/resctrl: Cleanup bm_pid and ppid usage & limit scopetools/ tools/ | +15 | 0 replies | |
| 7/16 | selftests/resctrl: Rename measure_vals() to measure_mem_bw_vals() & documenttools/ | +8 | 0 replies | |
| 8/16 | selftests/resctrl: Simplify mem bandwidth file code for MBA & MBM teststools/ tools/ | +4 | 0 replies | |
| 9/16 | selftests/resctrl: Add ->measure() callback to resctrl_val_paramtools/ tools/ tools/ +2 more | +35 | 0 replies | |
| 10/16 | selftests/resctrl: Add ->init() callback into resctrl_val_paramtools/ tools/ tools/ +2 more | +60 | 0 replies | |
| 11/16 | selftests/resctrl: Simplify bandwidth report type handlingtools/ tools/ tools/ +2 more | +20 | 0 replies | |
| 12/16 | selftests/resctrl: Make some strings passed to resctrlfs functions consttools/ tools/ | +8 | 0 replies | |
| 13/16 | selftests/resctrl: Convert ctrlgrp & mongrp to pointerstools/ tools/ | +9 | 0 replies | |
| 14/16 | selftests/resctrl: Remove mongrp from MBA testtools/ | +0 | 0 replies | |
| 15/16 | selftests/resctrl: Remove mongrp from CMT testtools/ | +2 | 0 replies | |
| 16/16 | selftests/resctrl: Remove test name comparing from write_bm_pid_to_resctrl()tools/ tools/ tools/ +4 more | +17 | 0 replies |
Reviews trailers per patch
All 16 patches have a Reviewed-by or Acked-by.
| Patch | Babu Moger | Reinette Chatre |
|---|---|---|
| 1/16 | T-b | R-b |
| 2/16 | T-b | R-b |
| 3/16 | T-b | R-b |
| 4/16 | T-b | R-b |
| 5/16 | T-b | R-b |
| 6/16 | T-b | R-b |
| 7/16 | T-b | R-b |
| 8/16 | T-b | R-b |
| 9/16 | T-b | R-b |
| 10/16 | T-b | R-b |
| 11/16 | T-b | R-b |
| 12/16 | T-b | R-b |
| 13/16 | T-b | R-b |
| 14/16 | T-b | R-b |
| 15/16 | T-b | R-b |
| 16/16 | T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 00/16] selftests/resctrl: resctrl_val() related cleanups & improvements
Hi all,
This series does a number of cleanups into resctrl_val() and generalizes it by removing test name specific handling from the function.
v7:
- Truly use "bound to", not bounded to.
- Fix separator to use 3 dashes
v6:
- Adjust closing/rollback of the IMC perf
- Move the comment in measure_vals() to function level
- Capitalize MBM
- binded to -> bound to
- Language tweak into kerneldoc
- Removed stale paragraph from commit message
v5:
- Open mem bw file only once and use rewind().
- Add \n to mem bw file read to allow reading fresh values from the file.
- Return 0 if create_grp() is given NULL grp_name (matches the original behavior). Mention this in function's kerneldoc.
- Cast pid_t to int before printing with %d.
- Caps/typo fixes to kerneldoc and commit messages.
- Use imperative tone in commit messages and improve them based on points that came up during review.
v4:
- Merged close fix into IMC READ+WRITE rework patch
- Add loop to reset imc_counters_config fds to -1 to be able know which need closing
- Introduce perf_close_imc_mem_bw() to close fds
- Open resctrl mem bw file (twice) beforehand to avoid opening it during the test
- Remove MBM .mongrp setup
- Remove mongrp from CMT test
v3:
- Rename init functions to <testname>_init()
- Replace for loops with READ+WRITE statements for clarity
- Don't drop Return: entry from perf_open_imc_mem_bw() func comment
- New patch: Fix closing of IMC fds in case of error
- New patch: Make "bandwidth" consistent in comments & prints
- New patch: Simplify mem bandwidth file code
- Remove wrong comment
- Changed grp_name check to return -1 on fail (internal sanity check)
v2:
- Resolved conflicts with kselftest/next
- Spaces -> tabs correction
Ilpo Järvinen (16):
selftests/resctrl: Fix closing IMC fds on error and open-code R+W
instead of loops
selftests/resctrl: Calculate resctrl FS derived mem bw over sleep(1)
only
selftests/resctrl: Make "bandwidth" consistent in comments & prints selftests/resctrl: Consolidate get_domain_id() into resctrl_val() selftests/resctrl: Use correct type for pids selftests/resctrl: Cleanup bm_pid and ppid usage & limit scope selftests/resctrl: Rename measure_vals() to measure_mem_bw_vals() &
document
selftests/resctrl: Simplify mem bandwidth file code for MBA & MBM
tests
selftests/resctrl: Add ->measure() callback to resctrl_val_param selftests/resctrl: Add ->init() callback into resctrl_val_param selftests/resctrl: Simplify bandwidth report type handling selftests/resctrl: Make some strings passed to resctrlfs functions
const
selftests/resctrl: Convert ctrlgrp & mongrp to pointers selftests/resctrl: Remove mongrp from MBA test selftests/resctrl: Remove mongrp from CMT test selftests/resctrl: Remove test name comparing from
write_bm_pid_to_resctrl()
tools/testing/selftests/resctrl/cache.c | 10 +- tools/testing/selftests/resctrl/cat_test.c | 5 +- tools/testing/selftests/resctrl/cmt_test.c | 22 +- tools/testing/selftests/resctrl/mba_test.c | 26 +- tools/testing/selftests/resctrl/mbm_test.c | 26 +- tools/testing/selftests/resctrl/resctrl.h | 49 ++- tools/testing/selftests/resctrl/resctrl_val.c | 371 ++++++++---------- tools/testing/selftests/resctrl/resctrlfs.c | 67 ++-- 8 files changed, 291 insertions(+), 285 deletions(-)
Signature · 1 line
2.39.2