Skip to content

selftests/resctrl: resctrl_val() related cleanups & improvements

Ilpo Järvinen linux-kselftest lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest16 patches 3 repliesIn review
  2. v616 patches 3 repliesSuperseded
  3. v516 patches 7 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v4 posting 2/216 patches27 repliesSuperseded
v4 posting 1/20 of 16 patches0 repliesSuperseded
v316 patches7 repliesSuperseded
v213 patches20 repliesSuperseded
v113 patches0 repliesSuperseded

Changes in v7 from the cover letter

- Truly use "bound to", not bounded to.
- Fix separator to use 3 dashes

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16selftests/resctrl: Fix closing IMC fds on error and open-code R+W instead of loopstools/testing/selftests/resctrl/resctrl_val.c+36 -180 replies
2/16selftests/resctrl: Calculate resctrl FS derived mem bw over sleep(1) onlytools/testing/selftests/resctrl/resctrl_val.c+91 -500 replies
3/16selftests/resctrl: Make "bandwidth" consistent in comments & printstools/testing/selftests/resctrl/resctrl_val.c tools/testing/selftests/resctrl/resctrlfs.c+8 -80 replies
4/16selftests/resctrl: Consolidate get_domain_id() into resctrl_val()tools/testing/selftests/resctrl/resctrl_val.c+13 -200 replies
5/16selftests/resctrl: Use correct type for pidstools/testing/selftests/resctrl/cache.c tools/testing/selftests/resctrl/resctrl.h tools/testing/selftests/resctrl/resctrl_val.c +1 more+12 -120 replies
6/16selftests/resctrl: Cleanup bm_pid and ppid usage & limit scopetools/testing/selftests/resctrl/resctrl.h tools/testing/selftests/resctrl/resctrl_val.c+15 -170 replies
7/16selftests/resctrl: Rename measure_vals() to measure_mem_bw_vals() & documenttools/testing/selftests/resctrl/resctrl_val.c+8 -30 replies
8/16selftests/resctrl: Simplify mem bandwidth file code for MBA & MBM teststools/testing/selftests/resctrl/mbm_test.c tools/testing/selftests/resctrl/resctrl_val.c+4 -420 replies
9/16selftests/resctrl: Add ->measure() callback to resctrl_val_paramtools/testing/selftests/resctrl/cmt_test.c tools/testing/selftests/resctrl/mba_test.c tools/testing/selftests/resctrl/mbm_test.c +2 more+35 -150 replies
10/16selftests/resctrl: Add ->init() callback into resctrl_val_paramtools/testing/selftests/resctrl/cmt_test.c tools/testing/selftests/resctrl/mba_test.c tools/testing/selftests/resctrl/mbm_test.c +2 more+60 -630 replies
11/16selftests/resctrl: Simplify bandwidth report type handlingtools/testing/selftests/resctrl/mba_test.c tools/testing/selftests/resctrl/mbm_test.c tools/testing/selftests/resctrl/resctrl.h +2 more+20 -250 replies
12/16selftests/resctrl: Make some strings passed to resctrlfs functions consttools/testing/selftests/resctrl/resctrl.h tools/testing/selftests/resctrl/resctrlfs.c+8 -60 replies
13/16selftests/resctrl: Convert ctrlgrp & mongrp to pointerstools/testing/selftests/resctrl/resctrl.h tools/testing/selftests/resctrl/resctrlfs.c+9 -110 replies
14/16selftests/resctrl: Remove mongrp from MBA testtools/testing/selftests/resctrl/mba_test.c+0 -10 replies
15/16selftests/resctrl: Remove mongrp from CMT testtools/testing/selftests/resctrl/cmt_test.c+2 -30 replies
16/16selftests/resctrl: Remove test name comparing from write_bm_pid_to_resctrl()tools/testing/selftests/resctrl/cat_test.c tools/testing/selftests/resctrl/cmt_test.c tools/testing/selftests/resctrl/mba_test.c +4 more+17 -380 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchBabu MogerReinette Chatre
1/16T-b R-b
2/16T-b R-b
3/16T-b R-b
4/16T-b R-b
5/16T-b R-b
6/16T-b R-b
7/16T-b R-b
8/16T-b R-b
9/16T-b R-b
10/16T-b R-b
11/16T-b R-b
12/16T-b R-b
13/16T-b R-b
14/16T-b R-b
15/16T-b R-b
16/16T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 00/16] selftests/resctrl: resctrl_val() related cleanups & improvements

Hi all,

This series does a number of cleanups into resctrl_val() and generalizes it by removing test name specific handling from the function.

v7:
- Truly use "bound to", not bounded to.
- Fix separator to use 3 dashes

v6:
- Adjust closing/rollback of the IMC perf
- Move the comment in measure_vals() to function level
- Capitalize MBM
- binded to -> bound to
- Language tweak into kerneldoc
- Removed stale paragraph from commit message

v5:
- Open mem bw file only once and use rewind().
- Add \n to mem bw file read to allow reading fresh values from the file.
- Return 0 if create_grp() is given NULL grp_name (matches the original behavior). Mention this in function's kerneldoc.
- Cast pid_t to int before printing with %d.
- Caps/typo fixes to kerneldoc and commit messages.
- Use imperative tone in commit messages and improve them based on points that came up during review.

v4:
- Merged close fix into IMC READ+WRITE rework patch
- Add loop to reset imc_counters_config fds to -1 to be able know which need closing
- Introduce perf_close_imc_mem_bw() to close fds
- Open resctrl mem bw file (twice) beforehand to avoid opening it during the test
- Remove MBM .mongrp setup
- Remove mongrp from CMT test

v3:
- Rename init functions to <testname>_init()
- Replace for loops with READ+WRITE statements for clarity
- Don't drop Return: entry from perf_open_imc_mem_bw() func comment
- New patch: Fix closing of IMC fds in case of error
- New patch: Make "bandwidth" consistent in comments & prints
- New patch: Simplify mem bandwidth file code
- Remove wrong comment
- Changed grp_name check to return -1 on fail (internal sanity check)

v2:
- Resolved conflicts with kselftest/next
- Spaces -> tabs correction

Ilpo Järvinen (16):
selftests/resctrl: Fix closing IMC fds on error and open-code R+W
instead of loops
selftests/resctrl: Calculate resctrl FS derived mem bw over sleep(1)
only
selftests/resctrl: Make "bandwidth" consistent in comments & prints selftests/resctrl: Consolidate get_domain_id() into resctrl_val() selftests/resctrl: Use correct type for pids selftests/resctrl: Cleanup bm_pid and ppid usage & limit scope selftests/resctrl: Rename measure_vals() to measure_mem_bw_vals() &
document
selftests/resctrl: Simplify mem bandwidth file code for MBA & MBM
tests
selftests/resctrl: Add ->measure() callback to resctrl_val_param selftests/resctrl: Add ->init() callback into resctrl_val_param selftests/resctrl: Simplify bandwidth report type handling selftests/resctrl: Make some strings passed to resctrlfs functions
const
selftests/resctrl: Convert ctrlgrp & mongrp to pointers selftests/resctrl: Remove mongrp from MBA test selftests/resctrl: Remove mongrp from CMT test selftests/resctrl: Remove test name comparing from
write_bm_pid_to_resctrl()

 tools/testing/selftests/resctrl/cache.c       |  10 +-
 tools/testing/selftests/resctrl/cat_test.c    |   5 +-
 tools/testing/selftests/resctrl/cmt_test.c    |  22 +-
 tools/testing/selftests/resctrl/mba_test.c    |  26 +-
 tools/testing/selftests/resctrl/mbm_test.c    |  26 +-
 tools/testing/selftests/resctrl/resctrl.h     |  49 ++-
 tools/testing/selftests/resctrl/resctrl_val.c | 371 ++++++++----------
 tools/testing/selftests/resctrl/resctrlfs.c   |  67 ++--
 8 files changed, 291 insertions(+), 285 deletions(-)
Signature · 1 line
2.39.2