backup: allow specifying minimum cluster size
Status from this message: Thanks, applied to my block branch.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 3 repliesApplied
- v22 patches 5 repliesSuperseded
- v12 patches 5 repliesSuperseded
Changes in v3 from the cover letter
* Pass min_cluster_size option directly without checking has_min_cluster_size, because the default is 0 anyways.
* Calculate maximum of passed-in argument and default once at the beginning of block_copy_calculate_cluster_size()
* Update warning message to reflect actual value used
* Do not leak qdict in error case
* Use PRI{i,u}64 macros
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | copy-before-write: allow specifying minimum cluster sizeblock/ block/ include/ +1 more | +38 | 1 reply | |
| 2/2 | backup: add minimum cluster size to performance optionsblock/ block/ block/ +2 more | +21 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Markus Armbruster | Vladimir Sementsov-Ogievskiy |
|---|---|---|
| 1/2 | A-b | R-b |
| 2/2 | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/2] backup: allow specifying minimum cluster size
Discussion for v2:
https://lore.kernel.org/qemu-devel/[email protected]/
Changes in v3:
* Pass min_cluster_size option directly without checking has_min_cluster_size, because the default is 0 anyways.
* Calculate maximum of passed-in argument and default once at the beginning of block_copy_calculate_cluster_size()
* Update warning message to reflect actual value used
* Do not leak qdict in error case
* Use PRI{i,u}64 macros
Discussion for v1:
https://lore.kernel.org/qemu-devel/[email protected]/
-
Changes in v2:
* Use 'size' type in QAPI.
* Remove option in cbw_parse_options(), i.e. before parsing generic blockdev options.
* Reword commit messages hoping to describe the issue in a more straight-forward way.
In the context of backup fleecing, discarding the source will not work when the fleecing image has a larger granularity than the one used for block-copy operations (can happen if the backup target has smaller cluster size), because cbw_co_pdiscard_snapshot() will align down the discard requests and thus effectively ignore then.
To make @discard-source work in such a scenario, allow specifying the minimum cluster size used for block-copy operations and thus in particular also the granularity for discard requests to the source.
Fiona Ebner (2):
copy-before-write: allow specifying minimum cluster size
backup: add minimum cluster size to performance options
block/backup.c | 2 +- block/block-copy.c | 36 ++++++++++++++++++++++++++---------- block/copy-before-write.c | 14 +++++++++++++- block/copy-before-write.h | 1 + blockdev.c | 3 +++ include/block/block-copy.h | 1 + qapi/block-core.json | 17 ++++++++++++++--- 7 files changed, 59 insertions(+), 15 deletions(-)
Signature · 1 line
2.39.2