Skip to content

Improve trap handling for nested traps

Anup Patel opensbi 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 0 repliesNew
  2. v210 patches 0 repliesSuperseded
  3. v19 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Addressed comments in PATCH4, PATCH6, PATCH7, PATCH8, and PATCH10.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10lib: sbi: Remove epc from struct sbi_trap_infoinclude/sbi/sbi_trap.h lib/sbi/sbi_ecall_legacy.c lib/sbi/sbi_expected_trap.S +3 more+8 -270 replies
2/10lib: sbi: Remove sbi_trap_exit() and related codefirmware/fw_base.S include/sbi/sbi_scratch.h include/sbi/sbi_trap.h +1 more+3 -440 replies
3/10include: sbi: Add trap_context pointer in struct sbi_scratchfirmware/fw_base.S include/sbi/sbi_scratch.h+14 -40 replies
4/10lib: sbi: Introduce trap contextfirmware/fw_base.S include/sbi/sbi_trap.h lib/sbi/sbi_trap.c+103 -460 replies
5/10lib: sbi: Simplify parameters of misaligned and access fault handlersinclude/sbi/sbi_trap_ldst.h lib/sbi/sbi_trap.c lib/sbi/sbi_trap_ldst.c+40 -470 replies
6/10lib: sbi: Simplify parameters of sbi_illegal_insn_handler()include/sbi/sbi_illegal_insn.h lib/sbi/sbi_illegal_insn.c lib/sbi/sbi_trap.c+7 -60 replies
7/10lib: sbi: Remove regs paramter of sbi_irqchip_process()include/sbi/sbi_irqchip.h lib/sbi/sbi_irqchip.c lib/sbi/sbi_trap.c +1 more+10 -110 replies
8/10lib: sbi: Remove regs parameter from trap irq handling functionsinclude/sbi/riscv_encoding.h lib/sbi/sbi_trap.c+8 -70 replies
9/10lib: sbi: Pass trap context pointer to sbi_ecall_handler()include/sbi/sbi_ecall.h lib/sbi/sbi_ecall.c lib/sbi/sbi_trap.c+5 -40 replies
10/10lib: sbi: Extend sbi_trap_error() to dump state in a nested traplib/sbi/sbi_trap.c+60 -450 replies

Reviews trailers per patch

9 of 10 patches have a Reviewed-by or Acked-by.

PatchAnup PatelSamuel HollandCl?ment L?ger
1/10R-b
2/10R-b T-b
3/10R-b T-b
4/10R-b T-b
5/10R-b T-b R-b
6/10R-b T-b
7/10R-b T-b R-b
8/10R-b T-b
9/10R-b T-b R-b
10/10T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/10] Improve trap handling for nested traps

Nested traps will be a common when dealing with RAS error traps so this series improves trap handling for nested traps by introducing a linked-list based trap context chain.

These patches can also be found the trap_handling_imp_v3 branch at
https://github.com/avpatel/opensbi.git

Changes since v2:
- Addressed comments in PATCH4, PATCH6, PATCH7, PATCH8, and PATCH10.

Changes since v1:
- Include samuel's patch in the series
- Embed sbi_trap_regs and sbi_trap_info in the new struct sbi_trap_context
- Drop the mcause parameter of sbi_trap_aia_irq()

Anup Patel (9):
lib: sbi: Remove sbi_trap_exit() and related code
include: sbi: Add trap_context pointer in struct sbi_scratch
lib: sbi: Introduce trap context
lib: sbi: Simplify parameters of misaligned and access fault handlers
lib: sbi: Simplify parameters of sbi_illegal_insn_handler()
lib: sbi: Remove regs paramter of sbi_irqchip_process()
lib: sbi: Remove regs parameter from trap irq handling functions
lib: sbi: Pass trap context pointer to sbi_ecall_handler()
lib: sbi: Extend sbi_trap_error() to dump state in a nested trap

Samuel Holland (1):
lib: sbi: Remove epc from struct sbi_trap_info

 firmware/fw_base.S             |  76 +++++++++----
 include/sbi/riscv_encoding.h   |   2 +
 include/sbi/sbi_ecall.h        |   4 +-
 include/sbi/sbi_illegal_insn.h |   4 +-
 include/sbi/sbi_irqchip.h      |   5 +-
 include/sbi/sbi_scratch.h      |  14 +--
 include/sbi/sbi_trap.h         |  45 ++++++--
 include/sbi/sbi_trap_ldst.h    |  12 +-
 lib/sbi/sbi_ecall.c            |   3 +-
 lib/sbi/sbi_ecall_legacy.c     |   4 -
 lib/sbi/sbi_expected_trap.S    |   4 -
 lib/sbi/sbi_illegal_insn.c     |   9 +-
 lib/sbi/sbi_irqchip.c          |  10 +-
 lib/sbi/sbi_trap.c             | 196 +++++++++++++++------------------
 lib/sbi/sbi_trap_ldst.c        |  71 ++++++------
 lib/utils/irqchip/imsic.c      |   2 +-
 16 files changed, 239 insertions(+), 222 deletions(-)
Signature · 1 line
2.34.1