Skip to content

Improve performance of 'faddr2line'

Brian Johannesmeyer lkml 2 versions – Applied

Status from this message: The following commit has been merged into the objtool/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 0 repliesApplied
  2. v17 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Correctly handle duplicate sym_names

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7scripts/faddr2line: Reduce number of readelf calls to threescripts/faddr2line+17 -90 replies
2/7scripts/faddr2line: Combine three readelf calls into onescripts/faddr2line+8 -40 replies
3/7scripts/faddr2line: Check vmlinux only oncescripts/faddr2line+14 -110 replies
4/7scripts/faddr2line: Pass --addresses argument to addr2linescripts/faddr2line+5 -20 replies
5/7scripts/faddr2line: Invoke addr2line as a single long-running processscripts/faddr2line+45 -70 replies
6/7scripts/faddr2line: Remove call to addr2line from find_dir_prefix()scripts/faddr2line+7 -50 replies
7/7scripts/faddr2line: Check only two symbols when calculating symbol sizescripts/faddr2line+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] Improve performance of 'faddr2line'

This is the second attempt at submitting this. Version 1 can be found here:
https://lore.kernel.org/lkml/[email protected]/.

I was looking at the performance of faddr2line and noticed that it spends most of its time performing two tasks:
- (1) Making redundant calls to readelf and addr2line for each address (e.g., it makes 7 readelf calls and 2 addr2line calls when converting 1
address, and it makes 252 readelf calls and 51 addr2line calls when converting 50 addresses); and
- (2) Calculating a symbol’s size by unnecessarily looping through every symbol in a particular section.

This patch series consists of the following parts:
- Patches 1-2 reduce the total number of readelf calls to one,
- Patches 3-4 make minor changes in preparation for the following patches,
- Patches 5-6 reduce the total number of addr2line calls to one, and
- Patch 7 modifies the symbol size calculation to only check two symbols.

I evaluated the performance of the patch series by running faddr2line with a standard kernel image (X86_64 defconfig with CONFIG_DEBUG_INFO enabled). When converting only 1 address, the patch series gives a negligible speedup. When converting 50 addresses, however, it gives a 15x speedup.

Changes vs. V1:
- Correctly handle duplicate sym_names

Brian Johannesmeyer (7):
scripts/faddr2line: Reduce number of readelf calls to three scripts/faddr2line: Combine three readelf calls into one scripts/faddr2line: Check vmlinux only once scripts/faddr2line: Pass --addresses argument to addr2line scripts/faddr2line: Invoke addr2line as a single long-running process scripts/faddr2line: Remove call to addr2line from find_dir_prefix() scripts/faddr2line: Check only two symbols when calculating symbol
size

 scripts/faddr2line | 110 ++++++++++++++++++++++++++++++++++-----------
 1 file changed, 84 insertions(+), 26 deletions(-)
Signature · 1 line
2.34.1