Skip to content

Ensure _scratch_fuzz_modify() works for other filesystems

Luis Henriques (SUSE) fstests 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* Updated the second patch commit message to add further details on what changed with the test output.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2common/fuzzy: make _scratch_fuzz_modify work for non-xfs filesystemscommon/fuzzy+9 -71 reply
2/2ext4/006: take into account updates to _scratch_fuzz_modify()tests/ext4/006+1 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDarrick J. Wong
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Ensure _scratch_fuzz_modify() works for other filesystems

Hi!

I guess test ext4/006 isn't executed very often, because as far as I can see it has been broken for quite some time. The problem is that the function _scratch_fuzz_modify() is executing xfs-specific operations that will make this test fail.

The first patch updates this function so that xfs-specific operations are executed only when that filesystem is being tested.

The second patch simply updates the test to take into account the new output of the function (and yeah, counting log lines is an ugly hack).

Changes since v1:
* Updated the second patch commit message to add further details on what changed with the test output.

Luis Henriques (SUSE) (2):
common/fuzzy: make _scratch_fuzz_modify work for non-xfs filesystems ext4/006: take into account updates to _scratch_fuzz_modify()

 common/fuzzy   | 16 +++++++++-------
 tests/ext4/006 |  2 +-
 2 files changed, 10 insertions(+), 8 deletions(-)