bpf: Allow helper bpf_get_[ns_]current_pid_tgid() for all prog types
Status from this message: This series was applied to bpf/bpf-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first
Changes in v2 from the cover letter
- allow bpf_get_[ns_]current_pid_tgid() for all prog types.
- for network related selftests, using netns.
Patches in v2 All 5 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | bpf: Allow helper bpf_get_[ns_]current_pid_tgid() for all prog typeskernel/ kernel/ kernel/ +1 more | +4 | 1 reply | Applied |
| 2/5 | selftests/bpf: Replace CHECK with ASSERT_* in ns_current_pid_tgid testtools/ | +19 | 5 replies | Applied |
| 3/5 | selftests/bpf: Refactor out some functions in ns_current_pid_tgid testtools/ tools/ | +41 | 0 replies | Applied |
| 4/5 | selftests/bpf: Add a cgroup prog bpf_get_ns_current_pid_tgid() testtools/ tools/ | +80 | 0 replies | Applied |
| 5/5 | selftests/bpf: Add a sk_msg prog bpf_get_ns_current_pid_tgid() testtools/ tools/ | +76 | 0 replies | Applied |
Reviews trailers per patch
2 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Jiri Olsa |
|---|---|
| 1/5 | A-b |
| 2/5 | A-b |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH bpf-next v2 0/5] bpf: Allow helper bpf_get_[ns_]current_pid_tgid() for all prog types
Currently bpf_get_current_pid_tgid() is allowed in tracing, cgroup and sk_msg progs while bpf_get_ns_current_pid_tgid() is only allowed in tracing progs.
We have an internal use case where for an application running in a container (with pid namespace), user wants to get the pid associated with the pid namespace in a cgroup bpf program. Besides cgroup, the only prog type, supporting bpf_get_current_pid_tgid() but not bpf_get_ns_current_pid_tgid(), is sk_msg.
But actually both bpf_get_current_pid_tgid() and bpf_get_ns_current_pid_tgid() helpers do not reveal kernel internal data and there is no reason that they cannot be used in other program types. This patch just did this and enabled these two helpers for all program types.
Patch 1 added the kernel support and patches 2-5 added the test for cgroup and sk_msg.
Change logs:
v1 -> v2:
- allow bpf_get_[ns_]current_pid_tgid() for all prog types.
- for network related selftests, using netns.
Yonghong Song (5):
bpf: Allow helper bpf_get_[ns_]current_pid_tgid() for all prog types selftests/bpf: Replace CHECK with ASSERT_* in ns_current_pid_tgid test selftests/bpf: Refactor out some functions in ns_current_pid_tgid test selftests/bpf: Add a cgroup prog bpf_get_ns_current_pid_tgid() test selftests/bpf: Add a sk_msg prog bpf_get_ns_current_pid_tgid() test
kernel/bpf/cgroup.c | 2 - kernel/bpf/helpers.c | 4 + kernel/trace/bpf_trace.c | 4 - net/core/filter.c | 2 - .../bpf/prog_tests/ns_current_pid_tgid.c | 214 +++++++++++++++--- .../bpf/progs/test_ns_current_pid_tgid.c | 31 ++- 6 files changed, 215 insertions(+), 42 deletions(-)
Signature · 1 line
2.43.0