ui/cocoa: Add cursor composition
Get series with b4
b4 am [email protected] change-id 20240318-cursor-3491b1806582Versions newest first
- v3 Latest4 patches 3 repliesIn review
- v24 patches 11 repliesSuperseded
- v12 patches 1 replySuperseded
Changes in v3 from the cover letter
- Incorporated changes from:
"[PATCH v3 1/4] ui/cocoa: Typo fix in based-on patches"
- Link to v2: https://lore.kernel.org/r/[email protected]
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | ui/cocoa: Release CGColorSpaceui/ | +4 | 1 reply | |
| 2/4 | ui/console: Convert mouse visibility parameter into boolhw/ hw/ hw/ +7 more | +19 | 1 reply | |
| 3/4 | ui/cocoa: Add cursor compositionmeson.build ui/ | +101 | 0 replies | |
| 4/4 | ui/console: Remove dpy_cursor_define_supported()hw/ hw/ include/ +1 more | +2 | 0 replies |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Phil Dennis-Jordan | Marc-André Lureau | Philippe Mathieu-Daudé |
|---|---|---|---|
| 1/4 | T-b | R-b | |
| 2/4 | T-b | R-b | R-b |
| 3/4 | Co-authored-by T-b | ||
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/4] ui/cocoa: Add cursor composition
Add accelerated cursor composition to ui/cocoa. This does not only improve performance for display devices that exposes the capability to the guest according to dpy_cursor_define_supported(), but fixes the cursor display for devices that unconditionally expects the availability of the capability (e.g., virtio-gpu).
The common pattern to implement accelerated cursor composition is to replace the cursor and warp it so that the replaced cursor is shown at the correct position on the guest display for relative pointer devices. Unfortunately, ui/cocoa cannot do the same because warping the cursor position interfers with the mouse input so it uses CALayer instead; although it is not specialized for cursor composition, it still can compose images with hardware acceleration.
---
Changes in v3:
- Incorporated changes from:
"[PATCH v3 1/4] ui/cocoa: Typo fix in based-on patches"
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Incorporated changes from:
https://lore.kernel.org/r/[email protected]
("[PATCH v2 1/2] ui/cocoa: Minor fixes to CALayer based cursors")
- Added patch "ui/cocoa: Release CGColorSpace"
- Added patch "ui/console: Convert mouse visibility parameter into bool"
- Noted that the problem with warping is relevant only for relative pointer devices.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Akihiko Odaki (4):
ui/cocoa: Release CGColorSpace
ui/console: Convert mouse visibility parameter into bool ui/cocoa: Add cursor composition
ui/console: Remove dpy_cursor_define_supported()
meson.build | 3 +- include/ui/console.h | 5 +-- hw/display/ati.c | 2 +- hw/display/qxl-render.c | 4 -- hw/display/virtio-gpu.c | 3 +- hw/display/vmware_vga.c | 8 ++-- ui/console.c | 18 ++------- ui/dbus-listener.c | 2 +- ui/gtk.c | 2 +- ui/sdl2.c | 4 +- ui/spice-display.c | 11 ++--- ui/vnc.c | 2 +- ui/cocoa.m | 104 +++++++++++++++++++++++++++++++++++++++++++++++- 13 files changed, 126 insertions(+), 42 deletions(-)
---
base-commit: 74abb45dac6979e7ff76172b7f0a24e869405184
change-id: 20240318-cursor-3491b1806582
Best regards,
Signature · 1 line
Akihiko Odaki <[email protected]>