Skip to content

i40e: cleanups & refactors

Ivan Vecera intel-wired-lan lkml netdev 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 7 repliesIn review
  2. v37 patches 0 repliesSuperseded
  3. v2 posting 2/27 patches 17 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 1/20 of 7 patches1 replySuperseded
v17 patches9 repliesSuperseded

Changes in v4 from the cover letter

- fixed new kdoc warnings

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7i40e: Remove flags field from i40e_vebdrivers/net/ethernet/intel/i40e/i40e.h drivers/net/ethernet/intel/i40e/i40e_debugfs.c drivers/net/ethernet/intel/i40e/i40e_main.c+7 -111 reply
2/7i40e: Refactor argument of several client notification functionsdrivers/net/ethernet/intel/i40e/i40e.h drivers/net/ethernet/intel/i40e/i40e_client.c drivers/net/ethernet/intel/i40e/i40e_main.c+17 -191 reply
3/7i40e: Refactor argument of i40e_detect_recover_hung()drivers/net/ethernet/intel/i40e/i40e_main.c drivers/net/ethernet/intel/i40e/i40e_txrx.c drivers/net/ethernet/intel/i40e/i40e_txrx.h+8 -61 reply
4/7i40e: Add helper to access main VSIdrivers/net/ethernet/intel/i40e/i40e.h drivers/net/ethernet/intel/i40e/i40e_client.c drivers/net/ethernet/intel/i40e/i40e_ddp.c +6 more+116 -831 reply
5/7i40e: Consolidate checks whether given VSI is maindrivers/net/ethernet/intel/i40e/i40e_debugfs.c drivers/net/ethernet/intel/i40e/i40e_ethtool.c drivers/net/ethernet/intel/i40e/i40e_main.c+16 -171 reply
6/7i40e: Add helper to access main VEBdrivers/net/ethernet/intel/i40e/i40e.h drivers/net/ethernet/intel/i40e/i40e_ethtool.c drivers/net/ethernet/intel/i40e/i40e_main.c+31 -161 reply
7/7i40e: Add and use helper to reconfigure TC for given VSIdrivers/net/ethernet/intel/i40e/i40e_main.c+24 -81 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchMichal SchmidtAleksandr LoktionovKalesh APTony NguyenPucha Himasekhar ReddySimon Horman
1/7R-b R-b R-b R-b T-b R-b
2/7R-b R-b T-b R-b
3/7R-b R-b T-b R-b
4/7R-b R-b T-b R-b
5/7R-b R-b T-b R-b
6/7R-b R-b R-b T-b R-b
7/7R-b R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v4 thread

Cover letter [PATCH net-next v4 0/7] i40e: cleanups & refactors

This series do following:
Patch 1 - Removes write-only flags field from i40e_veb structure and
from i40e_veb_setup() parameters
Patch 2 - Refactors parameter of i40e_notify_client_of_l2_param_changes()
and i40e_notify_client_of_netdev_close()
Patch 3 - Refactors parameter of i40e_detect_recover_hung() Patch 4 - Adds helper i40e_pf_get_main_vsi() to get main VSI and uses it
in existing code
Patch 5 - Consolidates checks whether given VSI is the main one Patch 6 - Adds helper i40e_pf_get_main_veb() to get main VEB and uses it
in existing code
Patch 7 - Adds helper i40e_vsi_reconfig_tc() to reconfigure TC for
particular and uses it to replace existing open-coded pieces

Note that this series should go directly to net-next as the IWL review and validation were already done.

Changes since v3:
- fixed new kdoc warnings
Changes since v2:
- resubmitted per Tony's request (no new kdoc errors were found)
- added existing reviewed-by and tested-by tags Changes since v1:
- adjusted titles for patches 2 & 3

Ivan Vecera (7):
i40e: Remove flags field from i40e_veb
i40e: Refactor argument of several client notification functions
i40e: Refactor argument of i40e_detect_recover_hung()
i40e: Add helper to access main VSI
i40e: Consolidate checks whether given VSI is main
i40e: Add helper to access main VEB
i40e: Add and use helper to reconfigure TC for given VSI

 drivers/net/ethernet/intel/i40e/i40e.h        |  29 ++-
 drivers/net/ethernet/intel/i40e/i40e_client.c |  28 +--
 drivers/net/ethernet/intel/i40e/i40e_ddp.c    |   3 +-
 .../net/ethernet/intel/i40e/i40e_debugfs.c    |  36 ++--
 .../net/ethernet/intel/i40e/i40e_ethtool.c    |  29 ++-
 drivers/net/ethernet/intel/i40e/i40e_main.c   | 200 ++++++++++--------
 drivers/net/ethernet/intel/i40e/i40e_ptp.c    |   6 +-
 drivers/net/ethernet/intel/i40e/i40e_txrx.c   |  16 +-
 drivers/net/ethernet/intel/i40e/i40e_txrx.h   |   2 +-
 .../ethernet/intel/i40e/i40e_virtchnl_pf.c    |  14 +-
 10 files changed, 211 insertions(+), 152 deletions(-)
Signature · 1 line
2.43.2