Skip to content

commit,add: error out when passing untracked path

Ghanshyam Thakkar git 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 0 repliesNew
  2. v33 patches 4 repliesSuperseded
  3. v23 patches 10 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3revision: optionally record matches with pathspec elementsbuiltin/add.c builtin/checkout.c builtin/commit.c +4 more+23 -100 replies
2/3builtin/commit: error out when passing untracked path with -ibuiltin/commit.c t/t7501-commit-basic-functionality.sh+7 -160 replies
3/3builtin/add: error out when passing untracked path with -ubuiltin/add.c t/t2200-add-update.sh+18 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3] commit,add: error out when passing untracked path

This version makes the changes as suggested by Junio. In particular, changed exit codes from 1 to 128. And, removed unnecessary free() calls immediately before exiting.

Ghanshyam Thakkar (2):
builtin/commit: error out when passing untracked path with -i builtin/add: error out when passing untracked path with -u

Junio C Hamano (1):
revision: optionally record matches with pathspec elements

 builtin/add.c                         | 11 +++++++++--
 builtin/checkout.c                    |  3 ++-
 builtin/commit.c                      |  7 ++++++-
 diff-lib.c                            | 11 ++++++++++-
 read-cache-ll.h                       |  4 ++--
 read-cache.c                          |  8 +++++---
 revision.h                            |  1 +
 t/t2200-add-update.sh                 | 10 ++++++++++
 t/t7501-commit-basic-functionality.sh | 16 +---------------
 9 files changed, 46 insertions(+), 25 deletions(-)
Signature · 1 line
2.44.0